Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1655670imm; Thu, 20 Sep 2018 00:18:03 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZT/E6nEq834Joobb/EYlPTkmBbav5T2NoSvjMaYmHbBtcEcumfuXJ18tHgwQoaJoLMfAN4 X-Received: by 2002:a63:b54:: with SMTP id a20-v6mr36102158pgl.280.1537427883193; Thu, 20 Sep 2018 00:18:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537427883; cv=none; d=google.com; s=arc-20160816; b=G2ecMuiUrCKKizmAkfm6rYAxhUF6CiNxyIiZuv2gpnsBMWpTl6F9NFQostker1zYly CbSzCQHuJiO8MIchVAB2fAcMacHZI3H+8YYBuCWUJJrKoGTJ1psoQZtMgrDsCz9VrIR3 INjGVKl6MHgRY7gSuO32bVCvZGv5PGjFX4EEtfnQZGwlM163BrEs+1oHrlGkIYARypKA V2s4xLIVvW8KT+/lTjS1cqD1bCxzExdIbqUy0L2TA8IFyL1lg8462uU2v1AFB41+1Tym tPBZX+cSMiFXjqNGxmGJp3AKrc2PBXcjCWYZhWuslyvkgN+1C5CCz6aKCStW2FvX2D9w TlaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=o45BfiKedxcgz2Kei1P9RrRzMb0fwHIOuRFBgmeTmOo=; b=gi8GYpv6b/oEWmai7EmkDoP9kmVw9KqD4ND3N9NmoAUSWsD3LjggCP+IEceQKd0vpU f14qXpjxYqTs3Hltn33ZD0oqy2iwUOX8HyopCf5/95s23hfpq0fWLLaap8pHIsi0IPZ9 w5nueQve+0cB+bV2gfM7b+CybZx9e/PA0pKiJ4lFqOvhbGQ0uP270mmusRr/N6zBHIQK /ptCiGGAFVcoAsAJCHfZkpckyJAjJoZQivCZxupH8RbELuLf3Qj+1MrhL5Hx+zWLUusA /z1IeSIOUkzmSrI3ZVdk6HwQFqjvicliU/yHCb6Spg+ngpMfiPrxnrzb6utZ5v3BlpUl 2kUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si22982422pla.307.2018.09.20.00.17.48; Thu, 20 Sep 2018 00:18:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731562AbeITM6E (ORCPT + 99 others); Thu, 20 Sep 2018 08:58:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:58928 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726014AbeITM6E (ORCPT ); Thu, 20 Sep 2018 08:58:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 01522B049; Thu, 20 Sep 2018 07:16:02 +0000 (UTC) From: Johannes Thumshirn To: "Martin K . Petersen" Cc: Linux Kernel Mailinglist , Linux SCSI Mailinglist , Johannes Thumshirn , Hannes Reinecke , Bart Van Asche , Christoph Hellwig Subject: [PATCH] scsi: sd: don't crash the host on invalid commands Date: Thu, 20 Sep 2018 09:15:50 +0200 Message-Id: <20180920071550.9866-1-jthumshirn@suse.de> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When sd_init_command() get's a with a unknown req_op() it crashes the system via BUG(). This makes debugging the actual reason for the broken request cmd_flags pretty hard as the system is down before it's able to write out debugging data on the serial console or the trace buffer. Change the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Asche Cc: Christoph Hellwig --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index b79b366a94f7..19f28962d65b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1276,7 +1276,8 @@ static int sd_init_command(struct scsi_cmnd *cmd) case REQ_OP_ZONE_RESET: return sd_zbc_setup_reset_cmnd(cmd); default: - BUG(); + WARN_ON(1); + return BLKPREP_KILL; } } -- 2.16.4