Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1702718imm; Thu, 20 Sep 2018 01:15:27 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbMZHKu20hbZWiDYedLtuT+2eKa0/9DSAGOaKyLzeFP+k5RAgZ5c4hmg9zBopJDHZlvIsCQ X-Received: by 2002:a17:902:bd98:: with SMTP id q24-v6mr22633134pls.22.1537431326934; Thu, 20 Sep 2018 01:15:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537431326; cv=none; d=google.com; s=arc-20160816; b=dkfnGil/j2RfYY0A6MWAEotfgWHRi28CN02i9MxatxEbDM9FUMFMD4LMfBgBzMQLfx bnQ+1gdVf9pIgJMOAXOqjc5bScvjXSof+SB26BHhk0VL5XhewQzmwzLzlJkY2m/rW5I6 i3uRNC4C6hEdYKLjugAWlQR2qgocIZqRF+TLIx8sAvjMWYVf+QHvaJbLuPbg/ijTMC44 w6lcMBGpHFSZL6tJ+/vJDOI1CBDY/NMe3oukhyflKXQ230W1JlOjDCXpd28hKvReRWWV ENXZotD8vRVnk5bpMFGJuvEybfF5PaK/FowcKiaCxBlDfno8M/y9RQYCoqIvu0gzkFs0 LgGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=9s4ZqphtCgCVHVg9ms2wIFPA0dz6pZErVhWC4kmg2LE=; b=TVQaT+PZiuHmyBjj9Fj0W/r/iVf+eQNrukWdro8Zk8Qq2UHI4OviIydU8+CdaPv7pL LLo5SLKHaP2nYnU1iwrbWaTwmjQ+An4fFfFi8lWlk9KaZM0mT3jVS6R7KoYLQNA4yMFx zWbSyAb2Y/+v+pR9BMsTn8NYZBjSCBcpDP3q+wWdctblL7Q11+jaEhyV0wFcFrUndXiE dLyiSDum1Wyi43O6EV5+prFLicnoCtI3LiSj0yVzvPPKOyphc1zjP1XlaLJzgMJ6iAdy 0HbDHUIHqC1sm3Ph8bCcVIdIDd2fQcNFE/KRKC+bb27c6ooW49EwfjcBDG7EQnBGTq0+ 30uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5-v6si22559536pgc.210.2018.09.20.01.15.10; Thu, 20 Sep 2018 01:15:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731689AbeITN5D (ORCPT + 99 others); Thu, 20 Sep 2018 09:57:03 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:12630 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730172AbeITN5D (ORCPT ); Thu, 20 Sep 2018 09:57:03 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 320823FD69C2A; Thu, 20 Sep 2018 16:14:45 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 16:14:43 +0800 From: zhong jiang To: CC: , , , Subject: [PATCH] net: netronome: remove redundant continue Date: Thu, 20 Sep 2018 16:02:21 +0800 Message-ID: <1537430541-37817-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The continue will not truely skip any code. hence it is safe to remove it. Signed-off-by: zhong jiang --- drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c index 0b1ac9c..50d7b58 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c @@ -230,10 +230,8 @@ static void nfp_net_pf_free_vnics(struct nfp_pf *pf) ctrl_bar += NFP_PF_CSR_SLICE_SIZE; /* Kill the vNIC if app init marked it as invalid */ - if (nn->port && nn->port->type == NFP_PORT_INVALID) { + if (nn->port && nn->port->type == NFP_PORT_INVALID) nfp_net_pf_free_vnic(pf, nn); - continue; - } } if (list_empty(&pf->vnics)) -- 1.7.12.4