Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1713291imm; Thu, 20 Sep 2018 01:28:29 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbwaO3w9pIuS4A8xbiYTiQEBvbnWSSvu4LlKsHpjgvXxrfA5VACRZgmuuEhWNzgUvyrwf1c X-Received: by 2002:a62:6690:: with SMTP id s16-v6mr40145887pfj.152.1537432109224; Thu, 20 Sep 2018 01:28:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537432109; cv=none; d=google.com; s=arc-20160816; b=ZlTL4E8zSCmSi0VWGoLq6IzVISqhTV8oXag9FJP0eYZRDo02Y45wkKknRK9+qtapfB LcoSFKzkKztZOqdt00PEZqAPvYUiI5TELPWGhf7uMMFndoxEqCqQqjqVyTo0OrofH9Ah tgyYopHoa9mRYC5QtK/gGviRWM6XuApgkEUIRYP6NV2oyGLB/VhLK7T996zEO0vQ0miO o5E0ZUzDTNOkLvCNi0gFK2oqUmSQFGvPGvQakAOb10bLEk7iNRV9bUVOckjfbr0EGcHa CxrH3DXhsh5vZvB97jZ1aejHcs7c6KTiRX/WggAlPde16iJ79MuRgWDHLC7oDdBBSdm6 +9iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=kCEW0UkAC3Xs9wk1HfdSO8aCojLynpowxtq2WHL2YkA=; b=HlYGlrK3wse6kU0DVih1O9jeJhGb3p1JgPBgA+iHtNCwaKhdMNxuVdnwGAhLxeuP1T OXSnxRv3AHfZDI97UvyhEqQsBlY993fthNB3QDckIXANlF8XrQnCKSbH9UliTRxP/o9S 02V7WtSFy5pyEtFtMJhCisOhXD4yishG/BtU5Pv6t6F3ixPtJsoylxCbM44liX68UsXu bd4vJFl+J26EaCGyrrlfm9s89S/kJ4U7frGnjo6TWkGBCk3GnxEnaTTWB37n5LiSAAcV e/3FsO/m+udCuq9i6im7kgYRsa5CxICT4RuBZLNccHQD0cRn07YEBhywfGK04qzPlTw8 aQHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d27-v6si22842520pgd.223.2018.09.20.01.28.13; Thu, 20 Sep 2018 01:28:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731943AbeITOI3 (ORCPT + 99 others); Thu, 20 Sep 2018 10:08:29 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:59953 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726177AbeITOI3 (ORCPT ); Thu, 20 Sep 2018 10:08:29 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CAB183293DFDE; Thu, 20 Sep 2018 16:26:07 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 16:26:08 +0800 From: zhong jiang To: CC: , , Subject: [PATCH] net: neterion: remove redundant continue Date: Thu, 20 Sep 2018 16:13:47 +0800 Message-ID: <1537431227-38435-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The continue will not truely skip any code. hence it is safe to remove it. Signed-off-by: zhong jiang --- drivers/net/ethernet/neterion/s2io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index f980f10..3c2ac6af 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -3679,11 +3679,9 @@ static void restore_xmsi_data(struct s2io_nic *nic) writeq(nic->msix_info[i].data, &bar0->xmsi_data); val64 = (s2BIT(7) | s2BIT(15) | vBIT(msix_index, 26, 6)); writeq(val64, &bar0->xmsi_access); - if (wait_for_msix_trans(nic, msix_index)) { + if (wait_for_msix_trans(nic, msix_index)) DBG_PRINT(ERR_DBG, "%s: index: %d failed\n", __func__, msix_index); - continue; - } } } -- 1.7.12.4