Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1830673imm; Thu, 20 Sep 2018 03:41:43 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda9pmDi2Q7ncdqmOJcf5gcf3/Skw2/4BXCs/Y173hv4ShlzEXwosellB1n9dxIk1uYqRCqt X-Received: by 2002:a17:902:b212:: with SMTP id t18-v6mr39599090plr.107.1537440103739; Thu, 20 Sep 2018 03:41:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537440103; cv=none; d=google.com; s=arc-20160816; b=UNKNqO42/DsQrviKI5oBFwcbFmwwJvjlecjyaGqV9pQs1FzDtZwBfrr/67edfjK+P7 naxAPPXZec1OC9BSeYmzg6iFrJGTtlB4YprT4rI/OVW1OB+WU/cFjG/ruQZJv6C6cPAo M420aCckvugjtXrRKhIZoRz+EUoHkN9yWwtacKhuxf0T9PheRryH8MVarxiSVfdNlu9G 6QBmyvFMexLkhNlKn2OgndOnGmdoq11pUaHQgGW7x9pbMWigcKzPH5qnPaq9NwKexVIn LjP/EvJf00yDhyRna82hTyvXpAllKrom38WYhz+JsciMrHBZ3hC5LAqapxq8x29UURLU CcZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1Dful2uAZ2oj/YOd8Qpd+Uth60fAPIT1lRmX13TSE9w=; b=PEQiEMbtoxkJy2MWfb+y12ZgksCSpxC95xDzBOMdLTvFHNqc5xrSQGwlcrQwh3BdTg g7vVam+xtsGlRVynF2yddrsonoSLh0XQRVbAcjpl68gLqu2ccnscn0hB7e4EVEQnJX+a Nck7y4+sbdJQeJq7AvEpPI9mbWfKrj4iF+/yQXTkBnwi7YANEC6AchPfSrGq9eWG3fxP 1nVtDiPQBKN+qpiJRK1C8PvGUf9vQeSb59L0u5KbldqA1DmkCMqakOC6fifGN3BINmoZ BL1+c92X0uueufJCtkE4pFB+ezPm9Ql/v31h/EmG15XS7zXp3n0ZsVBQCpuf3CGN2F7D ZBrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1-v6si26658121pfc.132.2018.09.20.03.41.28; Thu, 20 Sep 2018 03:41:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732438AbeITQWc (ORCPT + 99 others); Thu, 20 Sep 2018 12:22:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40128 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbeITQWc (ORCPT ); Thu, 20 Sep 2018 12:22:32 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EA78CED4; Thu, 20 Sep 2018 10:39:40 +0000 (UTC) Date: Thu, 20 Sep 2018 12:39:38 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: Herbert Xu , Felipe Balbi , Johan Hovold , "Gustavo A. R. Silva" , linux-usb@vger.kernel.org, Ard Biesheuvel , Eric Biggers , linux-crypto , Linux Kernel Mailing List Subject: Re: [PATCH crypto-next 11/23] wusb: Remove VLA usage of skcipher Message-ID: <20180920103938.GA14523@kroah.com> References: <20180919021100.3380-1-keescook@chromium.org> <20180919021100.3380-12-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919021100.3380-12-keescook@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 07:10:48PM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > replaces struct crypto_skcipher and SKCIPHER_REQUEST_ON_STACK() usage > with struct crypto_sync_skcipher and SYNC_SKCIPHER_REQUEST_ON_STACK(), > which uses a fixed stack size. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Cc: Greg Kroah-Hartman > Cc: Felipe Balbi > Cc: Johan Hovold > Cc: "Gustavo A. R. Silva" > Cc: linux-usb@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Greg Kroah-Hartman