Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1917499imm; Thu, 20 Sep 2018 05:07:40 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYzsO83rfNgMZEdsrOEcC/GGtje9LG3XJl9AP9BoRAZNqt3mGxjTbgfiPBw21nvqa+pAzBY X-Received: by 2002:a63:5055:: with SMTP id q21-v6mr36846675pgl.397.1537445260823; Thu, 20 Sep 2018 05:07:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537445260; cv=none; d=google.com; s=arc-20160816; b=P2dgEVrsaUqCnunGQFEzwBTFVsTKGoYMYjf9j8PQEOK1jIj4ebO+bptAXbKbkdfpE7 27SJnl7AXSqNGal7OM2dVKfsTusp6B6RKY/3SY9enPfuxvGPxcGPFSHhG/Tr4oMCMHLC 41ujaWjopj2tNtfQywwGfDFzrRwR8dvyja4DPDO9j2vhKSPzRloTZzxktcaUQ93keZB1 NV0TMc01gdK/gmPxQSY4AOyDvh49FXwQK1jQDRrEfjG0K/EbM9/v+7Fs/36lF+OPo8G3 MyCoE08Wl8lIowL5Vo3vSFcv9lhhB+NGNOqipwH96udW1I6ALKrOFLLXSvXkLExUDjCB uPOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=LukHTUTyhOJGu46ej6MWfcfjF5nkINyRskPRucX2Fh0=; b=yniRZrq+L7ZYjcFre88Y24rH7xCPwIwCtKkvu7nFa9zD2AfLd/mSew7ILTYOc9H9+I BT1dv1tTtWifkqQ+ciGQAb9RJerlKY7B6kKDrCfjdaZXdhqyKBM3oCyIGYIC5a85nNsh NJQs+3zVMHaF1DsBmUKMGT1PS71HHMmIQB7xFpPn+urpBGx1AO5Z9Qb8nrH/Lc3Cr9nA c45FXFgku3UnYiJhhXFo+t+fjKHBlUl2XgM2m/uR3SRh+59cMjh3tweOtccwxFAexxfE Kn/qlAdy3o8v4CQTun2skmjZJAmuuUPK5fMM1AfrNy/0fS6IsQZ8OvRdjXUNr+wpdD8a Tgbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DMcRQjtY; dkim=pass header.i=@codeaurora.org header.s=default header.b=SYjoyUCB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j65-v6si4175634pge.589.2018.09.20.05.07.23; Thu, 20 Sep 2018 05:07:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DMcRQjtY; dkim=pass header.i=@codeaurora.org header.s=default header.b=SYjoyUCB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387590AbeITRuU (ORCPT + 99 others); Thu, 20 Sep 2018 13:50:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34894 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbeITRuU (ORCPT ); Thu, 20 Sep 2018 13:50:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A603560BE3; Thu, 20 Sep 2018 12:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537445229; bh=+Ezk40uLLR7rQvXJ/9k0hJBNe8cRfqyf5cFRjTolsx4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=DMcRQjtYx5ngIx/EONqsTc0aZnnoCh4V/oJgLfTwTJtBNJ110JQyYuzFZn3tLLohB twpDpiFfNWkK1ng5pnQHXtEuDhIF1VqZ+uv36A27ObB8HWkSyHptamkeX+y7LGVh0f rtWeZxLNWhKRxHlNCeewtaLdiR+8M4lTZDIzQ0J8= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 124B0601A8; Thu, 20 Sep 2018 12:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537445228; bh=+Ezk40uLLR7rQvXJ/9k0hJBNe8cRfqyf5cFRjTolsx4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=SYjoyUCB6iaoabIwSSsr4PqQShx2UMS2BKaXG5EJoqDq+y15xJcssDbs3DBpUmAU1 rVD00sc5zaOklOMS2dAdDBmjoXqaeSVdccD4XmXsTgzJRlmYzwAF4mWXHKwtzXEOfK QLBaEOWxsrRYajTnS77odpjoJ0lt4icokWhOVbAM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 124B0601A8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive From: Kalle Valo In-Reply-To: <1536761412-24932-1-git-send-email-zhongjiang@huawei.com> References: <1536761412-24932-1-git-send-email-zhongjiang@huawei.com> To: zhong jiang Cc: , , , , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180920120709.A603560BE3@smtp.codeaurora.org> Date: Thu, 20 Sep 2018 12:07:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong jiang wrote: > debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just > remove the condition check before debugfs_remove_recursive. > > Signed-off-by: zhong jiang It seems you already submitted an identical patch four days earlier: https://patchwork.kernel.org/patch/10593061/ Why the duplicate? Please ALWAYS add a changelog and increase the version number: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- https://patchwork.kernel.org/patch/10597627/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches