Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1918435imm; Thu, 20 Sep 2018 05:08:26 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbMsC9lNJRyXv9mOW97oMyPoAPz+eCHYw96fDmhedjNIVld/NSTSwt0wJrXAD3UH5+F7drb X-Received: by 2002:aa7:8087:: with SMTP id v7-v6mr40880118pff.38.1537445306544; Thu, 20 Sep 2018 05:08:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537445306; cv=none; d=google.com; s=arc-20160816; b=nUJtoVdUBW6YesscxKITXHTEPyOw0loyTbF2ExlzXpq4YaTh5NOechqoWET8qk1NNI plV06i8pxU9doxxHs4DOqoBg12+lc12gOn3HrvCwxhZmkAogRFmq8TeJm9EyvmIv7gdf Fa+I3mCqMOoCDZvyq7PYqF9/2kDkAfOx8g+4aielisG5arbznW+u/1u1B5r649qATS6J amnDXC6pPNOXpCBNxRI71Qrd5DGOVHessTXVuPItGGM6m1xpJXwnZkz6Pyln3IqEWdej dq3GloWzk5Gf6sZocf5Ui7qPEpcXQcBgOXlleuoL/mY0J36b9os0t73zFf+RlNo0g8OM szVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qGql0kUIra1xlvKqDGcc8fWXj+VBs45GyL+og79ptRc=; b=qq5ouZjgIcM5WdJlAZpWdV0ypmruEkADMG0qhHhZKZWqDaAGOQxlNyBtpRBwIYn0tK puUfRk/DpCw15rL9kRYK0f82e0zdfPfcPupu+345gmaJYZvlBPQYF97bo3GMY1XUow1p Jx5CcI/skj90nf9kmOQYfeCjlBDp19C7I1KouEIU/Tg7j/zSnfJ3JNibw+nVOgFGTuGB l2+n/jw0ucBJsZcmRpKQkmz/6r33hA0jwEHb+NEGuadGhwMnFElLI2RQawTDcyWfwyw9 zsr5OCt6rpWN+vbR3ap4EMenb0JSCV9Zh3NDhixNhovQt1o+Ktxf8njVhdOMttaEmNGZ Ragw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Gkx14ckn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si24045118plr.326.2018.09.20.05.08.10; Thu, 20 Sep 2018 05:08:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Gkx14ckn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387637AbeITRu1 (ORCPT + 99 others); Thu, 20 Sep 2018 13:50:27 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57928 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbeITRu0 (ORCPT ); Thu, 20 Sep 2018 13:50:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qGql0kUIra1xlvKqDGcc8fWXj+VBs45GyL+og79ptRc=; b=Gkx14cknKywhUbpRTpEMLyMT9 Qnl2H+bzzisaaTxZGjyJFEqnOn83LYrIPsXD/5SstcnExNnaT1hK6FcA/deTFq0Qm9VTU6T3VC7AB K4mbwhF7yspF8y/wSiSz8FkJts8XXHLyFjvdC19rW3XlEa8wpuNQxKa+qruTlsBawQl9Egrip47U6 qDV0uqlHirJCEwVsEkQC5YcPqhbSsT0dppQA3ZPKviHRW76OqFXwWgTr2fp75oIEr95mpdaekrMxO jxYc1WwoKlL0dF1MZroD9AfMPbagcDzB+jDZlPi1GoMyw7z2sJ/EmZFmpmP0v88PgBSn6lgUxb1v+ HCcsT5OTg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2xjk-000880-02; Thu, 20 Sep 2018 12:07:12 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D67392015F392; Thu, 20 Sep 2018 14:07:09 +0200 (CEST) Date: Thu, 20 Sep 2018 14:07:09 +0200 From: Peter Zijlstra To: Wei Wang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, pbonzini@redhat.com, ak@linux.intel.com, kan.liang@intel.com, mingo@redhat.com, rkrcmar@redhat.com, like.xu@intel.com, jannh@google.com, arei.gonglei@huawei.com Subject: Re: [PATCH v3 1/5] perf/x86: add a function to get the lbr stack Message-ID: <20180920120709.GQ24124@hirez.programming.kicks-ass.net> References: <1537437959-8751-1-git-send-email-wei.w.wang@intel.com> <1537437959-8751-2-git-send-email-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537437959-8751-2-git-send-email-wei.w.wang@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 06:05:55PM +0800, Wei Wang wrote: > The LBR stack MSRs are architecturally specific. The perf subsystem has > already assigned the abstracted MSR values based on the CPU architecture. > > This patch enables a caller outside the perf subsystem to get the LBR > stack info. This is useful for hyperviosrs to prepare the lbr feature > for the guest. > > Signed-off-by: Like Xu > Signed-off-by: Wei Wang Also, that SoB chain is broken. Since you're the author (per From), your SoB should be first, also since you're the one sending it, your SoB should also be last. Nowhere did Like Xu handle the patch so he shouldn't be having a SoB at all.