Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1944354imm; Thu, 20 Sep 2018 05:31:16 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbncdMNoYSothMNm33bM4UvajwTKOTY29lwJtbmrSj31qGn7ej9Nk0DDv+Pq46IElCXptD9 X-Received: by 2002:a63:ed07:: with SMTP id d7-v6mr37269517pgi.429.1537446676818; Thu, 20 Sep 2018 05:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537446676; cv=none; d=google.com; s=arc-20160816; b=NKZWFkUOrDZ1ZeA44Fc2pnyWskPgRb6ucIcfskpguFjL9nVH72McVfAPDIwb74YI8d bJHFcR+Ufp5PO9UfpZowI/LMbyBRhfQGAPpYVatHUAOzCmUIkivT2a7zUu5kxpMtev7k /kKfyN9M6nXNhcfFbXbkzU0kM7tFZfsO1lQM+9Q6P3083JQn6kozMKjcUsXCsJsy9vFT OkoLkMwg9VoU0yz7Gmn0u/gokennKdeBCXIxOU7w0kdqEOv+Nn6oaBi9GdRiM1acaVZw Kq1nks6fZwh1VxjAM0n01nD/E9l5QLZwmYKF6qT9JPRdGqByMrJ0pIwFOJ/4vCXeYsph LG9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=XA36EFkGNOtCS977prwSe4h5SEZaF0bXAmeK7etoWyc=; b=FRaRm+x8TMjHiopxjjqDMDfRGbfem7XKP6KVFA7udS/aZbeQktPB75Kxb/VxSHlxwV bdVGqlLU4YfBUiaB/Dx8fdbwsFPfsrXDUXMUXrSzpDEDBbaAoNMD5/8UakpgJk1QKY2I zzXsUezphTeMHhFzrrM5PXkFOAlvvULHqNhkmjyR+psp5ho30UlCpJm0jL+4ktv2/s9g mh43jLGiGMJWFJ6qjE4aKQirVm/dfIu4nsMR3sO1Wb9GRTiP3Tcb7bW67wrWk/s3E+bX GI1KOka1L4K+yHbNf+oUfNAeXD3jxYkw2B+makyGyqCgns97wW2oYJ/c/Xm3X0IpFUxW 6kIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=eC4U5AB+; dkim=pass header.i=@codeaurora.org header.s=default header.b=IyR09dfc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11-v6si23752837pgf.558.2018.09.20.05.30.59; Thu, 20 Sep 2018 05:31:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=eC4U5AB+; dkim=pass header.i=@codeaurora.org header.s=default header.b=IyR09dfc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387573AbeITSOF (ORCPT + 99 others); Thu, 20 Sep 2018 14:14:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42970 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730984AbeITSOE (ORCPT ); Thu, 20 Sep 2018 14:14:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5CF2B600ED; Thu, 20 Sep 2018 12:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537446648; bh=i5YYbXA8haf7G9GkqOIHzi8w/mP6tD0X8dj3GRqL9+o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eC4U5AB+b1KgyNr8Pth1TpTwISdg4BCbslVZyWQFcc/LQz6aFtX+qirj8jgH86QnD Ew+KTVYmlv3j+n5UXkv7xtV3o6ctXJrm6om+mdGRYe3w5POQV3LbqWQFxItCAaHrpT vabsX2+OshOVIMpyeubVrtxZg3vRzpPWd6gnFoIE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B7FA360B73; Thu, 20 Sep 2018 12:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537446647; bh=i5YYbXA8haf7G9GkqOIHzi8w/mP6tD0X8dj3GRqL9+o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IyR09dfc4T9Mnps/3ARGOmdtdw5ukFV3ak0K8/woEv5xTPh72MK4yElU/NZSPSNGc muvdKUmM0giIbDrd1FKlyFKhWGOknTZOh8LeWPgEYgCgk0GKrW1cFVvwQv+wrI3U76 Of7NpERltgw1cMYCQN58LofL5koJDwjOR4t0vtwk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B7FA360B73 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: zhong jiang Cc: , , , , , , , Subject: Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive References: <1536761412-24932-1-git-send-email-zhongjiang@huawei.com> <20180920120709.5FE6960BF7@smtp.codeaurora.org> <5BA391D4.20205@huawei.com> Date: Thu, 20 Sep 2018 15:30:42 +0300 In-Reply-To: <5BA391D4.20205@huawei.com> (zhong jiang's message of "Thu, 20 Sep 2018 20:25:56 +0800") Message-ID: <877ejg1hcd.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong jiang writes: > On 2018/9/20 20:07, Kalle Valo wrote: >> zhong jiang wrote: >> >>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just >>> remove the condition check before debugfs_remove_recursive. >>> >>> Signed-off-by: zhong jiang >> It seems you already submitted an identical patch four days earlier: >> >> https://patchwork.kernel.org/patch/10593061/ >> >> Why the duplicate? Please ALWAYS add a changelog and increase the version number: > > I am sorry for that. Maybe I send the patch earlier, but I remeber I > should forget to cc to > netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch. Even then please increase the version number and mention in the change log why you sent a new version. Otherwise you will make maintainers confused and wasting time with asking what has changed. -- Kalle Valo