Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1952712imm; Thu, 20 Sep 2018 05:38:56 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYwf40Ux/nLCpggtJKk/iQaBz3ZVHMAG9FiFl4SzTT+sRtQ2OQVn/rTP3836A+uE3kjyguG X-Received: by 2002:a62:ea05:: with SMTP id t5-v6mr41522097pfh.228.1537447136550; Thu, 20 Sep 2018 05:38:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537447136; cv=none; d=google.com; s=arc-20160816; b=fqIRQR0jrqt12hFnFxtAjxukA6h7jCWf+lzN4fcz5hdOQRvo/ZxwmS79yYr5509FmX gJB8SGWjTjePZ5x3ACEiFteU6/dlDrmQ5wHQUcsCMXfJmDef3YFvLNs6gzKM2GT6+blt uFtYUopQp0PPqeUauxYjDEuo1TcpNmbh1K4eEUm1CFlOazHEXEd8TLjv3RlCkBdufL05 q5stVqbVqZmC6ppHkVAxqKUcqg1zoe7cRHr4SJz7dZj4J+tGDA1le7YZ5qoelGgzcv0t 3b23xR1sG9saH7mS/lyDVBplOiAzNOY2ek4yoQy297Q6X7ppib4CLSIwaAUm1K59o/S/ LiJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vhmq1rFUrxnuoiBVLGhplCmMJ/ZdIhVEGv/nMhrDT8A=; b=m9PJpbjTLz3JqekgV63uL11c9gx16ku2aB/hu+Go+wDBIeH2Ibr1ihwD+PkjxrVpKV npHydUngGNru8ujy5k1p/cq57wfoGeLlmfHXiVz8BBISkK8Ek8CArBBGq1rsxMUpe1QL XUffuEIv/I7HBbpGhn0CfZ4wN/gfZBj9wrJ6uGYZuC8rX1sW3ESQeTUY2WQpZKoOthTx E84+MQ/+yhhgY8qjf6eWperrcQ0Do2Jk14GFJldxse7yyUCMWKwKShMObqD5wEnOSvLq CNfbQH6m9ZD7DIU8rv3wa5JRVotg7r4Pu3u2hk4EgqzIxQNAPSZpGKb4bBuCrOPTEMtv GdjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Yz4YLBJT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d35-v6si23095473pla.116.2018.09.20.05.38.38; Thu, 20 Sep 2018 05:38:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Yz4YLBJT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387721AbeITSVX (ORCPT + 99 others); Thu, 20 Sep 2018 14:21:23 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60838 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387424AbeITSVX (ORCPT ); Thu, 20 Sep 2018 14:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vhmq1rFUrxnuoiBVLGhplCmMJ/ZdIhVEGv/nMhrDT8A=; b=Yz4YLBJTfKUWwGHEo2JOtqRZF cuPDWRLL8yojCB7gOoLjM0Vl1NWkrt5ZMFsoxHgNO0zGXtlOKWhdQfgAeg/6GujtJyqUs47s4IY8x s54xlVZGw6gEkACOxKErLkLkVVmvChyjXv91hcp693Vh+GqmVl7fsz4LE5PkmreydetvMH/bvc2s4 CU5LMIkuSQ9i7p58hcsaHUDteXiW5VGXgCdPym2snYBv4jb234tS54HBZHXMzI9lVWjPhhqi9Ci7e A6TeMW6dtDubss1EBe+XdyczUO9WRWtEF+JvK+Ahvh9bHdgNJuNormO6auMx9NcEBqzJ1+86HuaRV kEgfOr85w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2yDS-0001iS-Iv; Thu, 20 Sep 2018 12:37:54 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 331E22015F391; Thu, 20 Sep 2018 14:37:53 +0200 (CEST) Date: Thu, 20 Sep 2018 14:37:53 +0200 From: Peter Zijlstra To: Wei Wang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, pbonzini@redhat.com, ak@linux.intel.com, kan.liang@intel.com, mingo@redhat.com, rkrcmar@redhat.com, like.xu@intel.com, jannh@google.com, arei.gonglei@huawei.com Subject: Re: [PATCH v3 5/5] KVM/x86/lbr: lazy save the guest lbr stack Message-ID: <20180920123753.GT24124@hirez.programming.kicks-ass.net> References: <1537437959-8751-1-git-send-email-wei.w.wang@intel.com> <1537437959-8751-6-git-send-email-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537437959-8751-6-git-send-email-wei.w.wang@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 06:05:59PM +0800, Wei Wang wrote: > /** > + * lbr_select_user_callstack - check if the user callstack mode is set > + * > + * @lbr_select: the lbr select msr > + * > + * Returns: true if the msr is configured to the user callstack mode. > + * Otherwise, false. > + * > + */ > +bool lbr_select_user_callstack(u64 lbr_select) > +{ > + return !!(lbr_select & LBR_USER_CALLSTACK); > +} > +EXPORT_SYMBOL_GPL(lbr_select_user_callstack); That function is pure and tiny, wth is that an exported symbol and not an inline?