Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1963836imm; Thu, 20 Sep 2018 05:49:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYYunD91/iP6kUoZY9E5bSlwu//Ibgzyfxw75BiHpUh7OVCjHeZUpxynmHJh4dJ7RF6nCd0 X-Received: by 2002:a65:620d:: with SMTP id d13-v6mr36839015pgv.273.1537447798628; Thu, 20 Sep 2018 05:49:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537447798; cv=none; d=google.com; s=arc-20160816; b=wBoQvu6ZawsvOtP5uvmfGejqoVCrxHe84zwzWiQyYfPNx1q4sfGrLTlWNmZ1uewUL0 gsXn4elkzbhcCdLO5ciMeXTxvcEaKnIXtgVi74788b/sUg+bXUiKBijX0T31AmrdhqEM keDOXt9O9woItGNk/0/mGVvcUtaHHbX5ig0sjRQs4w+ADRckVNQu+osdXqedTkq50pPd AHyWoSgOfxifBpAe+aZLJKKEVnScNwOS/megu5FJXZygkiAv9ngsH5jfh4hnIMZx2x4y JaV0MzSYFS92QFEGZktcpQkY30suu1ipKLSbapyTd70xQs/dBLDyYfUyOBfErXebRzTV aB2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=eRuOFTaOeN15WFbSt3ufkOF7qsh+K3ZLZK2a5kBnwjY=; b=WnS0cC4pYj72G9fMKYrEFjoQ3usoVplKhw+ls5oTw/5keayf/ZQKGz66RNWD35gTsG pD8ZEi8Ns+ytIZsPy1Gzq+dC6zRzP0XWFTWVqRhAXMyCouftmIZdkySfgXvUcBjp8zDb Iu2XE/hMHC/rgqW1LkBpJAr1Z+GpVFdJ8qL1+RblHK7JsvAV60VA3Qt0HdQh3ObwJSlc mQEYAz0hfmYaS/4oKCqUH3H5M7okmRhm4XmK+ouAuwWLJueFd0q1LvSIYStpjQro8FFp 0Ix7Rma68ATO1bwLHYawTaKpp2m+wokvtfK1D8xpLHvgKnlAlL3zANvlbyWQfu5JMB8H OsyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a21-v6si24113162pfo.68.2018.09.20.05.49.43; Thu, 20 Sep 2018 05:49:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388068AbeITSbh (ORCPT + 99 others); Thu, 20 Sep 2018 14:31:37 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:52232 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387899AbeITSbg (ORCPT ); Thu, 20 Sep 2018 14:31:36 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 05FEAC4D78353; Thu, 20 Sep 2018 20:48:12 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 20:48:07 +0800 From: YueHaibing To: , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , YueHaibing Subject: [PATCH net-next 05/22] net: sgi: fix return type of ndo_start_xmit function Date: Thu, 20 Sep 2018 20:32:49 +0800 Message-ID: <20180920123306.14772-6-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com> References: <20180920123306.14772-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 ++-- drivers/net/ethernet/sgi/meth.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 18d533f..3140999 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -99,7 +99,7 @@ struct ioc3_private { static int ioc3_ioctl(struct net_device *dev, struct ifreq *rq, int cmd); static void ioc3_set_multicast_list(struct net_device *dev); -static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev); static void ioc3_timeout(struct net_device *dev); static inline unsigned int ioc3_hash(const unsigned char *addr); static inline void ioc3_stop(struct ioc3_private *ip); @@ -1390,7 +1390,7 @@ static void ioc3_remove_one(struct pci_dev *pdev) .remove = ioc3_remove_one, }; -static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev) { unsigned long data; struct ioc3_private *ip = netdev_priv(dev); diff --git a/drivers/net/ethernet/sgi/meth.c b/drivers/net/ethernet/sgi/meth.c index ea55abd..703fbbe 100644 --- a/drivers/net/ethernet/sgi/meth.c +++ b/drivers/net/ethernet/sgi/meth.c @@ -697,7 +697,7 @@ static void meth_add_to_tx_ring(struct meth_private *priv, struct sk_buff *skb) /* * Transmit a packet (called by the kernel) */ -static int meth_tx(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t meth_tx(struct sk_buff *skb, struct net_device *dev) { struct meth_private *priv = netdev_priv(dev); unsigned long flags; -- 1.8.3.1