Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1964976imm; Thu, 20 Sep 2018 05:51:05 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbeZexFfdz20FpU5KkUavl5mFZVradmnzcIz9bCB4ASAo0b/JMPrr8a7YKm1pkah9LXFxqf X-Received: by 2002:a17:902:3041:: with SMTP id u59-v6mr38562881plb.99.1537447865580; Thu, 20 Sep 2018 05:51:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537447865; cv=none; d=google.com; s=arc-20160816; b=s5aaKkegFIT9EHy4yimPUVqSWWcufJXqvD4mMK6OKlIEHErL1dyEigypWQNalpPV4V +Dmc49HgP7zUMblwxz41ILbuBEjpIX4pupXopAZJGAqhDfnIq58P6eeY9/a//kTDaCGQ UqYkj8ibdMo5khR25IlyQbRpzY4Rz8jgbD/8GRMZq3+QWAXGy8E6Z2/JgWez9f34YCi9 brm6bC7ZLbvHe+X6RsqYul37LbEzgCPA3cHKcNGrYSDdkE8/aTkny2FuqOt4wbm66HvI eZF1ml4INxzTMiWDYip8xzKe4XTH0gq5bG2aA8y+JT0k6GHBrGn89GH7CnTJ0Fi1X5P5 7N0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=grt8A8AD4/9Sc2OYZLRownhGy8E5ymxDnI+UgRHHWkA=; b=vT78PIgeHNHL2PX97BWHPkZNVtdjucZUldtedU/chmfiulecQ1ZC2AwsXj7YOTTQS3 T0MAKcNh5wOEPYDne9BIPn1jcMmpQAE586wYK3z9plNXnAFBICW5hTqdu7FpyHwoL/g9 7I+FOBSN96bb/+rAnmoe8kx5rS6QzcQCKcZJEC0+x55lKmDHeV+SGitwWeFnSso31yOW 9/hm3wby3iP4eTy/MTfQCrWYWeMwQXj7Toxe6W2tecxBqJOG2bFuDobl2oz3kVLnkNik Zu9GMVDiibgGdsdcN5DT+N7SI7YRi8oiyVLqGBRuxXGiLHGUYlJcHXUXM2vN5DcBhZOx svbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p9-v6si23005721pff.30.2018.09.20.05.50.49; Thu, 20 Sep 2018 05:51:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388135AbeITSbs (ORCPT + 99 others); Thu, 20 Sep 2018 14:31:48 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58793 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388083AbeITSbq (ORCPT ); Thu, 20 Sep 2018 14:31:46 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A1BF0DC6CA00C; Thu, 20 Sep 2018 20:48:22 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 20:48:17 +0800 From: YueHaibing To: , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , YueHaibing Subject: [PATCH net-next 08/22] net: apple: fix return type of ndo_start_xmit function Date: Thu, 20 Sep 2018 20:32:52 +0800 Message-ID: <20180920123306.14772-9-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com> References: <20180920123306.14772-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/apple/bmac.c | 4 ++-- drivers/net/ethernet/apple/mace.c | 4 ++-- drivers/net/ethernet/apple/macmace.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index 024998d..6a8e256 100644 --- a/drivers/net/ethernet/apple/bmac.c +++ b/drivers/net/ethernet/apple/bmac.c @@ -154,7 +154,7 @@ struct bmac_data { static irqreturn_t bmac_rxdma_intr(int irq, void *dev_id); static void bmac_set_timeout(struct net_device *dev); static void bmac_tx_timeout(struct timer_list *t); -static int bmac_output(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t bmac_output(struct sk_buff *skb, struct net_device *dev); static void bmac_start(struct net_device *dev); #define DBDMA_SET(x) ( ((x) | (x) << 16) ) @@ -1456,7 +1456,7 @@ static int bmac_close(struct net_device *dev) spin_unlock_irqrestore(&bp->lock, flags); } -static int +static netdev_tx_t bmac_output(struct sk_buff *skb, struct net_device *dev) { struct bmac_data *bp = netdev_priv(dev); diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c index 0b5429d..68b9ee4 100644 --- a/drivers/net/ethernet/apple/mace.c +++ b/drivers/net/ethernet/apple/mace.c @@ -78,7 +78,7 @@ struct mace_data { static int mace_open(struct net_device *dev); static int mace_close(struct net_device *dev); -static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev); static void mace_set_multicast(struct net_device *dev); static void mace_reset(struct net_device *dev); static int mace_set_address(struct net_device *dev, void *addr); @@ -525,7 +525,7 @@ static inline void mace_set_timeout(struct net_device *dev) mp->timeout_active = 1; } -static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev) { struct mace_data *mp = netdev_priv(dev); volatile struct dbdma_regs __iomem *td = mp->tx_dma; diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c index 137cbb4..376f2c2 100644 --- a/drivers/net/ethernet/apple/macmace.c +++ b/drivers/net/ethernet/apple/macmace.c @@ -89,7 +89,7 @@ struct mace_frame { static int mace_open(struct net_device *dev); static int mace_close(struct net_device *dev); -static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev); static void mace_set_multicast(struct net_device *dev); static int mace_set_address(struct net_device *dev, void *addr); static void mace_reset(struct net_device *dev); @@ -444,7 +444,7 @@ static int mace_close(struct net_device *dev) * Transmit a frame */ -static int mace_xmit_start(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t mace_xmit_start(struct sk_buff *skb, struct net_device *dev) { struct mace_data *mp = netdev_priv(dev); unsigned long flags; -- 1.8.3.1