Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1965332imm; Thu, 20 Sep 2018 05:51:27 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYVHsKivGSqUBKXVWQgFhqI1RRAP8+WvTQeBppvUglvYH8FglKyGmbybuZsGbawNtEm1okD X-Received: by 2002:a17:902:8345:: with SMTP id z5-v6mr38793937pln.147.1537447887072; Thu, 20 Sep 2018 05:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537447887; cv=none; d=google.com; s=arc-20160816; b=WXhvD28HJYDfa6MaWhWTV9zjjv53aljh3E/hJ9ZKUwqNACzgZav31GY5BY5Ke8nf7J TNdrDOwvIb6Kam2txQLEm5zIThPcHebieA0FIof0dqQ5We9atZcbFnQygpwiCCHUGh2T tRjhVjWO423BWuSNZJsk3seLlp3+Gr1Hftq9AuDI0OZvPZRRFey9Qz6EIxLefYR87neM co5Pb4wRfVfg5WSp81vZeW/RfyngV82VsqDS0wDPjjOGkX0x8VnWmd9KSYRTq0whC+Ic 8YVKOP5CPuFccPIT3y5jt419ffuiFfKOBYyvS85x34i9DTZlW/demr3vwqEpce9fO3Op Vfig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=oGCbmXHc385q8Hn02U4p0g9VMsa7qzcKsbbrmkaxCQs=; b=Gvd8c/mImF5o+eOLSh2qFnL1j2UmOhsvCy4BMykxfTfpdJ/4lHEui2+wms9NaZ3OKL XyQQwy9cAjtopGDQUg+PpRcgkgOdmyx3R1IUGk2K4OV3S3iwTy0/yQhzi0giHHPRXlkO 03H4UvWdqJi82AkJqIJC4s83Op/zHadxZCaBFQDyF7Vv3KfaQ3Rrj3nm8y3XpaqOHc8t eHIv+RbLHMdLpowCo53bFFyNgEhdyiwuI4i7ZyzDAGh0PcnNzWXRjv1dGdXTjwJnlQow JtQBBWWkIAn9HgN4dtShYdqx4RT6aMqhrIACZkPs1Sk/k5b8uVJJmOu6iH6NfrwfQ8VI Exkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si22150940pgp.256.2018.09.20.05.51.11; Thu, 20 Sep 2018 05:51:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388369AbeITScU (ORCPT + 99 others); Thu, 20 Sep 2018 14:32:20 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12659 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387946AbeITScT (ORCPT ); Thu, 20 Sep 2018 14:32:19 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id B52988052A598; Thu, 20 Sep 2018 20:48:51 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 20:48:48 +0800 From: YueHaibing To: , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , YueHaibing Subject: [PATCH net-next 18/22] can: xilinx: fix return type of ndo_start_xmit function Date: Thu, 20 Sep 2018 20:33:02 +0800 Message-ID: <20180920123306.14772-19-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com> References: <20180920123306.14772-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing --- drivers/net/can/xilinx_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 045f084..6de5004 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -612,7 +612,7 @@ static int xcan_start_xmit_mailbox(struct sk_buff *skb, struct net_device *ndev) * * Return: NETDEV_TX_OK on success and NETDEV_TX_BUSY when the tx queue is full */ -static int xcan_start_xmit(struct sk_buff *skb, struct net_device *ndev) +static netdev_tx_t xcan_start_xmit(struct sk_buff *skb, struct net_device *ndev) { struct xcan_priv *priv = netdev_priv(ndev); int ret; -- 1.8.3.1