Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1965803imm; Thu, 20 Sep 2018 05:51:51 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZpvxGt1Si9JFGpWBCfyysL1v43/EJ/ZYR4lYiyjX5cW3bcG8X3CAW+lW6atqnlp43FTbSH X-Received: by 2002:a63:81c8:: with SMTP id t191-v6mr2851321pgd.399.1537447911560; Thu, 20 Sep 2018 05:51:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537447911; cv=none; d=google.com; s=arc-20160816; b=gG4i/yeGgaRZVX/r9YoeF4OBlHZqqKAZnnp9AQOZtrMpJQoYWvU9IOZKejDrgT0zoo PYCyoqPpIKn/+dr6F4DfsbfJttvVhF/UN9pECKCAHx3618sBw4TMi9tLuX21003OsgbY cnQEZOw8NJHg4hCk6e96kHbiVX/5dv533KtgJcSLfud8PAHb4JRw2WeiWwk7kNi1K3hy Bdork8Fxb6+BX7OVJMRLZ0KE2GNchi/U1SMfwek5/m2fU85aI+62vkXeYa/dIVZkGMAJ FqFhS78vi+BBjP2GKtCQBUiej3H7E0ehxFFa4fFapRKcmkwL3n/HRhx+N/FRIc5N4CvQ EOYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=ug6SysUtC115vK/DyKBLuXWI3qwW9Xx0T+7P4sD6N94=; b=iPHdnpalnnQNy+Rt5Jo4s0HL+/zP6EfQZduaaFcGQXNMjIuQ4eds+A9Ps40lC01vla KH3aN6DEKkM+GR55Bjq8ERi8fVVXxXhBuFOduh//346mVrvfSo82hSSopbFArytxWrXu Khhf3GTDeXJGdqyB4n4nCj+fPyD09kYtsa8Qom6zh2BaqWmtXJP+wxt7AD9hLyCWGKUt 6adpBr2mGFYEvZgXkAUsPMdjQyYM9lduQptO+dhgVCXvK+OMZzYaDpI5JGim2MG3fr/G /86IuK2dBjtqVZ3L/O8QF9ckARqNd9C4ltKIlXALmNY1MUN5PMIYq+Pni+Qo1BKq5RcE aIoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o69-v6si26479198pfo.342.2018.09.20.05.51.35; Thu, 20 Sep 2018 05:51:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387920AbeITSeu (ORCPT + 99 others); Thu, 20 Sep 2018 14:34:50 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:12641 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387869AbeITSbg (ORCPT ); Thu, 20 Sep 2018 14:31:36 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 29DCEDC9A152; Thu, 20 Sep 2018 20:48:12 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 20:48:05 +0800 From: YueHaibing To: , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , YueHaibing Subject: [PATCH net-next 04/22] net: cirrus: fix return type of ndo_start_xmit function Date: Thu, 20 Sep 2018 20:32:48 +0800 Message-ID: <20180920123306.14772-5-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com> References: <20180920123306.14772-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/cirrus/ep93xx_eth.c | 2 +- drivers/net/ethernet/cirrus/mac89x0.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c index e2a7029..13dfdfc 100644 --- a/drivers/net/ethernet/cirrus/ep93xx_eth.c +++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c @@ -332,7 +332,7 @@ static int ep93xx_poll(struct napi_struct *napi, int budget) return rx; } -static int ep93xx_xmit(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t ep93xx_xmit(struct sk_buff *skb, struct net_device *dev) { struct ep93xx_priv *ep = netdev_priv(dev); struct ep93xx_tdesc *txd; diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 3f8fe8f..6324e80 100644 --- a/drivers/net/ethernet/cirrus/mac89x0.c +++ b/drivers/net/ethernet/cirrus/mac89x0.c @@ -113,7 +113,7 @@ struct net_local { /* Index to functions, as function prototypes. */ static int net_open(struct net_device *dev); -static int net_send_packet(struct sk_buff *skb, struct net_device *dev); +static netdev_tx_t net_send_packet(struct sk_buff *skb, struct net_device *dev); static irqreturn_t net_interrupt(int irq, void *dev_id); static void set_multicast_list(struct net_device *dev); static void net_rx(struct net_device *dev); @@ -324,7 +324,7 @@ static int mac89x0_device_probe(struct platform_device *pdev) return 0; } -static int +static netdev_tx_t net_send_packet(struct sk_buff *skb, struct net_device *dev) { struct net_local *lp = netdev_priv(dev); -- 1.8.3.1