Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1988728imm; Thu, 20 Sep 2018 06:11:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYeEWF97CyWckc+5VWit6/pAPKPyvJqjrruB4SS4Wdk/DC5LLYSquxHP7LdcjIM7uFONNgQ X-Received: by 2002:a17:902:9a47:: with SMTP id x7-v6mr39681460plv.37.1537449066886; Thu, 20 Sep 2018 06:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537449066; cv=none; d=google.com; s=arc-20160816; b=o5ubeI6kAiMF6RSzf6Wj9ZFmm98w81e0x0Oj4yJPS6kn/GunOlf4FAYKNETn92BrDf JUCQA0ymmfxrmIbNY8JjdK3u4ULkgIPBS97rQEJ/LdMJngUIp8m2uh7raGEMQjNZVxUF 52SX61eJcdc0gJ4a6+M/T9PYqEqa6S0+4rQJtHqItrml5JHa7N22VeAqaiO/oSDu2rOC dZA6DPKSRSFZBwzdbDuPbVU3APLwQNoGGL15sdZvhcG+r3AsbP9OzW2RU1Iw47TzpJwL 4jXjVv8iF6UaKC+k+g34gKkWRCsMN9FWz3vRZ8H/Ntiqr+ZPFJL4qDyi2LhJLYGxfKW/ lotg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=5hq6pyLOLkfm0sPfhvUBI8dv0KyrT3vKhs+SuqyJ9r0=; b=g2zk5QCC2KFNNHoizw/uOLw8rnUxmD7FQ/WZPhNddv9ZDOMnbXRHjGz90aMQFfVlNJ Tu7ZwY9XtGfBdoNKHdqI8Cryia9dPkOdN5KhVDe5J8zX8WCgEg5i+YMffeSQG/PtZpqy P12KAsdWW0TLKLIOSRf9buwxiHy+xjojaHhIh1KoVIom2tUIg0uLQQzVvGQGtzyKLugF oW1R2VjJ33IWpTWNNLyXkjICZxTNTW7jd7bm6tz8mlfKYOUq1HImgsl93JShQv11ZacR +CkA1p/zlUzeey0Ih5vT2zbIlxhGHmlpfKCIVX20qeiFI7LKrSDi18p2Lzbfmj2SFFJY 48Nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z20-v6si25075451pgk.17.2018.09.20.06.10.48; Thu, 20 Sep 2018 06:11:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387801AbeITSyJ (ORCPT + 99 others); Thu, 20 Sep 2018 14:54:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:36360 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387418AbeITSyJ (ORCPT ); Thu, 20 Sep 2018 14:54:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A81F6B091; Thu, 20 Sep 2018 13:10:40 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 11241DAE2D; Thu, 20 Sep 2018 15:10:39 +0200 (CEST) Date: Thu, 20 Sep 2018 15:10:39 +0200 From: David Sterba To: Rasmus Villemoes Cc: Jason Baron , Andrew Morton , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 14/22] btrfs: implement btrfs_debug* in terms of helper macro Message-ID: <20180920131039.GY5847@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Rasmus Villemoes , Jason Baron , Andrew Morton , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20180919220444.23190-1-linux@rasmusvillemoes.dk> <20180919220444.23190-15-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919220444.23190-15-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 12:04:36AM +0200, Rasmus Villemoes wrote: > First, the btrfs_debug macros open-code (one possible definition of) > DYNAMIC_DEBUG_BRANCH, so they don't benefit from the HAVE_JUMP_LABEL > optimization. > > Second, changes on x86-64 later in this series require that all struct > _ddebug descriptors in a translation unit use distinct identifiers. > > Using the new _dynamic_func_call_no_desc helper macro from > dynamic_debug.h takes care of both of these. > > Cc: linux-btrfs@vger.kernel.org > Signed-off-by: Rasmus Villemoes Acked-by: David Sterba Per the cover letter, I assume you'll take it through your git tree.