Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Artur Petrosyan <Arthur.Petrosyan@synopsys.com>
To:     John Stultz <john.stultz@linaro.org>,
        Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
CC:     lkml <linux-kernel@vger.kernel.org>,
        John Youn <John.Youn@synopsys.com>,
        Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down
 feature
Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down
 feature
Thread-Index: AQHT7ws4O+8B/axYs0CeMD+6l4m0jQ==
Date:   Thu, 20 Sep 2018 14:17:42 +0000
Message-ID: <3AD91E696667BF4BA728303C178E8A63532AAF6D@am04wembxb.internal.synopsys.com>
References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org>
 <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com>
 <CALAqxLVZXs97sryfPaGY5Gq50-FZROgaBADNXXadcyiNhP3EPQ@mail.gmail.com>
 <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com>
 <CALAqxLU3sWrgPjFqZ2vK0m8wVThtE1hDsbNq9zRC7ritzyNHmQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,=0A=
=0A=
On 5/23/2018 01:57, John Stultz wrote:=0A=
> On Tue, May 22, 2018 at 7:24 AM, Minas Harutyunyan=0A=
> <Minas.Harutyunyan@synopsys.com> wrote:=0A=
>> Hi John,=0A=
>>=0A=
>> Please provide log with debug enabled configuration.=0A=
> =0A=
> Ok. Attached.=0A=
> For dmesg-broken.log:  OTG removed at 77, and OTG plugged in at 82=0A=
> For dmesg-with-patch.log: OTG removed at 31, OTG plugged in at 38.=0A=
> =0A=
> Note with the dmesg-with-patch (using my patch), things seem to be=0A=
> working ok. Though in the example above it may look odd, as usually it=0A=
> switches to to host mode, then when it detects a low speed device (a=0A=
> mouse which I had plugged in), it will reset to switch to low-speed,=0A=
> but I didn't wait long enough for the reset to complete and the mouse=0A=
> to be detected before re-plugging in the OTG port.=0A=
> =0A=
>> On 5/21/2018 11:41 PM, John Stultz wrote:=0A=
>>> On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan=0A=
>>> <Minas.Harutyunyan@synopsys.com> wrote:=0A=
>>>> Hi John,=0A=
>>>>=0A=
>>>> On 5/19/2018 4:49 AM, John Stultz wrote:=0A=
>>>>> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")=0A=
>>>>> caused the HiKey board to not correctly handle switching between=0A=
>>>>> usb-gadget and usb-host mode.=0A=
>>>>>=0A=
>>>>> Unplugging the OTG port would result in:=0A=
>> OTG port you mean MicroAB, Correct?=0A=
> =0A=
> Correct.=0A=
> =0A=
>> dwc2 driver loaded when some device connected to OTG port?=0A=
> =0A=
> Yes, I normally boot with the board plugged in to OTG as a=0A=
> peripheral/gadget for adb.=0A=
> =0A=
>> And below message printed after disconnect the device from OTG port?=0A=
>>=0A=
>>>>> [   42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no hos=
t registers to restore=0A=
>>>>> [   42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed =
to restore host registers=0A=
> =0A=
> Correct.=0A=
> =0A=
>>>>> And the USB-host ports would not function.=0A=
>> USB-host ports - you mean 2 USB A-ports, connected to TS3USB221 HUB?=0A=
> =0A=
> Correct.=0A=
> =0A=
>> Switching ports between OTG and Host ports via TS3USB221 Switch=0A=
>> performing automatically or by some SW tool?=0A=
> =0A=
> Its done automatically, when the OTG cable is detected it the host=0A=
> ports are disabled and when the OTG port is empty the host ports are=0A=
> enabled.=0A=
> =0A=
> Let me know if you need anything else!=0A=
> =0A=
> thanks=0A=
> -john=0A=
> =0A=
=0A=
Please apply the patch set with this cover letter "[PATCH 0/3] usb: =0A=
dwc2: Fix hibernation for switching between host and device modes."=0A=
=0A=
Enable the power down on his devices. Let me know if you still see any =0A=
issue. If there is no issue, please provide Tested-by tag.=0A=
=0A=
=0A=
Regards,=0A=
Artur=0A=