Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in
 jfs_evict_inode()
To:     Chao Yu <chao@kernel.org>, Chao Yu <yuchao0@huawei.com>,
        "open list:JFS FILESYSTEM" <jfs-discussion@lists.sourceforge.net>,
        open list <linux-kernel@vger.kernel.org>
References: <20180917071221.13187-1-yuchao0@huawei.com>
 <be3a41fb-9a83-19a8-b3da-ca91500471fc@kernel.org>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
Openpgp: preference=signencrypt
Message-ID: <d6360818-2808-d5a6-119d-97cb506b7d15@oracle.com>
Date:   Thu, 20 Sep 2018 09:24:53 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <be3a41fb-9a83-19a8-b3da-ca91500471fc@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/20/18 9:18 AM, Chao Yu wrote:
> Ping,
> 
> Any comments?

Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks,
Dave

> 
> On 2018/9/17 15:12, Chao Yu wrote:
>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>> remove one of them for cleanup.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>>  fs/jfs/inode.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>> index 054cc761b426..805ae9e8944a 100644
>> --- a/fs/jfs/inode.c
>> +++ b/fs/jfs/inode.c
>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>>  			/*
>>  			 * Free the inode from the quota allocation.
>>  			 */
>> -			dquot_initialize(inode);
>>  			dquot_free_inode(inode);
>>  		}
>>  	} else {
>>