Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2075930imm; Thu, 20 Sep 2018 07:26:15 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbJfa7oIS0B8EFkGyVNPgKAF80gpJImSIFfP6ppCtz5RYQycSbaAIjwPjgmeqNZodkOPQid X-Received: by 2002:a63:3f0f:: with SMTP id m15-v6mr9300677pga.51.1537453575529; Thu, 20 Sep 2018 07:26:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537453575; cv=none; d=google.com; s=arc-20160816; b=GDKepEtKQujBvNDr6yYT6W0nAYVJXAokU+Ew4zHAxpODhZcGT1S9nvmoDzCRJG0J6e XyPXF/Ca6z7VeWqMjKZ6caPIGk31X1AWttuEVe4Uy/pbSwqhAx7/41pGellLSvOvORi+ 415gHPtzI7VOzp0MuM76gI1lI0tc2UEq7ozaT+EuTyoNUco90PKldA8mo3SW+xhj5d2n 3gd+x5hk6nAO3Yv6hdxAnx4vDJvu3SWoPk/9vONqktsva8oqkhFHDGy/moj95hHO6wly eK4ZzNdByE5j41zBjkPj8/kmdprKnLMMJ6rWjbD92NEKVSGBhIXZyHAY+sZ00HuB0Szb KYog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:in-reply-to:subject:cc:to:from:date; bh=RVdC73Zvun68Hib+8AXFf7cPbWqbWcqDVz5AkF1nXkM=; b=pVEsNEOPB2dF52U3K9xDUjWauFXxhNidCmlepg0tJ9xIrVmUKhOkSMbwH4sjP9qq3w D9fPTJ2yM3msczYCb1ym5Bg9MlzQg+60UgtWnfyd/I5mc+KrDt2bW0F/CcA2MxB2DDHW KcgrgRRf39mXbhTvDMpaM92CrVzRUKdkedJbbj3MOUkXYpt+B3/DzHXYNq2a8ZCqzBZd o5pz63tsOpemkmIBNu/VFdGkMuxkrdaDjR6a3iA4V2qjW+dHRQy5I96ijXzosJdHgEyl xcfs8E5pyPP8CYZ7DODsLphMhbp+9FRNegap4d8jbYPVm/Tzs0GODaDRgNHNqA5P2ZAG 1j7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11-v6si23614948plk.490.2018.09.20.07.25.59; Thu, 20 Sep 2018 07:26:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387672AbeITUIH (ORCPT + 99 others); Thu, 20 Sep 2018 16:08:07 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:33308 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1731416AbeITUIH (ORCPT ); Thu, 20 Sep 2018 16:08:07 -0400 Received: (qmail 3247 invoked by uid 2102); 20 Sep 2018 10:24:23 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 20 Sep 2018 10:24:23 -0400 Date: Thu, 20 Sep 2018 10:24:23 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Corentin Labbe cc: gregkh@linuxfoundation.org, , , Subject: Re: [PATCH v2] usb: host: Replace empty define with do while In-Reply-To: <1537386533-22916-1-git-send-email-clabbe@baylibre.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Sep 2018, Corentin Labbe wrote: > It's dangerous to use empty code define. > Furthermore it lead to the following warning: > "suggest braces around empty body in an « else » statement" > > So let's replace emptyness by "do {} while(0)" > > Furthermore, as suggested by Joe Perches, rename the macro to INCR. > > Signed-off-by: Corentin Labbe > --- > Changes since v1: > - rename the macro from COUNT to INCR For the EHCI portions: Acked-by: Alan Stern