Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2082613imm; Thu, 20 Sep 2018 07:32:03 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZrxLCHMCtzXppG3P72XhJxCeRfRLqc1Zh6zUsNiw26mbOrDl2IhBSbT78zfnkbvylcV2qW X-Received: by 2002:a17:902:722:: with SMTP id 31-v6mr39598628pli.207.1537453923688; Thu, 20 Sep 2018 07:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537453923; cv=none; d=google.com; s=arc-20160816; b=CjfjXFxInx+DTyRMCLs48wGQT8xR4tKoXOXsAWorS5u7iuFNXqHzUBZ0AXbNXLdk45 kPZI+odEE4HLN2aPkwtd/+ZmeLAGOyIObOmGSwTL6+L13DJhv2OOJoQ3pMf+HpB6TFzE V0EGmACYZkOmMDFSDyNXH1jPQz2fuFzgfRYle/TSH/CXJZycmj55pvLzF/XieAxcHP8l MXKNqWAHOJh868G4cz4uONOgREcn2ysRI6ADAyRLaiUSYDnDN35GXGmbboc7n8gRzN5v gKFKWqCSBN5ALq9Vjklk0aCj5WnWUqyQDCQZicY2Wfyr+zrGIMyMkyWeSfnF+DmKn866 sgdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=1UjvM4YlWnuiosqplMdhl47HsuMMTMsOAzH5GYFz8hk=; b=WGW3HPFJ+XBGqZZQCVce82U1QcYQ1tyWXPJz+ilu5OTwd6L7XHmBTMf5kkgfA2RDRU +wJTEjGqo+LTxkSzdFfmncI3dy8sQupF1YmyvcO7VuOlOWhWvecJr76CA2BMLNPOsgcb 4PAz9BTuJoJQVdUQUjgXUvejxh8mM/u4FgyEmIt7B621ekcJsWOO+crR4MbNX9bNh4JC cuDkFxTT3XmKwSI4sDHmg9AXGvsEcySMLXz6RUt+bxRqvcf3shgpbjae5PEEPg76P/+W w9/gBXAR/2lT+PPJEe95O3FwpTLX4bSuZ+7ia8EK3cCWkD1b6Lcs1aXMKPdQ2giNW8/P ePeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si23651486pgh.359.2018.09.20.07.31.46; Thu, 20 Sep 2018 07:32:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732981AbeITUPN (ORCPT + 99 others); Thu, 20 Sep 2018 16:15:13 -0400 Received: from 72-48-214-68.dyn.grandenetworks.net ([72.48.214.68]:58754 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731223AbeITUPN (ORCPT ); Thu, 20 Sep 2018 16:15:13 -0400 X-Greylist: delayed 305 seconds by postgrey-1.27 at vger.kernel.org; Thu, 20 Sep 2018 16:15:12 EDT Received: from [10.10.0.239] (cody.ogc.int [10.10.0.239]) by smtp.opengridcomputing.com (Postfix) with ESMTPSA id B23842260B; Thu, 20 Sep 2018 09:26:23 -0500 (CDT) Subject: Re: [PATCH] RDMA/cxgb4: remove redundant null pointer check before kfree_skb To: zhong jiang , swise@chelsio.com, dledford@redhat.com, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <1537437162-42846-1-git-send-email-zhongjiang@huawei.com> From: Steve Wise Message-ID: Date: Thu, 20 Sep 2018 09:26:28 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537437162-42846-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/2018 4:52 AM, zhong jiang wrote: > kfree_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree_skb. > > Signed-off-by: zhong jiang > --- > drivers/infiniband/hw/cxgb4/cm.c | 3 +-- > drivers/infiniband/hw/cxgb4/qp.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) Acked-by: Steve Wise