Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in
 jfs_evict_inode()
To:     Dave Kleikamp <dave.kleikamp@oracle.com>,
        Chao Yu <yuchao0@huawei.com>,
        "open list:JFS FILESYSTEM" <jfs-discussion@lists.sourceforge.net>,
        open list <linux-kernel@vger.kernel.org>
References: <20180917071221.13187-1-yuchao0@huawei.com>
 <be3a41fb-9a83-19a8-b3da-ca91500471fc@kernel.org>
 <d6360818-2808-d5a6-119d-97cb506b7d15@oracle.com>
From:   Chao Yu <chao@kernel.org>
Message-ID: <aa505360-1d45-58c1-6ecf-3897799d6a04@kernel.org>
Date:   Thu, 20 Sep 2018 22:32:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <d6360818-2808-d5a6-119d-97cb506b7d15@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/9/20 22:24, Dave Kleikamp wrote:
> On 9/20/18 9:18 AM, Chao Yu wrote:
>> Ping,
>>
>> Any comments?
> 
> Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks for your review. ;)

Thanks,

> 
> Thanks,
> Dave
> 
>>
>> On 2018/9/17 15:12, Chao Yu wrote:
>>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>>> remove one of them for cleanup.
>>>
>>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>>> ---
>>>  fs/jfs/inode.c | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>>> index 054cc761b426..805ae9e8944a 100644
>>> --- a/fs/jfs/inode.c
>>> +++ b/fs/jfs/inode.c
>>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>>>  			/*
>>>  			 * Free the inode from the quota allocation.
>>>  			 */
>>> -			dquot_initialize(inode);
>>>  			dquot_free_inode(inode);
>>>  		}
>>>  	} else {
>>>