Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2174629imm; Thu, 20 Sep 2018 08:52:18 -0700 (PDT) X-Google-Smtp-Source: ANB0VdahOR6QKXKAuXmv8MrC0C089PX7KMt7lbG31bmdCFC3ZqTMrB7LOQzGrV6b2yxSfojuocbn X-Received: by 2002:a62:ee06:: with SMTP id e6-v6mr42250580pfi.2.1537458738147; Thu, 20 Sep 2018 08:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537458738; cv=none; d=google.com; s=arc-20160816; b=JfDvjlw7vJQjEQS3l5GphrOLYcQt6uFelpaZOuUsRQsNSvhB6hVSTAidUelZKCdrZ7 W9U7itTO5AeLsHfcIUM48pICcxs8+oRIUQ4hznRRVsAJGaq8BE3ri1T4YiICYjIA+9ko ZLVSO/oZYbBsQLyzA2d/zTVwTJhrQCRALK1ytBOzagXT/kQ+c+XXoBZMAl5cB8+oO14t CPsb9fwEoRHr1D4yXZqa/LarSNCVYohqghlAcroVsSR6ZYkxuEh3rR7XofBFvMOxZuei 32Q5UHFWSlTr3ON+z9iRqJVEZR1R8+E0aSkrEP4k0BLxQvC59pNp4L/7XwqugFsFqn2f KPow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Ee+sMq5gWJKK0q5/s6Qm8LUsCiyeuBF+2Nc32Gzo210=; b=cCYb/rhsiN27xIVm9Z+8gxCMD7DyhgU6MCY1QcZtjf5AjxfvYCStHFu9TLc8okD9Q3 HV8qUQ3Ksv2FAuMU7viPHkm7MGKCW8B6/BbH+Kotj+xDdK0KFV4DUWC6X5O2KXxzvCrU PxLJO4EZofhR6ViCUcNZ0ErmIkJ3mZOWcSPq6ezQNMG3hwQcmFGOGCr8z4qLx/okH2PG z+DH3+kD8yIhN9tpoWsdd+O+yNTVRQ5VrQD+7ci7duLd8njjjDj5PhsNbOWSyEhqHF3F p8n3ZWYYOyb450jaOwjUl1rPGjKhWsGTKuh6o4RLoH7H6nFvqEuXPw4ysnmJlVpyX3ea KtOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f12-v6si24262718pgg.653.2018.09.20.08.52.00; Thu, 20 Sep 2018 08:52:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387839AbeITVfH (ORCPT + 99 others); Thu, 20 Sep 2018 17:35:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43768 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387795AbeITVfG (ORCPT ); Thu, 20 Sep 2018 17:35:06 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 485C7146FE6EB; Thu, 20 Sep 2018 08:50:58 -0700 (PDT) Date: Thu, 20 Sep 2018 08:50:55 -0700 (PDT) Message-Id: <20180920.085055.1188796939437872993.davem@davemloft.net> To: yuehaibing@huawei.com Cc: dmitry.tarnyagin@lockless.no, wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, hsweeten@visionengravers.com, madalin.bucur@nxp.com, pantelis.antoniou@gmail.com, claudiu.manoil@nxp.com, leoyang.li@nxp.com, linux@armlinux.org.uk, sammy@sammy.net, ralf@linux-mips.org, nico@fluxnic.net, steve.glendinning@shawell.net, f.fainelli@gmail.com, grygorii.strashko@ti.com, w-kwok2@ti.com, m-karicheri2@ti.com, t.sailer@alumni.ethz.ch, jreuter@yaina.de, kys@microsoft.com, haiyangz@microsoft.com, wei.liu2@citrix.com, paul.durrant@citrix.com, arvid.brodin@alten.se, pshelar@ovn.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org, linux-omap@vger.kernel.org, linux-hams@vger.kernel.org, devel@linuxdriverproject.org, linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org, dev@openvswitch.org Subject: Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function From: David Miller In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com> References: <20180920123306.14772-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 20 Sep 2018 08:50:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Thu, 20 Sep 2018 20:32:44 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. I would advise you not to send so many of these changes as a group. If one of the patches needs feedback addressed, which is already the case, you will have to resubmit the entire series all over again with the fixes.