Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2212551imm; Thu, 20 Sep 2018 09:24:49 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY6PiHK+/gyA9lAxTDCA1PcrrTTfH8opBGHlHY1uulq2kUnMFLJadvOTjJs5yyF17+e6exj X-Received: by 2002:a63:1021:: with SMTP id f33-v6mr37254325pgl.72.1537460689625; Thu, 20 Sep 2018 09:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537460689; cv=none; d=google.com; s=arc-20160816; b=qSaQse3OV9xlyRuiUZLOwiWGSnxn5fgiBj+1ODq7/Tp5Nnp8vX0wp6lbjQuBS1B77j oa4BZBZcaUWudvRLDYcG4ks5OIYvmcrH/NYTeZq/T4TWIOt0lQSHHh5V8upxfSGBtFZk 0avW5sinziDSxdWRiNqXov4sgwRyPoa6fAukWWaeE/MnNPVyr5kCS8rPS7HKWqlzZBKc a8UkA7nHrkBEtV2Bog3zcdpJspEIKXdGqZIvkxWA4l1yiwtb2FbHVPpKHnT0K+csS8Yi fqsEy0pgk/GYDOWLV4IdpHCCpN1m/LkevqB8U9HPtDae0OuKofCF+kTm5bWvdZCmkB0c xwBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JQNntefTzdvjvdUBlbPGnjareuQqZtBuDhRhx1D4GPY=; b=UuoOjb05Kh0rgfjxd65oc9PhQDKIU9LHZpHX/lE9BcF89Hbfc0XQRzOPcthgKqCCvw 9Q06Dx5m45MtHCP5xeQJT7dMxst2mVe9gQo6CqoVgIP5uqhfkK0zYglTJoMpm5+XjxxV 0a0EgnlUWng6cjFhcU9cPgoVLo8Zh4Z1SQUNNnQ5hBrByqXlY/2rUwyy7l9syeQ57U7e OMxjWcGHPhbsi+MA3nvf2ZMLMYtBQS8NYGoSxZZ+G/g4JwOh3ohVgoJcAO9NVokMuukK /yuc3AA1/0IQkI9tsw3i2v1YwoU8EjjxkyHmfE50XZOU3f28rsK5omzxz0knfV68uknz ZH+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h17-v6si24528929pgj.214.2018.09.20.09.24.32; Thu, 20 Sep 2018 09:24:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730149AbeITWHR (ORCPT + 99 others); Thu, 20 Sep 2018 18:07:17 -0400 Received: from mail.us.es ([193.147.175.20]:35332 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbeITWHQ (ORCPT ); Thu, 20 Sep 2018 18:07:16 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 70DECB5089 for ; Thu, 20 Sep 2018 18:23:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 625EDDA73F for ; Thu, 20 Sep 2018 18:23:00 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 4D441DA8FC; Thu, 20 Sep 2018 18:23:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 6CFCBDA8F6; Thu, 20 Sep 2018 18:22:58 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 20 Sep 2018 18:22:58 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.245.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3B2AC4265A32; Thu, 20 Sep 2018 18:22:58 +0200 (CEST) Date: Thu, 20 Sep 2018 18:22:56 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: zhong jiang Cc: davem@davemloft.net, kadlec@blackhole.kfki.hu, fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: get rid of double sizeof Message-ID: <20180920162256.yrjkxw6n7q75ibom@salvia> References: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 08:21:11PM +0800, zhong jiang wrote: > sizeof(sizeof()) is quite strange and does not seem to be what > is wanted here. > > The issue is detected with the help of Coccinelle. Applied to nf, thanks.