Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2283466imm; Thu, 20 Sep 2018 10:32:32 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYigNjhU+t4WFqvGkfcXGWC4+7sKGD4U7/eDTb5YFzooYoeIFSfSwb4NDMg+HPfgfmJTUOP X-Received: by 2002:a17:902:18a:: with SMTP id b10-v6mr40483443plb.62.1537464752486; Thu, 20 Sep 2018 10:32:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537464752; cv=none; d=google.com; s=arc-20160816; b=ID1p5RlN28aAaZE/JYeVazrJ5rMS5gFIZvnbxodagwrHDHsED070Vf170DFQR2s9iF t/1eisNyzNKyeq2S0EX4yjdFvfscX418jnJDP+p34EaX/1Wll6Gb5/zmH2i0ekS9hr51 W9qZO4r3SUaqx2w6SqAqb6PsaclB1YesQUfYgQWsNrIIPkmIyX6hBLd4sjIITlQ2o+eA uiGeOFMWDRdbDJVbgglad8txFi9Z+9dChzpCTlQRHgd46WOBvSJQGkjF1Wv33VmAaRfz beFVwsnBeLmcwZX/0RwWfnnjB0eQ6iztnrh1IK+IH7+GWLiqkSWO/BxPlHw82+j7sFgR 9Qxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=5MAC1GT8VaitCSn6Wfa7q8fqA5WawyRV8USuRjNHlWw=; b=pJTmI8JCvxmyXu1Q6O57N8iXwXogHJLADgP3VCFqbepgn+KS59KNp0vOjShcfDlEVy rQpmrn8z8hEchJ8vk2oHNPlAgYuC5cVcL8mz5kXQXalAGUJKPW4f52hLe+8JlTCFgDly zz4wkrIvXoH40DFmlkg18F7glw6r7/gkB8dtPeBQlYgA/mU2sNAwyqXKB3PiErCl6Tfi RSCu6SvAzo841q0dce4CLigpqyYaXcpJCvvt2QofUkZ7lJQKTOkGkmVIOwMeox4Suirr NZ74ywsfslj91weIXnXvwglkZ0csWOhA2fxca3dba+xmgBut1xO3I8RE55UfNQXMDuKE U5dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 142-v6si27457097pfy.182.2018.09.20.10.32.16; Thu, 20 Sep 2018 10:32:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388050AbeITXQ3 (ORCPT + 99 others); Thu, 20 Sep 2018 19:16:29 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:8434 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387812AbeITXQ2 (ORCPT ); Thu, 20 Sep 2018 19:16:28 -0400 Received: from sc9-mailhost3.vmware.com (10.113.161.73) by EX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP Server id 15.0.1156.6; Thu, 20 Sep 2018 10:31:47 -0700 Received: from sc2-haas01-esx0118.eng.vmware.com (sc2-haas01-esx0118.eng.vmware.com [10.172.44.118]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 5CAFD40699; Thu, 20 Sep 2018 10:31:48 -0700 (PDT) From: Nadav Amit To: Greg Kroah-Hartman , Arnd Bergmann CC: , Xavier Deguillard , Nadav Amit Subject: [PATCH v2 14/20] vmw_balloon: add reset stat Date: Thu, 20 Sep 2018 10:30:20 -0700 Message-ID: <20180920173026.141333-15-namit@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180920173026.141333-1-namit@vmware.com> References: <20180920173026.141333-1-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (EX13-EDG-OU-001.vmware.com: namit@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is useful to expose how many times the balloon resets. If it happens more than very rarely - this is an indication for a problem. Reviewed-by: Xavier Deguillard Signed-off-by: Nadav Amit --- drivers/misc/vmw_balloon.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index 99a831ea82c0..9b0b3fa4f836 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -218,7 +218,8 @@ enum vmballoon_stat_page { enum vmballoon_stat_general { VMW_BALLOON_STAT_TIMER, VMW_BALLOON_STAT_DOORBELL, - VMW_BALLOON_STAT_LAST = VMW_BALLOON_STAT_DOORBELL + VMW_BALLOON_STAT_RESET, + VMW_BALLOON_STAT_LAST = VMW_BALLOON_STAT_RESET }; #define VMW_BALLOON_STAT_NUM (VMW_BALLOON_STAT_LAST + 1) @@ -1303,6 +1304,7 @@ static void vmballoon_reset(struct vmballoon *b) vmballoon_deinit_batching(b); } + vmballoon_stats_gen_inc(b, VMW_BALLOON_STAT_RESET); b->reset_required = false; error = vmballoon_vmci_init(b); @@ -1380,7 +1382,8 @@ static const char * const vmballoon_stat_page_names[] = { static const char * const vmballoon_stat_names[] = { [VMW_BALLOON_STAT_TIMER] = "timer", - [VMW_BALLOON_STAT_DOORBELL] = "doorbell" + [VMW_BALLOON_STAT_DOORBELL] = "doorbell", + [VMW_BALLOON_STAT_RESET] = "reset", }; static int vmballoon_enable_stats(struct vmballoon *b) -- 2.17.1