Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hans Verkuil <hans.verkuil@cisco.com>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] [media] ad5820: DT new optional field enable-gpios
Date:   Thu, 20 Sep 2018 23:23:43 +0300
Message-ID: <2983018.WjSXnZMEY4@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <1939782.bRt5jKDIiS@avalon>
References: <20180920161912.17063-1-ricardo.ribalda@gmail.com> <20180920161912.17063-3-ricardo.ribalda@gmail.com> <1939782.bRt5jKDIiS@avalon>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thursday, 20 September 2018 23:21:28 EEST Laurent Pinchart wrote:
> Hi Ricardo,
> 
> Thank you for the patch.
> 
> On Thursday, 20 September 2018 19:19:11 EEST Ricardo Ribalda Delgado wrote:
> > Document new enable-gpio field. It can be used to disable the part
> > without turning down its regulator.
> > 
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/media/i2c/ad5820.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> > b/Documentation/devicetree/bindings/media/i2c/ad5820.txt index
> > 5940ca11c021..07d577bb37f7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> > 
> > @@ -8,6 +8,11 @@ Required Properties:
> >    - VANA-supply: supply of voltage for VANA pin
> > 
> > +Optional properties:
> > +
> > +   - enable-gpios : GPIO spec for the XSHUTDOWN pin.
> 
> xshutdown is active-low, so enable is active-high. Should this be documented
> explicitly, to avoid polarity errors ? Maybe something along the lines of
> 
> - enable-gpios: GPIO spec for the XSHUTDOWN pin. Note that the polarity of
> the enable GPIO is the opposite of the XSHUTDOWN pin (asserting the enable
> GPIO deasserts the XSHUTDOWN signal and vice versa).

Or alternatively you could name the property xshutdown-gpios, as explained in 
my (incorrect) review of 2/4.

> > If specified, it will be
> > +     asserted when VANA-supply is enabled.
> 
> That documents a driver behaviour, is it needed in DT ?
> 
> >  Example:
> >         ad5820: coil@c {
> > 
> > @@ -15,5 +20,6 @@ Example:
> >                 reg = <0x0c>;
> >                 VANA-supply = <&vaux4>;
> > 
> > +               enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>;
> >         };


-- 
Regards,

Laurent Pinchart