Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp89261imm; Thu, 20 Sep 2018 15:46:25 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaFeXZ4xPDduUPbnjQmzC67X9FIWhj/02LnZvMHeKyPP3jrHksOwKbjsx5kj8r/4lwPKUjj X-Received: by 2002:a63:31c8:: with SMTP id x191-v6mr794586pgx.229.1537483585262; Thu, 20 Sep 2018 15:46:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537483585; cv=none; d=google.com; s=arc-20160816; b=aiAEwdttAbybEcgoIwKYV7QXIRUKW0Rr55FGwdXhgDS+X4pEG++5AOOP9/wTDPgAvQ fdOunJB/W4nOXhWsIT+ZobwHPC0CC//JEHeDHnvUEfFLu10CgeOPA4ulrJNWQfSULF0b kIfhiJ6abMYYIBjqEnmzpEIcpXLFVO8x3P/BtcQdM36krQdzRanG1NUqSF+CGynIuxyY DXnohWI87OU/0R8Q40NTy+9wnjBx/VYyDKlIVzcoONhIH/eHgVERss7f8qnumQOGCpr0 FDC8sEXUdOiP+Q6NsCXeyWHHbX9hDbCpOS62PSJefDG3w9ItH7LRP/5VMxHPZEldmMJ9 Iy5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature; bh=HJwelznJciBkGEfmSg8Zccv/3L5c3vc8u0JGdhw6hag=; b=kErNiw8dZGgH4//dEoG1xkP0AZZctTXIPL1TstY/56geEuf3fehU0Am0OvgFkXWbWV S8rc5OipiSvjLDe+uBiZ0mHxgA8DUAnUtWTVIyEMBiBL/EgZSj0iHf6IIF4gy6bU8OP4 3eFZWIy6CjONKnXnBYKUnamVjERlJU2fSNII2/XY2N9qBzTVv+iUYPVOGFuKJTyQP77T eTV+h5QVKjHX12/NRsDYUYf9mrhpzb0QG9WJTahFZ1DeEdmzTltcn9nHH6JsaQiB9avs jR2p6KO/wqs2ZDODCPLE1vETrt+dZoAkd9Lgp4a1g7AjSmC6VqoG70fLQdUyEHHIwI6v UuFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Pu2OvzjK; dkim=pass header.i=@codeaurora.org header.s=default header.b=Fru2pBzi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3-v6si25425314pld.454.2018.09.20.15.46.09; Thu, 20 Sep 2018 15:46:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Pu2OvzjK; dkim=pass header.i=@codeaurora.org header.s=default header.b=Fru2pBzi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727356AbeIUEbt (ORCPT + 99 others); Fri, 21 Sep 2018 00:31:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56832 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbeIUEbt (ORCPT ); Fri, 21 Sep 2018 00:31:49 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4504260C61; Thu, 20 Sep 2018 22:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537483562; bh=tj71YHs95BcB0PwgaNxXFmaEFnuER7g6AjjmrUabc5w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Pu2OvzjKQknE1zWBlk6WcjZ4WDGRLZ6WKG20NrBHYFGztv0QnCRuGEtV1WVSzPQX3 Y0yPFsOvZTx2Fmn1gUMkzH/9ot8IvnY/YIHpP3w4774HytdXGzHwuzVOVsn/fNkKl/ J4ifqqeNeNtDRDNxfTLmMhzW0t0tNo0j7iCRUHa0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.80.45.152] (unknown [71.69.156.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EB6B960BE3; Thu, 20 Sep 2018 22:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537483561; bh=tj71YHs95BcB0PwgaNxXFmaEFnuER7g6AjjmrUabc5w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Fru2pBziV09rV6zQhr5RzpGVUQVutxrRegx8cPhe4jClLU91OoFCMwMAU1kF4vjqL fB8Uist6KK99KdvLu5ApCDg4BoMMsP4X935OBwgOI5hMmegDX3OyGTp8g6YrTHBYwV LnRLNVjKk2MPmCtKQzUzEB2mitbvg/fY6jK8WosI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EB6B960BE3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR) To: Matthias Kaehlcke , Greg Kroah-Hartman , "Rafael J . Wysocki" , Sakari Ailus , Marcin Wojtas , Andy Shevchenko , Marcel Holtmann , Johan Hedberg Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Balakrishna Godavarthi , Loic Poulain , Brian Norris References: <20180920223436.202454-1-mka@chromium.org> From: Sinan Kaya Message-ID: <0ea65ca1-8d06-72d8-3bbe-693e09605a8a@codeaurora.org> Date: Thu, 20 Sep 2018 18:45:58 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180920223436.202454-1-mka@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/2018 6:34 PM, Matthias Kaehlcke wrote: > On some systems the Bluetooth Device Address (BD_ADDR) isn't stored > on the Bluetooth chip itself. One way to configure the BD address is > through the device tree. The btqcomsmd driver is an example, it can > read the BD address from the DT property 'local-bd-address'. It is > also planned to extend the hci_qca driver to support setting the BD > address through the DT. > > To avoid redundant open-coded reading of 'local-bd-address' and error > handling this series adds an API to retrieve the BD address of a device > and adapts the btqcomsmd driver to use this API. I don't think you have got enough number of line savings to make this code to be folded into property.c Not my call but seems redundant IMO.