Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp98642imm; Thu, 20 Sep 2018 19:14:09 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbnpIf+CeWw9W4yHxzARXNX1iun12/cnnYBYwVm9GQpcnZjfOWtHHgX/ZFXE+4Gb1Y/y22X X-Received: by 2002:a63:f902:: with SMTP id h2-v6mr39295183pgi.154.1537496049569; Thu, 20 Sep 2018 19:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537496049; cv=none; d=google.com; s=arc-20160816; b=lIxApkA/jzVTggc0oVSWPfz3NRyXC8RMp5ARo2IjUJOcdmDs8QVUAtGTEqtd1cYA0R xk+hOX5d3s5pDHPeUqrZuD7PBCqr+ewbHG8CnfAabE4XRORttNlRHmr+EcdZl9C4kasw FzhTWKNmS9L6RR+u+0ei4G/Cd3BCRBPbLWOziisJEquyF/AdZp6c30vrggNwoZP9bGUx jiyTzCCcas/3EefKu5OQlNJMCVrG0/5H2ABuB6BpwcYQoAqlUwsTN9+xBFNCHmNclg9q ep+lK0P94M/gg+BD05ekdPLoFMO1GQySVbiRKyJ4Is8508v3QEMisISwplVbXfTOHk5Y mlzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=v97GAYFS8s8EYIvg/SRNdNQ5epVlMHV82IzaUGVZrOw=; b=V+wXnpl2K640wCTsXW6KGsVvsXP1WyhHR2bqZS5xU4wI+AwwLzwSOP4TRPcKZGgTdd A3F1ZqBI/IAawk8z6wG4ZlgZGwTqu+4kF3OnD6ys/Q3kJCvHLHO9lqA60KR49KJ9SZz+ i8dMZodNEod7j/5bTT2cmQM6+G0Pk5yCJ7lm0c2qYGmpmAowH04lUrt0DH/feUaME157 q4XsIoVDMCRlQHvpRu8d9Kfpl3/bpSBRIGkAsPY+HVHehmjuEttf6gTFRPZpiktKmMFp V8/nCwMJ4nvwb206OwDmug1mzeLSmQvpjka6IvYiIGP4+ZMxyDt18y/cbfkMbIRpk5Nw r8xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7-v6si25700347plo.253.2018.09.20.19.13.53; Thu, 20 Sep 2018 19:14:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388906AbeIUH6z (ORCPT + 99 others); Fri, 21 Sep 2018 03:58:55 -0400 Received: from anchovy2.45ru.net.au ([203.30.46.146]:42844 "EHLO anchovy2.45ru.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbeIUH6z (ORCPT ); Fri, 21 Sep 2018 03:58:55 -0400 X-Greylist: delayed 401 seconds by postgrey-1.27 at vger.kernel.org; Fri, 21 Sep 2018 03:58:54 EDT Received: (qmail 14378 invoked by uid 5089); 21 Sep 2018 02:05:42 -0000 Received: by simscan 1.2.0 ppid: 14281, pid: 14282, t: 0.0469s scanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950 Received: from unknown (HELO ?192.168.0.122?) (preid@electromag.com.au@203.59.235.95) by anchovy3.45ru.net.au with ESMTPA; 21 Sep 2018 02:05:41 -0000 Subject: Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer To: Song Qiang , jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180920131340.6699-1-songqiang1304521@gmail.com> From: Phil Reid Message-ID: <4633d30b-b493-d70b-dd7b-3f5bc3e16e78@electromag.com.au> Date: Fri, 21 Sep 2018 10:05:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180920131340.6699-1-songqiang1304521@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2018 9:13 PM, Song Qiang wrote: > PNI RM3100 magnetometer is a high resolution, large signal immunity > magnetometer, composed of 3 single sensors and a processing chip. > PNI is currently not in the vendors list, so this is also adding it. > In the subject: Isn't the RM3100 a 3axis mag. The 9axis bit comes when you combine it with an accel / gryo I think. ... snip > +++ b/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > @@ -0,0 +1,57 @@ > +* PNI RM3100 9-axis magnetometer sensor > + > +I2C Bus: > + > +Required properties: > + > +- compatible : should be "pni,rm3100-i2c" > +- reg : the I2C address of the magnetometer > + ... snip > +SPI Bus: > + > +Required properties: > + > +- compatible : should be "pni,rm3100-spi" > +- reg : address of sensor, usually 0 or 1. > + Looking at other drivers supporting i2c / spi. They use the same compatible for both. eg: see iio/accel/adxl345_*.c and it's binding doc: Required properties: - compatible : should be "adi,adxl345" - reg : the I2C address or SPI chip select number of the sensor