Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5BA4570F.6050700@huawei.com>
Date:   Fri, 21 Sep 2018 10:27:27 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Baoquan He <bhe@redhat.com>
CC:     <ebiederm@xmission.com>, <kexec@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: kexec_file: remove some duplicated include file
References: <1537420323-30658-1-git-send-email-zhongjiang@huawei.com> <20180921021524.GP2555@MiWiFi-R3L-srv>
In-Reply-To: <20180921021524.GP2555@MiWiFi-R3L-srv>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/9/21 10:15, Baoquan He wrote:
> On 09/20/18 at 01:12pm, zhong jiang wrote:
>> kexec.h and slab.h have duplicated include. hence just remove
>> redundant file.
> They have duplicated include, why do you remove both of them?
because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.

Thanks,
zhong jiang
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  kernel/kexec_file.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c6a3b68..35cf0ad 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -25,8 +25,6 @@
>>  #include <linux/elf.h>
>>  #include <linux/elfcore.h>
>>  #include <linux/kernel.h>
>> -#include <linux/kexec.h>
>> -#include <linux/slab.h>
>>  #include <linux/syscalls.h>
>>  #include <linux/vmalloc.h>
>>  #include "kexec_internal.h"
>> -- 
>> 1.7.12.4
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
> .
>