Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp153181imm; Thu, 20 Sep 2018 20:37:04 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdafk6EhCW6n1mzLenqBbbesfSD2b6qEXTrFrx/kP1+PXhGF+Iu6vAs9WAGb8V8c/URLIYQy X-Received: by 2002:a62:b2d3:: with SMTP id z80-v6mr45032279pfl.79.1537501024824; Thu, 20 Sep 2018 20:37:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537501024; cv=none; d=google.com; s=arc-20160816; b=PnFIjZ4hKcZFMT9IiZuSn69uQ5v/2MChb4c3lZUdqpR2LEUSTpiYi4F70jdK19RCAA Spq6NeNOl8VXmN+6F3hm/WqqbTWgg9LryI/kdR44z21kgh5yzY8OhF5W590fG57s/An3 UA0MGjXF4KHUiLQmhefB+5aPIZZ/fDtkAcG05h8CqCrtDwv6j15vsvECfMLTpfL9nMPz ZfLppdPq3ZBy/ow/iRhnWGfsEUVadN2uXnS4VdKnBpiS0n9JuvRZIyif4ZwxdPMO0uUq hO7E75pi11GmvoksXhEMR55m41yPYl+rncvcokiyAvFWLxe0zCznTrvAuyMJ6qfEz0kX 7e6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id; bh=R0C6HXv2L4VWvnI/H9v4jwytq52dAHa+DlykoJMBne4=; b=w1NM2o7m90GYrSGSKPNHiOxBbghVzEOBzzQNr91Q7DFaftxgOsx+vZmRPbTDQnHmKt 7GLIZ2iX5uuVJClGwbzAKBhBQcDOinP42o8yioQZxYyENR22I1JHOXC2+JpK3IzhN76t Vk2uMuOapR/WI+1fSRTIQwEe//V/mRwwAo118NDcUpWHDIlEGbY/tRFmb1Fw8DU+t6iR BonnzEPbMm99NYsCpNuLu9x1xGqpvudJqutu8tAh9s8UVVm5TrZT4IsaWdXVh8MEP1ev 9GgHZBjgfEc7eELZ8km2tIF8x9FLr54XIJrMOZdDRFXGYpNNoDPu+GgXGoAl62cVfBNE tKGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5-v6si24912319pgk.200.2018.09.20.20.36.49; Thu, 20 Sep 2018 20:37:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389125AbeIUJXc (ORCPT + 99 others); Fri, 21 Sep 2018 05:23:32 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12667 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726160AbeIUJXb (ORCPT ); Fri, 21 Sep 2018 05:23:31 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C4D0953F1E239; Fri, 21 Sep 2018 11:36:38 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.399.0; Fri, 21 Sep 2018 11:36:35 +0800 Message-ID: <5BA46742.4010804@huawei.com> Date: Fri, 21 Sep 2018 11:36:34 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Todor Tomov CC: , , Subject: Re: [PATCH] media: qcom: remove duplicated include file References: <1537419595-29990-1-git-send-email-zhongjiang@huawei.com> <43b41757-18ea-cbb3-1578-ba4068b13ab1@linaro.org> In-Reply-To: <43b41757-18ea-cbb3-1578-ba4068b13ab1@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/9/20 13:55, Todor Tomov wrote: > Thank you for spotting that! > > On 19.09.2018 21:59, zhong jiang wrote: >> device.h have duplicated include. hence just remove >> redundant include file. > I think it will be better to remove the second occurrence because > it will keep the alphabetical order of the includes. Yep, I forget the point. Will change in v2. Thanks, zhong jiang > Best regards, > Todor Tomov > >> Signed-off-by: zhong jiang >> --- >> drivers/media/platform/qcom/camss/camss.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h >> index 418996d..0823a71 100644 >> --- a/drivers/media/platform/qcom/camss/camss.h >> +++ b/drivers/media/platform/qcom/camss/camss.h >> @@ -10,7 +10,6 @@ >> #ifndef QC_MSM_CAMSS_H >> #define QC_MSM_CAMSS_H >> >> -#include >> #include >> #include >> #include >> > >