Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1537494404-16473-1-git-send-email-zhongjiang@huawei.com>
References: <1537494404-16473-1-git-send-email-zhongjiang@huawei.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Thu, 20 Sep 2018 21:49:12 -0700
Message-ID: <CAGXu5jJ_XoDRJXhE1OpCFxn6LGaNjRHFvYupeUjyqgzDZg=gXg@mail.gmail.com>
Subject: Re: [RESEND PATCH] error-injection: remove meaningless null pointer
 check before debugfs_remove_recursive
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 20, 2018 at 6:46 PM, zhong jiang <zhongjiang@huawei.com> wrote:
> debugfs_remove_recursive has taken the null pointer into account.
> just remove the null check before debugfs_remove_recursive.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  kernel/fail_function.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/fail_function.c b/kernel/fail_function.c
> index bc80a4e..17f75b5 100644
> --- a/kernel/fail_function.c
> +++ b/kernel/fail_function.c
> @@ -173,8 +173,7 @@ static void fei_debugfs_remove_attr(struct fei_attr *attr)
>         struct dentry *dir;
>
>         dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);
> -       if (dir)
> -               debugfs_remove_recursive(dir);
> +       debugfs_remove_recursive(dir);
>  }
>
>  static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)
> --
> 1.7.12.4
>


-- 
Kees Cook
Pixel Security