Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1537498098-19171-1-git-send-email-zhongjiang@huawei.com>
References: <1537498098-19171-1-git-send-email-zhongjiang@huawei.com>
From:   Bhupesh Sharma <bhsharma@redhat.com>
Date:   Fri, 21 Sep 2018 10:51:49 +0530
Message-ID: <CACi5LpMPZiv7zgZLR9SD=2SPPT8W3RuP6=NHD4rzqVnpB4xkaA@mail.gmail.com>
Subject: Re: [PATCHv2] kernel: kexec_file: remove some duplicated include file
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     Baoquan He <bhe@redhat.com>,
        kexec mailing list <kexec@lists.infradead.org>,
        Eric Biederman <ebiederm@xmission.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Fri, Sep 21, 2018 at 8:18 AM, zhong jiang <zhongjiang@huawei.com> wrote:
> We include kexec.h and slab.h twice in kexec_file.c. It's unnecessary.
> hence just remove them.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  kernel/kexec_file.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index c6a3b68..35cf0ad 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -25,8 +25,6 @@
>  #include <linux/elf.h>
>  #include <linux/elfcore.h>
>  #include <linux/kernel.h>
> -#include <linux/kexec.h>
> -#include <linux/slab.h>
>  #include <linux/syscalls.h>
>  #include <linux/vmalloc.h>
>  #include "kexec_internal.h"
> --
> 1.7.12.4
>

Nice catch.
Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>

BTW while we are at it, can you also send out a separate patch to list the
include files in this file (i.e. kexec_file.c) alphabetically (similar
to other linux source files - see
<https://patchwork.kernel.org/patch/10258279/> for example). Something
like:

#include <crypto/hash.h>
#include <crypto/sha.h>
#include <linux/capability.h>
#include <linux/elf.h>
#include <linux/elfcore.h>
#include <linux/file.h>
#include <linux/fs.h>
#include <linux/ima.h>
#include <linux/kernel.h>
#include <linux/kexec.h>
#include <linux/list.h>
#include <linux/mm.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/syscalls.h>
#include <linux/vmalloc.h>
#include "kexec_internal.h"

This will improve readability and also reduce similar instances of
include files being added twice in this source file in future.

Thanks,
Bhupesh