Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp269749imm; Thu, 20 Sep 2018 23:20:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYZ4Ok7NXSZBVCn8ONRoAiO/r1FMfLoIpyETvvQY2CixoQfqtIqKXBrap+JRaxFPIdEhYX9 X-Received: by 2002:a17:902:2f43:: with SMTP id s61-v6mr41790376plb.176.1537510806053; Thu, 20 Sep 2018 23:20:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537510806; cv=none; d=google.com; s=arc-20160816; b=LU+KQ9ntQHv/jNtN5rCxS/VAxky7BlZAig98x7FTtIPCc6Ost7A6kBWJcTOCE1LG/o 1TF0AW/vLbtmJvsmi9BHVxwwTV+b2ywqP+Bu/tXzMyNeHyfzXkmiTDjLGuG2vJI890O8 BDcycKLIk8Tja0rZucfgy7Zwz8SOCNm2+itXgAIaaWaw97faVn/uMWJklBGfAbnD6E6h QcGM7DPTZpCrqkVuZil9BJcVRQnDAJekTc7RvDEl7SbLQuCq3VyTA1bHiSBtMXgYAHlH GuDzqpYgG1WtHpj2Ov9PKeVcabbgi+BxXCM6tf2kGi8+16/+zY+3CND1ng2u+fxHz3nM /deg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=uQm8c2U6o8iVZVbA3EUdNara8RjtEthAKrhrNwdpWgY=; b=U6iiCNSxFjyFP/oSjE/tR5dimX5KxT+DdUNMvYgBaBzh0PkIcUkRt7NhrgpqpcrYXz zgEmFd7z+FeVaiIxSMELEmseWqyd1CcvncZgN8DXHgpgdbc6/yYB7WI+8zz20xrur8To YYvhDsQx1slb52t16Xf+eb1lTPB+IlHjkNcZeOzA0hZSOcn+cSq2tdqZf1xgEQD/osRV 6pVVqTcA3e/yJOlPrp+bGXLLrXgzEzyYAR8nT4HJSXgDgayjGRmApfsx6B4VQuOt6Fnx gHoH9D5/1aZIOFNLn3ImX8E0LTmxaRVeVJnpt57e6dDZ0mcLZZTgG1dBce4A7x396sEx 1ndg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1-v6si27388427pfe.66.2018.09.20.23.19.49; Thu, 20 Sep 2018 23:20:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389295AbeIUMGx (ORCPT + 99 others); Fri, 21 Sep 2018 08:06:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:41430 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbeIUMGx (ORCPT ); Fri, 21 Sep 2018 08:06:53 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 23:19:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,283,1534834800"; d="scan'208";a="234744635" Received: from chenyu-desktop.sh.intel.com ([10.239.160.116]) by orsmga004.jf.intel.com with ESMTP; 20 Sep 2018 23:19:28 -0700 From: Chen Yu To: Thomas Gleixner , "Rafael J. Wysocki" Cc: Pavel Machek , Len Brown , Zhimin Gu , Chen Yu , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 00/12][v4] Backport several fixes from 64bits to 32bits hibernation Date: Fri, 21 Sep 2018 14:24:46 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently there are mainly three bugs in 32bits system when doing hibernation: 1. The page copy code is not running in safe page, which might cause hang during resume. 2. There's no text mapping for the final jump address of the original kernel, which might cause the system jumping into illegal address and causes system hang during resume. 3. The restore kernel switches to its own kernel page table(swapper_pg_dir) rather than the original kernel page table after all the pages been copied back, which might cause invalid virtual-physical mapping issue during resume. To solve these problems: 1. Copy the code core_restore_code to a safe page, to avoid the instruction code been overwritten when image kernel pages are being copied. 2. Set up temporary text mapping for the image kernel's jump address, so that after all the pages have been copied back, the system could jump to this address. 3. Switch to the original kernel page table during resume. Furthermore, MD5 hash check for e820 map is also backported from 64bits system. In order to make this patch set more readable, these fixes are splitted into several sub patches. And use CONFIG_X86_64 to control the common code to be 'activated' for 32 bit system during each sub-patch for better maintaining. Chen Yu (1): PM / hibernate: Check the success of generating md5 digest before hibernation Zhimin Gu (11): x86, hibernate: Fix nosave_regions setup for hibernation x86-32/asm/power: Create stack frames in hibernate_asm_32.S x86, hibernate: Extract the common code of 64/32 bit system x86-32, hibernate: Enable CONFIG_ARCH_HIBERNATION_HEADER on 32bit system x86, hibernate: Rename temp_level4_pgt to temp_pgt x86-32, hibernate: Use temp_pgt as the temporary page table x86-32, hibernate: Use the page size macro instead of constant value x86-32, hibernate: Switch to original page table after resumed x86-32, hibernate: Switch to relocated restore code during resume on 32bit system x86-32, hibernate: Set up temporary text mapping for 32bit system x86-32, hibernate: Adjust in_suspend after resumed on 32bit system arch/x86/Kconfig | 2 +- arch/x86/include/asm/suspend.h | 8 + arch/x86/include/asm/suspend_32.h | 4 + arch/x86/kernel/setup.c | 2 +- arch/x86/power/Makefile | 2 +- arch/x86/power/hibernate.c | 248 ++++++++++++++++++++++++++++++ arch/x86/power/hibernate_32.c | 52 +++++-- arch/x86/power/hibernate_64.c | 224 +-------------------------- arch/x86/power/hibernate_asm_32.S | 37 ++++- arch/x86/power/hibernate_asm_64.S | 2 +- 10 files changed, 334 insertions(+), 247 deletions(-) create mode 100644 arch/x86/power/hibernate.c -- 2.17.1