Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp382847imm; Fri, 21 Sep 2018 01:42:39 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZeY325ElX8/1Bo81Kwis4TJqzK4Ci0McvTbJ4weUWnJfE0jNQBxDaG7WZoimEejvXTCOmy X-Received: by 2002:a62:5cc1:: with SMTP id q184-v6mr46065544pfb.241.1537519359557; Fri, 21 Sep 2018 01:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537519359; cv=none; d=google.com; s=arc-20160816; b=nSGasZg0S8etCGqN417NlLgj1bWNbDHG5dG37h7Ldd9zgeGfVh+jISzlUKOZ05ugyg K3IAScZFrN1Mpd3Qr08Hrw2L+VIXRQI34wliJuKcIBPpvdvFY748hu1cffNcNsGUMD2n S9Bp3VSecAZzecCnLXQWaR+bacaGZ7SW1uY0ClAJpXcOl61qyN19Qx+JKxo+0yWezSGL ueXzar79g8anM2w7YepgPcesnnlIl915yqbN2PklHMCrhZIUC//y+I+D3SwZIoGz/DVh X4xSQdS2lXGvFxeFaPT99j/KoROjSBwXCaFei+6GE5FlUWqn27LqMTnisLYWJIB3BhWM lA0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EfV1WN7cU/y2WVV0MYla7FO1XzmlGEfVF6a7UiKemSw=; b=yFAm2arTrmCjLYeXkm/s+2PYAcfkKad0AZc88fpgadve5tfLo/T7z2p0Eg+4juVyXb KSXTRBzKJ3O4BkV7fBs6o36BKZeG0E7BRWJEQmm5TOm4kxN7fIOop5HFGNkekTw3bYgb E/i/ojDmxxOTS5NVOIirRS5m/0oIrXBaxxsxZnOTBFKqVWCTJ5r6k+QYuZwpKQEARJEN iEoXAIzc7uFbm9R9pPQOBgSz2P3kcpO8n34NKiw1P1JHLSgS6/AcKP3yUsy6DMCHmjfM RwMMQsiizqAwLwWi1mRnIG4MGoquPLN02vIcWzHuWz1oiEIRSdEoGTCfC0VCDH6t0uhy RpQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g35-v6si28029418plb.108.2018.09.21.01.42.23; Fri, 21 Sep 2018 01:42:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389438AbeIUOaG (ORCPT + 99 others); Fri, 21 Sep 2018 10:30:06 -0400 Received: from gloria.sntech.de ([185.11.138.130]:59680 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727795AbeIUOaF (ORCPT ); Fri, 21 Sep 2018 10:30:05 -0400 Received: from wd0156.dip.tu-dresden.de ([141.76.108.156] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1g3H0i-0003Xp-1g; Fri, 21 Sep 2018 10:42:00 +0200 From: Heiko Stuebner To: Damian Kos Cc: David Airlie , Rob Herring , Mark Rutland , Archit Taneja , Andrzej Hajda , Laurent Pinchart , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Sandy Huang , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, pgaj@cadence.com, ltyrala@cadence.com, stelford@cadence.com, jartur@cadence.com, piotrs@cadence.com, quentin.schulz@bootlin.com, jbergsagel@ti.com, Quentin Schulz Subject: Re: [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge Date: Fri, 21 Sep 2018 10:41:59 +0200 Message-ID: <1903708.pJTgKoWLiI@phil> In-Reply-To: <1537455288-20223-6-git-send-email-dkos@cadence.com> References: <1537455288-20223-1-git-send-email-dkos@cadence.com> <1537455288-20223-6-git-send-email-dkos@cadence.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Damian, Am Donnerstag, 20. September 2018, 16:54:40 CEST schrieb Damian Kos: > From: Quentin Schulz > > This adds basic support for Cadence MHDP DPI to DP bridge. > > Basically, it takes a DPI stream as input and output it encoded in DP > format. It's missing proper HPD, HDCP and currently supports only > SST mode. > > Changes made in the low level driver (cdn-dp-reg.*): > - moved it to from drivers/gpu/drm/rockchip to > drivers/gpu/drm/bridge/cdns-mhdp-common.* > - functions for sending/receiving commands are now public > - added functions for reading registers and link training > adjustment > > Changes made in RK's driver (cdn-dp-core.*): > - Moved audio_info and audio_pdev fields from cdn_dp_device to > cdns_mhdp_device structure. > > Signed-off-by: Quentin Schulz > Signed-off-by: Damian Kos [...] > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index 0ccc76217ee4..129b0529f3e1 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -27,7 +27,9 @@ config ROCKCHIP_ANALOGIX_DP > > config ROCKCHIP_CDN_DP > bool "Rockchip cdn DP" > - depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) > + depends on DRM_ROCKCHIP=m Sorry, I wasn't fast enough in my reply to you mail to catch that before your v4, but I don't think this is necessary. Instead I do guess, the select below should do the right thing by making EXTCON=y if DRM_ROCKCHIP=y. Somewhat clumsily verified by making EXTCON=m in my defconfig and seeing get changed to y upon build, which I guess comes from a different "select" in the config. > + select EXTCON > + select DRM_CDNS_MHDP > help > This selects support for Rockchip SoC specific extensions > for the cdn DP driver. If you want to enable Dp on > diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gpu/drm/rockchip/Makefile > index a314e2109e76..16ba61ffca39 100644 > --- a/drivers/gpu/drm/rockchip/Makefile > +++ b/drivers/gpu/drm/rockchip/Makefile > @@ -3,13 +3,15 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > +ccflags-y += -I$(src)/../bridge hmm, instead of adding an include path, the shared header should probably just live in /include/drm/bridge/... in the kernel source? Heiko