Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp644990imm; Fri, 21 Sep 2018 06:07:12 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaS6HqxziqCGS1jqPi199af0grXFwkaoK0ONtZ+/TRYrka+1sbEjbSSe2MKYskwfaOCc5up X-Received: by 2002:a65:4d42:: with SMTP id j2-v6mr40697427pgt.232.1537535232271; Fri, 21 Sep 2018 06:07:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537535232; cv=none; d=google.com; s=arc-20160816; b=CyWJcyoAXZesFrt9CyhvoiP9mCS7ROpzIrEN3Hz18rDSNii2SzqwPDVdS5kXMaLjH0 p+5+FwFCN9Y+OGOZn/Lw34aEwsKPL6PkD/A8Gq+7F5Qwtv+R7O8JMcA/a+aujDzeS4jP r+w0QU1OD0Y47p9J4kogzqBY2Gf4rVOO7hNu5qs0dcT5pf8YIus96u42VI0+heGtw1f1 X+8Ev2uBVPyCIhJiX0QxURjl/il72+njuOR/Hm46D0imYyBTMF8CDX10ZSVvQoTz6AzN USgZU+fNzl90P0BjgwrZ9WccIoUdBXi0uoa7NV6md6AVOaQAviPs1mCqlB8sLIHHR/C+ YXXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature; bh=m3a2xktoMXO/I633rPSU+tzFGyBigyIoXTYgwP1b8Dg=; b=ye2Sp18APTgCacq1Q1qox7KHC4r2xlRtTU41UuodMTCpsMTIMuPD2tbjIPk23RtVlo j8APj5kYL2B4h74M2Sopm7zxVDslF+w4EldRCD8jLp61dol+rYjZ4HeOS7SacVY4SaDY cyp8bPtlYLy08G4ccW/kzYTc+XUryhjq3EjIuYiEsmV6WRDUHK8Ja0/HAExyvtu3k4S6 f4H5sPaNKq2jrtKfEMqZ51n6dIp0auh1KT1TDmkTefOq9X8KQl9BV7CwnAuwoz0OmZp1 oTJIH0N2JXfebMuJlArOgt4pLsVeAOiWdLKevoWEAaA9RBl3kU18Oo37UmmOnfhw5Ta2 kC7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tSS+POlC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i7-v6si28171331pfk.146.2018.09.21.06.06.38; Fri, 21 Sep 2018 06:07:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tSS+POlC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390035AbeIUSzA (ORCPT + 99 others); Fri, 21 Sep 2018 14:55:00 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35855 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728100AbeIUSy7 (ORCPT ); Fri, 21 Sep 2018 14:54:59 -0400 Received: by mail-wm1-f66.google.com with SMTP id j192-v6so3214348wmj.1; Fri, 21 Sep 2018 06:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=m3a2xktoMXO/I633rPSU+tzFGyBigyIoXTYgwP1b8Dg=; b=tSS+POlCIPCSi5TNVDeFPPu88q1TfTKyjkqVmX3t4wCtW2kkfoQWe3ScQHYqlNQDOV 1VJG9EAWL9o3nCAOnrFt0GRCRCgBHZVC1cxSXf0g5FVZRMXXJjF8jQBc5I4p2zdELtEX dm/5Hl6rAGUT8NAwAXNicvv5yBND8gPMhpxRBYydcpua3gGlIlmkDVvOU5DuIGHSJzgx e34k/kL3VmiYrvmAlhb+wBgJC9DhATSZLk+M+zseH9sxpbUc8N1+vWBZFUyexaBtXrt7 kfPtb2BIbS4dUzt5gq0RDP+Vpe5swpgC3JXzhjRQD3wWvspKIcNMCjy/bwg2nLs56dmT zk9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=m3a2xktoMXO/I633rPSU+tzFGyBigyIoXTYgwP1b8Dg=; b=r3ZprdDd7AeTRE692sYM5F6w9o4nwb3kzdm5GzL2oUOYy3xcqDml+CD0dU2k0yqPuS zzq1gFJTgzPgpVkYENZAWbQRPAZ4CPcjfTWLBgxNu3pQJbIWER0ccEm156t79GyAfz+l aIdcSB92inAP4pPQroeAerK07cOdB1a3inJq3+wd6zTpKPPBFBZ2d5281GwEwf0nbC/b HvpKAoDJvovvuAiHIT8nVkt6DK/r6FD4CuzZ50OOXLzRUw5CFVYS6/SbSa25c5pSuV0F ObjnyrGgW1azcI3fR5QnDucf/391TScpkyqPLqpYihTUh0MqyDbUf6fRqqQOOeEG7LfM lqew== X-Gm-Message-State: APzg51Bk9OwBLXyU7YZq7ZyAfMMrHQCzQFksheQjPLYGj4bcmMNBGga9 E3G1GwXCQXRPvARlcQAmN5fAP6YU X-Received: by 2002:a1c:8e04:: with SMTP id q4-v6mr7389406wmd.150.1537535170683; Fri, 21 Sep 2018 06:06:10 -0700 (PDT) Received: from inc028000032.lancs.ac.uk (inc028000032.lancs.ac.uk. [148.88.228.92]) by smtp.gmail.com with ESMTPSA id c15-v6sm3278702wmb.2.2018.09.21.06.06.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Sep 2018 06:06:10 -0700 (PDT) Date: Fri, 21 Sep 2018 14:06:09 +0100 From: Willy Wolff To: Zhang Rui , Eduardo Valentin , Daniel Lezcano , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] thermal: power_allocator: remove early break Message-ID: <20180921130609.j3esni6xwhi2ew7d@inc028000032.lancs.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a trip of type critical is defined before any trip of passive or active type, power_allocator governor will not switch on. Signed-off-by: Willy Wolff --- drivers/thermal/power_allocator.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c index 3055f9a12a17..6544b68e3ebf 100644 --- a/drivers/thermal/power_allocator.c +++ b/drivers/thermal/power_allocator.c @@ -496,8 +496,6 @@ static void get_governor_trips(struct thermal_zone_device *tz, } } else if (type == THERMAL_TRIP_ACTIVE) { last_active = i; - } else { - break; } } -- 2.11.0