Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp691596imm; Fri, 21 Sep 2018 06:48:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZI3q4XFDW3PWh9l82bQw4naA0O9Rqs6NDJQgSlJAFV1S2XM2d95rQaSqND4VEE0f/laTR1 X-Received: by 2002:a65:520d:: with SMTP id o13-v6mr40575942pgp.282.1537537738461; Fri, 21 Sep 2018 06:48:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537537738; cv=none; d=google.com; s=arc-20160816; b=it8enovLDSJZq2USMI1eynLrM8rdple6hiIgSmAECPm/KK9WT5upgg9qdYm1vgOnLJ z14zvpjC/uBscFqmZC0E8j19CVudVgqkHFl4pZokURcavCORdN1sbCEiufnS1JvmFGAC nviebjcA1g5AyD8R4KAitbXCsCP1rWVkHycWkYCDEFBXb5W5sE4N+YYwy4L2wZFGz/oI BAtY/602EHWpX2TQMcrEA1cXWPMqJvdOcqIqDJ4mCpln4BHujP3A8YTsHEXYviXG7hdT 6ygWy/sno1iFEuMiA5MWpgZhl8mjNUpA8+f0SVpbXjuopxtl3OUYPtt/8gLJGjO6iHgv qATg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=OQAyORp8amQFUolusogk9QeHjP7IhvNL33ovgniWk4Q=; b=ttkhO6a8CXcDFIb9g0iiiGaAUD2X3lDrdi9PUfwBOQuYMLdY5ffdMrU/uPrnBkVKGZ UrC/06z6hCUy4SNTyIn5s9DkBm158WX2JWFVq9sh1l92SfAZVoshK3SQLYyRbYLMmxfJ zTfAdUVpsJ95DvXEOmXwjn+yD3HGR/4ik8vrzgudzlXfKTJrDczXeITGq+HJcdtFoO/w 4URkpBOqlUjpp4dfmReRvaP/fi6DkweXVw6jafnbXmsx8MuQaatg/d1qIseBNxmOOzNF JVPylNiX3Rn2vlHWNLEMFM8jwgi2zulJoH+eJBpwAzsBJTHggokMd2/wkzgAyIe3+F3H tn3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m193-v6si32450066pfc.312.2018.09.21.06.48.42; Fri, 21 Sep 2018 06:48:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389702AbeIUTgG (ORCPT + 99 others); Fri, 21 Sep 2018 15:36:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36650 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbeIUTgG (ORCPT ); Fri, 21 Sep 2018 15:36:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F5DF2ED2E2; Fri, 21 Sep 2018 13:47:09 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id C82BB825E4; Fri, 21 Sep 2018 13:47:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D40139EE57; Fri, 21 Sep 2018 15:47:04 +0200 (CEST) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, michel@daenzer.net, imirkin@alum.mit.edu, Gerd Hoffmann , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 2/6] drm: use drm_driver_legacy_fb_format in drm_gem_fbdev_fb_create Date: Fri, 21 Sep 2018 15:47:00 +0200 Message-Id: <20180921134704.12826-3-kraxel@redhat.com> In-Reply-To: <20180921134704.12826-1-kraxel@redhat.com> References: <20180921134704.12826-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 21 Sep 2018 13:47:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Creating framebuffers for fbdev emulation should use the correct format code too, so switch drm_gem_fbdev_fb_create() over to use the new drm_driver_legacy_fb_format() function. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index 7607f9cd6f..ded7a379ac 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -316,8 +316,8 @@ drm_gem_fbdev_fb_create(struct drm_device *dev, if (pitch_align) mode_cmd.pitches[0] = roundup(mode_cmd.pitches[0], pitch_align); - mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp, - sizes->surface_depth); + mode_cmd.pixel_format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, + sizes->surface_depth); if (obj->size < mode_cmd.pitches[0] * mode_cmd.height) return ERR_PTR(-EINVAL); -- 2.9.3