Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anurag Kumar Vulisha <anuragku@xilinx.com>
To:     Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Thinh.Nguyen@synopsys.com" <Thinh.Nguyen@synopsys.com>,
        Ajay Yugalkishore Pandey <APANDEY@xilinx.com>,
        "joglekartejas@gmail.com" <joglekartejas@gmail.com>
Subject: RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3
 gadget driver
Thread-Topic: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3
 gadget driver
Thread-Index: AQHUTQCoBCMdjS6uDUqQ64x43Vb2OaT6xu+g
Date:   Fri, 21 Sep 2018 14:05:27 +0000
Message-ID: <BN3PR0201MB099350017190F7148107F51CA7120@BN3PR0201MB0993.namprd02.prod.outlook.com>
References: <1537021801-23896-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <6DE59E7D7B09224BB10C87AEADB5972690BB1B@IN01WEMBXB.internal.synopsys.com>
In-Reply-To: <6DE59E7D7B09224BB10C87AEADB5972690BB1B@IN01WEMBXB.internal.synopsys.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 836b2a8e-77f6-4767-0025-08d61fcb48b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2018 14:05:27.6057
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0993
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Tejas,

>-----Original Message-----
>From: Tejas Joglekar [mailto:Tejas.Joglekar@synopsys.com]
>Sent: Friday, September 21, 2018 7:01 PM
>To: Anurag Kumar Vulisha <anuragku@xilinx.com>; balbi@kernel.org;
>gregkh@linuxfoundation.org
>Cc: v.anuragkumar@gmail.com; linux-usb@vger.kernel.org; linux-
>kernel@vger.kernel.org; Thinh.Nguyen@synopsys.com; Ajay Yugalkishore Pande=
y
><APANDEY@xilinx.com>; joglekartejas@gmail.com
>Subject: Re: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to d=
wc3
>gadget driver
>
>Hello Anurag,
>On 9/15/2018 8:00 PM, Anurag Kumar Vulisha wrote:
>> These patch series fixes the broken BULK streaming support in
>> dwc3 gadget driver.
>>
>> Changes in v5:
>> 	1. Removed the dev_dbg prints as suggested bt "Thinh Nguyen"
>>
>> Changes in v4:
>> 	1. Corrected the commit messgae and stream timeout description
>> 	   as suggested by "Thinh Nguyen"
>>
>> Changes in v3:
>> 	1. Added the changes suggested by "Thinh Nguyen"
>>
>> Changes in v2:
>> 	1. Added "usb: dwc3:" in subject heading
>>
>> Anurag Kumar Vulisha (8):
>>   usb: dwc3: Correct the logic for checking TRB full in
>>     __dwc3_prepare_one_trb()
>>   usb: dwc3: update stream id in depcmd
>>   usb: dwc3: make controller clear transfer resources after complete
>>   usb: dwc3: implement stream transfer timeout
>>   usb: dwc3: don't issue no-op trb for stream capable endpoints
>>   usb: dwc3: check for requests in started list for stream capable
>>     endpoints
>>   usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl
>>     fields
>>   usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints
>>
>>  drivers/usb/dwc3/core.h   |  7 ++++
>>  drivers/usb/dwc3/gadget.c | 85
>++++++++++++++++++++++++++++++++++++++++++-----
>>  2 files changed, 84 insertions(+), 8 deletions(-)
>>
>Tested-By: Tejas Joglekar <tejas.joglekar@synopsys.com>
>I have tested this patch series except the stream transfer timeout patch o=
n HAPS-DX
>platform.  I am not aware of exact scenarios to test the timeout patch and=
 don't have
>a test for the same.

Thanks for testing the patches. The issue mentioned in the timeout patch (P=
atch 4) will
occur very rarely on the long runs and only when tested with stream capable=
 host. This
issue happens only when the host & dwc3 controller go out of sync, where th=
e dwc3
controller may wait for host to issue prime transaction and host may wait f=
or the gadget
to issue ERDY. I used controller version 2.90A  for testing this issue.  Th=
is issue is mentioned
in databook section 9.5.2

Thanks,
Anurag Kumar Vulisha