Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 21 Sep 2018 16:26:54 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     airlied@linux.ie, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: sun4i: Fix a uninitialized variable warning.
Message-ID: <20180921142654.ahuhswypvscjsuyj@flea>
References: <1537255520-41614-1-git-send-email-zhongjiang@huawei.com>
 <20180919084719.6ymf6h4eftomfab3@flea>
 <5BA2106C.2080007@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ayc3oltgnjlkh76l"
Content-Disposition: inline
In-Reply-To: <5BA2106C.2080007@huawei.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ayc3oltgnjlkh76l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
> On 2018/9/19 16:47, Maxime Ripard wrote:
> > On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
> >> Fix the following compile warning:
> >>
> >> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may b=
e used uninitialized in this function [-Wmaybe-uninitialized]
> >> bool has_lvds_rst, has_lvds_alt, can_lvds;
> >>
> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > I can't see any code path that would lead to an uninitialized usage of
> > that variable.
> >
> > Which compiler produced that warning? I tried building it today with
> > gcc 8.1.1, and I don't see that warning either.
>
> I indeed  hit the issue.  the gcc version is
> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609

I've tested with 4.* gcc, and it didn't report any error. It seems to
be a false positive for this particular version, so there's no need to
merge that patch. If more people are affected, we'll obviously do
something about it though.

Thanks!
Maxime

--=20
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--ayc3oltgnjlkh76l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAluk/60ACgkQ0rTAlCFN
r3TacQ//bSkkQxX7E4oJAxcF8drs6U518u9hj56SRGi/1OvPryJOC5C6C05lFaju
24Yr/qAa0drigSn7HAWqNZ8jXpHl1L2ckAwXxAbwoiq0LWGcylLr5KpDuvB7UauP
9tmir0ioLDJgm8U84CX8bHBzveYtScEkNJtiURCqc5B6S01L9NgCGI9Kn1D8yNDm
vgLS4rBK+Si3HAVFk8sNfegI5mV6LRD4ktHmz6taaG4U+QwGcboEd5J8Iei4PNpv
1BP/KVNWjThWOr5KvOZSdDex21kriAarmgtjXNxKl7ZIk3mrFOfb/UQJmMYZzY7k
QwaVHMGMnCWWRC6LWGlCAvXtII52GJ34LYUxCQIzk0I0aojd/1gO5BSh1+UdrGMC
3Qi8Nuk1bydued8M/dbUFwRBO09LpQKjNFIasz5nBeizls77J5wWM2g+3b8lLljn
04f6DX0RGQ77MINx37T0qVq9mpiJVbfw+1FJAyQwGKheA4G9FvmpPb6WB5icGF35
PBasmd/ummaw7bTeVS+cpey1suu1039BSLUcf26ugYlJsirRzegOHEzYAT29gSwv
I8OemphfVific8+4mHIVJ9wxQCFKKlo1zu7yBrgUQjQaiGfqMV+ZQDJes+ETnl7Q
SIXGlgFbN7jhgTme+VT+rAKe9IIlzAHSG9uOgrIdlxL8eb4OXbE=
=5SCw
-----END PGP SIGNATURE-----

--ayc3oltgnjlkh76l--