Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp759963imm; Fri, 21 Sep 2018 07:52:24 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbP/mQXyNct7MCMQ8OrU4ACrr+416p4R1KOfskHvsfZssQ/BbkUbKsNKlqlyL9tjKAbbZ11 X-Received: by 2002:a65:594b:: with SMTP id g11-v6mr41790445pgu.260.1537541544739; Fri, 21 Sep 2018 07:52:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537541544; cv=none; d=google.com; s=arc-20160816; b=XRtJX8O6MFp8Lg/NrsSfSat27kfg6LlqwDDGXegQQDHS1yZbqqmQLy+j3XW+tKK/M2 wutS/I6HMBUDPNKq4y8X8vGcZdpOnn2EJDnJuiwCTcbcGAGl8Hi1QmQsOh3F36wJ0o9T IYn4bhylcna7Ia8xvAuL3afP+L+2XMS46Jyl1pJkm7GsmMVb245nFGOPRM6OchGBcFRt E7/NoVBLPe92IviXD8Oc0ysDwON0T9mo6aTTa1ytdteInD6m8tsqP+drcyVfHWU52CDR z8943tGK7SDR4JANNCQMUmVFFjL38vrdQfuVFXG+V3/hRlRFjt+2QZpdMzmIU4lGxJnJ xNLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=gjZ8awVphJijDj+bNLNdJJjNaS1TVPYeWC4T4SoTRxY=; b=v8OuBLhRBIDbYbDGlDEbhKMoDauaMVs4AZhDGcC3vtuVIZRd0LitnynqteULBodIv7 4dwgI/Fg3r3aPLRBR1Md53PZz93H93QgmGTJpJznVCpIw0CE3QSB+0tI+HvBLuKK1oIK sjwXCCynSJgAljqzLgXFdagOO9Gr8Sx+iv8Gw/JdrDbPuLvdZdWm1Uy/H6+KY6M9RYK6 c4oaFcSQGyvMbxfzWJBjEVSrFYAQ9q00dBCOWdwwDfKtSQUf/u60ZlikgbswUKXJyMkZ bpEp3L5jX8iU+2wqqzSduiaN06MbhckyWXEkMwGR5N77rn1ZJTeNgeO36Q5lExwI0vlj DSlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u69-v6si25176143pgd.547.2018.09.21.07.52.08; Fri, 21 Sep 2018 07:52:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390065AbeIUUlQ (ORCPT + 99 others); Fri, 21 Sep 2018 16:41:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbeIUUlQ (ORCPT ); Fri, 21 Sep 2018 16:41:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86FE8C057F20; Fri, 21 Sep 2018 14:52:03 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FAD885A4F; Fri, 21 Sep 2018 14:52:02 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180920151214.15484-4-mszeredi@redhat.com> References: <20180920151214.15484-4-mszeredi@redhat.com> <20180920151214.15484-1-mszeredi@redhat.com> To: Miklos Szeredi Cc: dhowells@redhat.com, Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] mount: fix regression in setting "subtype" from legacy API MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <15828.1537541521.1@warthog.procyon.org.uk> Date: Fri, 21 Sep 2018 15:52:01 +0100 Message-ID: <15829.1537541521@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 21 Sep 2018 14:52:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > Subtype was initilized at the wrong place from the wrong source > (fstype->fs_type->name, which does not ever contain a subtype). > > Set subtype from do_new_mount(), where it actually does something. > Verified with fuse. Folded.