Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp783693imm; Fri, 21 Sep 2018 08:14:14 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZEA+EBzgT96g4uCCclxeV9b4Fvoirh5NUvHOgKltQ2tWj/quHo+W6fImwO7EBrUQn1WR+6 X-Received: by 2002:a63:f414:: with SMTP id g20-v6mr42044985pgi.407.1537542854701; Fri, 21 Sep 2018 08:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537542854; cv=none; d=google.com; s=arc-20160816; b=q1lCDWOQ1+Q8uvKgljEtcwUr4BLv9YX/Y/iipjPP69qChLDPPqcJYjZw/WHyIihmlQ 9AdRpCAMG9cObvU1gDkB1dCcyrN4Mbr0thZjWEeGSU5tzFxitSBrytWHfXHzwq9z9tfA ts5RJaIYqfeecbyZZapyC1NVQCIkKegp44aogRWi+gqgtVaFEhCOITfQsOEJhW+KMV/u 56nPv3FJlXupk/qFkIJgx9yRKJzoi7MSZHR2kbk14IdQ53c2Bn9GU4Ahimg7N/QPYyZe HnQ7fPSogy/BvetV/GgmeplB+tbuV6cEX0sQLobn8HtU4zTBseLv4t2AdH5qkUTp4iYV Nd4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=HP8HRkfK5CvDPWpnxyUmkC8Nib82XLuyVzqjcbVQjR0=; b=nlH7zMl3kw3SzPh4ES14jHDwWUrfZtVMymDJtHGi/FRjA5LnZr7PEJeFpw0GaoqqvB P1kjIfpGh3i5DxQkipFAkoByr73/xvWKXtMmleTlCJZIW/JWiRw9BbP+PRFVeBDMabAw I2dloG1TlVebgPfgCRsrYp60UNw5CmA2+tUhRI4KeW6+NRJypWXYMknrbKzJuz8EeJkC oUwXCqoW1lJqMWkItazIfb60KTORkLSVMrjGWaEkXKdK3nV+ANKXs0dtnkenQuT33li7 BA1x3l09MNKgcy94dkfGqluGry50MzYPW5t4su40q3s9YHLt/3g4FWgbObiEGIa25gOi jT4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t145-v6si6133732pgb.24.2018.09.21.08.13.56; Fri, 21 Sep 2018 08:14:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390620AbeIUVBG (ORCPT + 99 others); Fri, 21 Sep 2018 17:01:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728072AbeIUVBF (ORCPT ); Fri, 21 Sep 2018 17:01:05 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC68B3002C77; Fri, 21 Sep 2018 15:11:47 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8BEB7FFF2; Fri, 21 Sep 2018 15:11:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180920151214.15484-7-mszeredi@redhat.com> References: <20180920151214.15484-7-mszeredi@redhat.com> <20180920151214.15484-1-mszeredi@redhat.com> To: Miklos Szeredi Cc: dhowells@redhat.com, Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] fsconfig: rename FSCONFIG_CMD_CREATE to FSCONFIG_CMD_OBTAIN MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17546.1537542706.1@warthog.procyon.org.uk> Date: Fri, 21 Sep 2018 16:11:46 +0100 Message-ID: <17547.1537542706@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 21 Sep 2018 15:11:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > The old name strongly implies that a new superblock will be created from > the fs_context. This is not true: filesystems are free to retuse an > existing superblock and return that (for good reason). Kind of like open(O_CREAT) only ever creates files, right;-) Actually, FSCONFIG_CMD_OPEN might be a better name. David