Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp811312imm; Fri, 21 Sep 2018 08:38:26 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZyqzMk1hPqmLXlYrzUTPZUxalysjcIi21IBxPhPn8h6wSJpclcj9nKHhp9JmoYHI3/z1Ko X-Received: by 2002:a17:902:4906:: with SMTP id u6-v6mr44403911pld.44.1537544306457; Fri, 21 Sep 2018 08:38:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537544306; cv=none; d=google.com; s=arc-20160816; b=ALayH3+LN0V9nOuaZFBjcgikwNQRVS4UNn6c4+UTX5u+l45tYlsfktghl31WlF8EDk hZw6E+fzsQxdh5UiqhoL2W8L3VnhHX7b04FXtNgqgyPahAaEWroSGltsIzl0MGbUU4Bi ftU0LRerv2fYc4OFuYuSiBvn5qUcINx7pE3CgldCQPSotfvIzOv4rFFSzxVt9MDXSH9g d0bQr6+YGzif2Pa/kIIMUITIYMW9C+WUXVrnYo4hyqy5BC+Is2tJr4qqm2ZW7Pf6QETs QvR0AZJgr3EP3KSv3PKeckv/sI9RAr6E5BFYCxnUrcvKubj1HKHC/IV9Kh5ezPMW7yc3 CEyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=oXAU5LxKGyXdnR9onP2sCYmivC9/w4HVmNEMFBLTx94=; b=1AJtmEZGb/yQ+CAfDh1lvgSHwqQBx/YScmKOyl9ic7QFgQpR3WobCX5sIREpPK6GZi vXTi8aXgMIvg5FaXkMe2LRgdO0cDQCEOx61udWKUUY/z5dVCuzy792A9Ve3ePR3uWt8N m6npCJAzvvv2EOgM14/4sB8oU5E4MC8cgezdtdZ9qKnVABsq1+d0Lmgqb2urVy2WKHnM j2y/Ilps4CRhJfZj07H0lWnSK59f9BZqmRqvLzgmXaX0OrTesMuCYnVR400MZ/lDsilQ 6EXN8ZPbX3a8ww9Jb1kGwXzq7lzpORAOXaQs8OaTMyPKkMqF8F1CITPBJXBB0t78hYFM bOMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9-v6si26421925plr.78.2018.09.21.08.38.10; Fri, 21 Sep 2018 08:38:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390382AbeIUV0y (ORCPT + 99 others); Fri, 21 Sep 2018 17:26:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbeIUV0y (ORCPT ); Fri, 21 Sep 2018 17:26:54 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94C393002707; Fri, 21 Sep 2018 15:37:29 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 327F2106A7BB; Fri, 21 Sep 2018 15:37:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20180920151214.15484-1-mszeredi@redhat.com> <20180920151214.15484-6-mszeredi@redhat.com> <17157.1537542475@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Miklos Szeredi , Al Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] fsmount: do not use legacy MS_ flags MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8491.1537544247.1@warthog.procyon.org.uk> Date: Fri, 21 Sep 2018 16:37:27 +0100 Message-ID: <8492.1537544247@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 21 Sep 2018 15:37:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > Indeed. Also, shouldn't these include the propagation flags? I guess so, though I'd be tempted to put those in a separate set. Also, I'm not sure whether fsmount() should deal with prop flags or whether that should be something move_mount() needs to deal with (ie. does propagation need applying at the time of splicing, depending on the parent). David