Received: by 2002:ac0:a852:0:0:0:0:0 with SMTP id c18-v6csp10819ima; Fri, 21 Sep 2018 08:40:57 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbJEhLdRFC5EzoyKvdEvcrxHJjk/Fw2QhAbWob3feFZITSxopafYeLX1MpHYuVLGGidxyco X-Received: by 2002:a62:1f11:: with SMTP id f17-v6mr47077750pff.168.1537544457868; Fri, 21 Sep 2018 08:40:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537544457; cv=none; d=google.com; s=arc-20160816; b=0vCeJFvAA2+4iES9QGZlNlgJCSLrqHFuuCDARmWtEWlf4cL6IuHwc1nosH7IEAzs8l DonwRsc3HwbshWr4lCCwXux0b+tQWQ4qaGjXZ/yQN97fRStGQiuuRJGjN6wBbyCbEtS8 Nn/zjwVA9z7CsX30BfjzKcRYe9llZCh6jnh2kGWDae1kHm+l08ARWLXnF58QtZZKrhqS F9ytD+CCj86qQbmggOy3DMYNSUcrSocVDtFvOzLPTg8EE/SfzR6aDaVWz1mtMdjxCfDp CTckatIoXwcivtYY40Uxk4fjERtmkADfLG9dQUvwA14qOhbZC1vB7UZMMCIA0vsCp++6 qHww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to; bh=h2hAknPKdBRuWME4Jsg2SkX5of+XtpGwyZ7xjo9hJXM=; b=iWw59XQNnnks913FZdgbUazyGWhf9XxEwXzvts25eg3+BrcoUAFm3tolusat5Hk+V7 /6fWC3zriOO2TtWcELiiX69pJV0GVIfnpw8YfOpU0RHAObrjLevEULqOlXRQx5WGS9CB 0tNGzIDY5muMbhdO9EvGKVy939+LhfqtO3X2Jctlf6FxEqC45RDKAV+aPdICzvMA94Ae ZcfjQnUALscsbWofVaRWRRXzbr8SBqkp7dZFc/tWXk82zUFmHBxY8qpP0MIXl+zDIogk nrfJVOHuJnNw4Kj++reYq0vrghtE0q860V56UfZd1NbGoEUeVF0Kn6UDGXKNlo4Kdzbi xG3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e89-v6si29528866plb.361.2018.09.21.08.40.36; Fri, 21 Sep 2018 08:40:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390420AbeIUV13 (ORCPT + 99 others); Fri, 21 Sep 2018 17:27:29 -0400 Received: from ale.deltatee.com ([207.54.116.67]:44216 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbeIUV12 (ORCPT ); Fri, 21 Sep 2018 17:27:28 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1g3NV2-0007rl-Sk; Fri, 21 Sep 2018 09:37:45 -0600 To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?Q?Christian_K=c3=b6nig?= , Jens Axboe References: <20180913001156.4115-1-logang@deltatee.com> <20180913001156.4115-2-logang@deltatee.com> <20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com> <20180921130010.GE224714@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: Date: Fri, 21 Sep 2018 09:37:33 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180921130010.GE224714@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: axboe@kernel.dk, christian.koenig@amd.com, alex.williamson@redhat.com, benh@kernel.crashing.org, jglisse@redhat.com, dan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com, bhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com, hch@lst.de, sbates@raithlin.com, linux-block@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1 Subject: Re: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-09-21 7:00 AM, Bjorn Helgaas wrote: > On Thu, Sep 20, 2018 at 04:47:49PM -0600, Logan Gunthorpe wrote: >> On 2018-09-20 4:38 PM, Bjorn Helgaas wrote: >>>> +#define pr_fmt(fmt) "pci-p2pdma: " fmt >>> >>> Is pr_fmt() actually used anywhere? >> >> It's used in a Patch 4 to print errors in the configfs helpers. > > Ideally pr_fmt() would be added in the same patch that uses it, but > obviously pretty trivial. Hmm, well Christoph asked me to do it this way. ;) Logan