Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp25620imm; Fri, 21 Sep 2018 09:06:19 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZdw0a4HEgJz4DoCnRdprcAf750QDA6xG92/kw2uYaGkpJVkC6cXX+rxT4CQh6Z4+VaAQGL X-Received: by 2002:a17:902:8a90:: with SMTP id p16-v6mr45656524plo.106.1537545979655; Fri, 21 Sep 2018 09:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537545979; cv=none; d=google.com; s=arc-20160816; b=dsWrtyUEXiyoC6fxLXA4OqL+MGNTBbOkMi4wpAzCF7oU401qfSkpc5JPj6qYu0Fu+H Sw6WEEgAeDisd14yOUV8KZlgpYWgxBydoPdLcjcJK9Qt/DEIRjOEo8ahz2QRj8MkAGjl Q6aAbzpwsVgPLhW9ySyLHcEZw3EccHIK7GQyCoD52PMoGl1F5cD88z2BwrVo/5C9a5Oq 9PisMY4/bm/y/cQ8EHfWk3qxQ+HMtGD7O8G2DwLxgAf+Qsy+443xYA36VfQ+zzLMXOLm 0jtxWNGo22dlF55LzkbGFcKsyUeMYkfpAUOtaLUQqaJDrbM8C/kBCY88m7aSJQMXpylM obeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:organization:references :in-reply-to:date:cc:to:from:subject:message-id; bh=JTCEswepnhFoizHcNvARYSHi9kNdXvb6BVwphKFV954=; b=oUiVOGJ/T120Wdf68ysth2MJWHMH5ic9DPo8t5AtXL+17aX6YleXAtAwEyxjysS+Rl VBK5CfPOuVJhBmCH1kGgIzFCSynFJkALmk5F9qNtmZ1mDzefIfWZ1JF767z8uoHFzDl5 Di6HlOIuCKdQqS91C7H4dkoZD4e9LXss4/DxFLsvNrGsnopbHeJTcoMDddKzD3ejlDRK GJj76vH9EwlMljxPDUizyrV409XUAgMDPTlE5388DWe1LoNZ/+Q8crOzJwreBPL1BNBE PUSfN0MK4Tkc76rp4uRi+VsL1IW/5JzUf+jcMrBx0glZRCleXMpJ9kTGkAESTnDXfhFh v2ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v17-v6si28858912pfl.233.2018.09.21.09.05.53; Fri, 21 Sep 2018 09:06:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390604AbeIUVxK (ORCPT + 99 others); Fri, 21 Sep 2018 17:53:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728221AbeIUVxJ (ORCPT ); Fri, 21 Sep 2018 17:53:09 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B6868CD0; Fri, 21 Sep 2018 16:03:38 +0000 (UTC) Received: from haswell-e.nc.xsintricity.com (ovpn-112-17.rdu2.redhat.com [10.10.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2005317D39; Fri, 21 Sep 2018 16:03:36 +0000 (UTC) Message-ID: <5749e7cf632c43ffa87df5b2cdd7894581d24b66.camel@redhat.com> Subject: Re: [PATCH] RDMA/cxgb4: remove redundant null pointer check before kfree_skb From: Doug Ledford To: zhong jiang , swise@chelsio.com, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 21 Sep 2018 12:03:35 -0400 In-Reply-To: <1537437162-42846-1-git-send-email-zhongjiang@huawei.com> References: <1537437162-42846-1-git-send-email-zhongjiang@huawei.com> Organization: Red Hat, Inc. Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Zc6UhuEnTOyWw/hV62x6" Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 21 Sep 2018 16:03:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Zc6UhuEnTOyWw/hV62x6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-09-20 at 17:52 +0800, zhong jiang wrote: > kfree_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree_skb. >=20 > Signed-off-by: zhong jiang Applied to for-next, thanks. --=20 Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint =3D AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD --=-Zc6UhuEnTOyWw/hV62x6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAlulFlcACgkQuCajMw5X L93Mxg/+I76BAUtGBcxHED4JOlZPYkanNxkxMR9U1OQeBdIMDqsoPL4FSxZrHnkf t2XBgO9QJEnnaBtO2G8AqMasykwFyRX+ZDL55ieUjENAeCnWseGg8l5FZk/Ydq9u olpz5TUdDhE8MzGjPlQwCQCtNBmXY4e/RjdkO1ucwrlv0eEJzksa9sB8rCz6gAGE 5ZK0/5d2AXrcH226o1jjpWxlflqv/g2qLmgiV4dIS/ZFzOYtBWFtnd6iBFaleG1d F2aMIcd78vSifEmCpXR53HIf7fjhxt8IQKr1HO1cc7w+ZdV8h7oaw6P46hzOXT4d hBpzSqoQFagzNwXlFuXMUbSwzsyiy9o+c26ZEwkDxATGSBbBbQrPM7NeZPnfSBze S12weyykz3gg1gWDbM6FxpmJuo3UvWF5s7lMuHjm65v7gyVoWVCi6SfKIEUhaGaC RQniZ6jm6nDTlrPhvRidL8isfyC26sgmZxX8rK4RVnuxkV5pBYf8I8gvTmTwPGsz ARgk6mX79X4blchsvCauM5B+vULZmCJY9SLOluYjll/PWOrUJM5Gre5KLUw3lQrJ 4b26g+PZJ8khUU6muWeuhw477rz4tr5Ajb9U9VLOafoll/G1LzgGHtKW5LX1dhAU 3o/tODd99WCXHMtfIxrBolN4kmlBiPzyRHOH4CLSx9yy4vIYAQw= =zPiP -----END PGP SIGNATURE----- --=-Zc6UhuEnTOyWw/hV62x6--