Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V5 0/6] perf and x86/intel_rdt: Fix lack of coordination
 with perf
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
        mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com,
        jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
References: <cover.1537377064.git.reinette.chatre@intel.com>
 <20180920141150.GY24124@hirez.programming.kicks-ass.net>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <77383a1e-f343-7529-24cf-874f0999507d@intel.com>
Date:   Fri, 21 Sep 2018 09:49:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180920141150.GY24124@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dear Maintainers,

On 9/20/2018 7:11 AM, Peter Zijlstra wrote:
> On Wed, Sep 19, 2018 at 10:29:05AM -0700, Reinette Chatre wrote:
>> Reinette Chatre (6):
>>   perf/core: Add sanity check to deal with pinned event failure
>>   perf/x86: Add helper to obtain performance counter index
>>   x86/intel_rdt: Remove local register variables
>>   x86/intel_rdt: Create required perf event attributes
>>   x86/intel_rdt: Use perf infrastructure for measurements
>>   x86/intel_rdt: Re-enable pseudo-lock measurements
>>
>>  Documentation/x86/intel_rdt_ui.txt          |  22 +-
>>  arch/x86/events/core.c                      |  21 ++
>>  arch/x86/include/asm/perf_event.h           |   1 +
>>  arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c | 372 ++++++++++++--------
>>  kernel/events/core.c                        |   6 +
>>  5 files changed, 261 insertions(+), 161 deletions(-)
> 
> Yeah, these look good, thanks!
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> 

Could you please consider this series for inclusion into v4.19?

- This series is needed to complete the initial cache pseudo-locking
enabling that is first introduced in v4.19. Without this series users
are able to create pseudo-locked regions but unable to accurately
measure their success.
- This is not adding a new feature of pseudo-locked region measurement
but fixing the existing measurement code that was disabled after found
to be poorly integrated.
- This series consists out of 6 patches. Patches 2 to 6 are either new
code in support of this fix or fixes to code that does not exist in
kernels before v4.19.
- Patch 1 is a fix to existing code. It is small, was suggested by, and
does have support from maintainer. Even so, if it is felt that this is
too risky then patches 2 to 6 could still be merged since it does not
actually depend on patch 1. In retrospect I should have submitted it
separately.

Your consideration would be greatly appreciated.

Thank you

Reinette