Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp58227imm; Fri, 21 Sep 2018 10:15:23 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdao0CJ4swR+SkgS3FjbHSEBLSCSRw4PEs/ukVrf6PwllCVAUISvPTnVha4dLS1Z3NMKqQvJ X-Received: by 2002:a63:f51:: with SMTP id 17-v6mr15110762pgp.100.1537550123832; Fri, 21 Sep 2018 10:15:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537550123; cv=none; d=google.com; s=arc-20160816; b=HpMQ06LfApYGuk5a8PsMY/46opmrhWJXwSuE+7qDNKHPUM+TSrnl17sY25BAkKMtI9 EHgEmU54uSyYR2HO6FfkE09oAd0jDisVdWOIDwltgYTtX+OyrG2A8xes/mIU1EXCbEIo 8Mfh0RL1t2BNL+3hKegDbgNJQiKNO9FDrddEompWa/mITNFEZs0yEl22MektB4Af0Mh2 0o4MgwhTm+XHD2ULK5teQV4YOk0iWuY2JThHm+Rq5dUJICQtNw0t/x85wyanwtuyv6ye otYzzvVE8KMeJGC+tAvYsaKX34oW4D8GGpm8HfafOWu9KuRYq9J76N01ARH7qnQRn3LT h85w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature:dkim-signature; bh=tx29VwiXiyGw+IbFWvIipwve3XqsfdKS0j167KfILrY=; b=KBtp3ExrqjRFquKz7Vz8mpGC4Y+3NGG7MRa6eavglVKRHOKNJvNGzApDYZNjkuezlY CL47VjEbYpwaSQhqfltpC2XSg7QhrNXCouAEOzmN35mTOYDqn1e3McfTHSWIaqo81Doa r1TbqQ5O8AZWYN7wuN8dtY/2ixXjYedK1CyaezrRTAvqzQFv3DsLBJOCTvHew1n3NHqs 2JxpRRBhi2BD8HjboCrP6KVT68efhoxed87CmzGmKMNLqNKyLj5zyj8PEOmRqk7riAzX 04PRO8efh30SjwJafuyU73wNjW2WQL3y5wvC5HGXCIR3YxvUbMZGA98MLxSXChyzpYGC jcfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=KgkIeXCA; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-com header.b=MkjGZdnv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3-v6si4689798plt.278.2018.09.21.10.15.07; Fri, 21 Sep 2018 10:15:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=KgkIeXCA; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-com header.b=MkjGZdnv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390800AbeIUXE2 (ORCPT + 99 others); Fri, 21 Sep 2018 19:04:28 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:40870 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390693AbeIUXE1 (ORCPT ); Fri, 21 Sep 2018 19:04:27 -0400 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8LH8jq7025307; Fri, 21 Sep 2018 10:14:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=facebook; bh=tx29VwiXiyGw+IbFWvIipwve3XqsfdKS0j167KfILrY=; b=KgkIeXCA1JoxshelPwsxkbr+dfpbzqVRp1JHLVMHsDEykcnkIZof58xny/UcaRtzcL3y B+ToUXInVueafRDOiviVEAcQP6YdZsnCzey9kkYMiFDOfk30mujX87ygkL0ueRRsImhO BNXCrBJTqsfgcYQIcqfKwl4M7fFLH9UZNt4= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 2mn27brkv8-8 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 21 Sep 2018 10:14:15 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.24) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 21 Sep 2018 10:14:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tx29VwiXiyGw+IbFWvIipwve3XqsfdKS0j167KfILrY=; b=MkjGZdnviv6BHYCreioJK451XzvKvmTezJVlujbZ7yfJ+7clL+MZuZzbKA868XNjm/BhWekEEwsmOcRizEJrQIj6CK4CQLoJqs26UlEBhiS+PPdV6aZP0QuOjj9FE+2fG8PmVn9m2p+AgDnEP25tZP9swf6JtlPOzSI1qzPlgZg= Received: from BY2PR15MB0167.namprd15.prod.outlook.com (10.163.64.141) by BY2PR15MB0232.namprd15.prod.outlook.com (10.163.64.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Fri, 21 Sep 2018 17:14:09 +0000 Received: from BY2PR15MB0167.namprd15.prod.outlook.com ([fe80::5c5b:75ea:cae:1e68]) by BY2PR15MB0167.namprd15.prod.outlook.com ([fe80::5c5b:75ea:cae:1e68%2]) with mapi id 15.20.1143.017; Fri, 21 Sep 2018 17:14:09 +0000 From: Roman Gushchin To: "netdev@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , Kernel Team , Roman Gushchin , Daniel Borkmann , Alexei Starovoitov Subject: [PATCH bpf-next 3/9] bpf: introduce per-cpu cgroup local storage Thread-Topic: [PATCH bpf-next 3/9] bpf: introduce per-cpu cgroup local storage Thread-Index: AQHUUc6CT+SkXy2egkmOS3SgZfTeOg== Date: Fri, 21 Sep 2018 17:14:09 +0000 Message-ID: <20180921171353.11050-3-guro@fb.com> References: <20180921171353.11050-1-guro@fb.com> In-Reply-To: <20180921171353.11050-1-guro@fb.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR10CA0052.namprd10.prod.outlook.com (2603:10b6:300:2c::14) To BY2PR15MB0167.namprd15.prod.outlook.com (2a01:111:e400:58e0::13) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2620:10d:c090:200::7:15ea] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR15MB0232;20:VheWn+GcQuukiDZ6veHtK6YUeTTMd2X0f2zZUdM7UJkwMo0VuWwc/n3ugIT/pDmGw6+RJe0C8q3oOg0Q57Dm9NNmO1jIeuEyyMatqISsm/APPqqBJGHcB9VxEUpRw7oRkN2Wov7+k00pfNYDyUgQoTGXRrOPXQB7WLWKdx8hMuM= x-ms-office365-filtering-correlation-id: e013f1b9-d7b2-49bd-83ed-08d61fe5a4b5 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:BY2PR15MB0232; x-ms-traffictypediagnostic: BY2PR15MB0232: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(67672495146484); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823302057)(3231355)(11241501184)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201708071742011)(7699051);SRVR:BY2PR15MB0232;BCL:0;PCL:0;RULEID:;SRVR:BY2PR15MB0232; x-forefront-prvs: 0802ADD973 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(39860400002)(376002)(136003)(396003)(366004)(199004)(189003)(386003)(5640700003)(14444005)(186003)(86362001)(486006)(6512007)(36756003)(99286004)(256004)(6436002)(6486002)(5250100002)(54906003)(6916009)(71200400001)(71190400001)(2900100001)(476003)(11346002)(76176011)(575784001)(102836004)(2616005)(52116002)(8676002)(46003)(81166006)(305945005)(6506007)(106356001)(25786009)(2351001)(5660300001)(6116002)(97736004)(81156014)(53936002)(316002)(2906002)(4326008)(446003)(1730700003)(1076002)(478600001)(7736002)(68736007)(2501003)(105586002)(8936002)(14454004)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR15MB0232;H:BY2PR15MB0167.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: c1ckiMUvwvysSUWkDOVWC71AK/gZQtcOv2WbXgIQxSMAwll3T1/6jawWToCcSGBpGs5U0WBYHlOXsCmrmefH0N6MpQRYLOB8M1TBz4GQC1DmXgYLwxMTG32uBUVQht0eD/J6avHW0u5RUzWW7EVg7tzvxTBm18BM+ensMaZZx8Nq2dHfbmGpcPRcyR/E1yl7CHOufnjx646D7wArS8Ib68V2/4zdM6ybCgnSnBjdcjWzcKQYwRyTa5HgYWa7Lc2F0p4z6//R62mTXl5q/bumPQxUkTWMwD0Tm7A1/ZwEjpwdAULHVZa4D91eaNs5QkqUrCRDw3l7sbpXg8tpatn6gGoH/g+9ZAhGzz/ksorXf5U= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e013f1b9-d7b2-49bd-83ed-08d61fe5a4b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2018 17:14:09.8335 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR15MB0232 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-21_07:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This commit introduced per-cpu cgroup local storage. Per-cpu cgroup local storage is very similar to simple cgroup storage (let's call it shared), except all the data is per-cpu. The main goal of per-cpu variant is to implement super fast counters (e.g. packet counters), which don't require neither lookups, neither atomic operations. From userspace's point of view, accessing a per-cpu cgroup storage is similar to other per-cpu map types (e.g. per-cpu hashmaps and arrays). Writing to a per-cpu cgroup storage is not atomic, but is performed by copying longs, so some minimal atomicity is here, exactly as with other per-cpu maps. Signed-off-by: Roman Gushchin Cc: Daniel Borkmann Cc: Alexei Starovoitov --- include/linux/bpf-cgroup.h | 20 ++++- include/linux/bpf.h | 1 + include/linux/bpf_types.h | 1 + include/uapi/linux/bpf.h | 1 + kernel/bpf/helpers.c | 8 +- kernel/bpf/local_storage.c | 148 ++++++++++++++++++++++++++++++++----- kernel/bpf/syscall.c | 11 ++- kernel/bpf/verifier.c | 15 +++- 8 files changed, 177 insertions(+), 28 deletions(-) diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h index 7e0c9a1d48b7..9bd907657f9b 100644 --- a/include/linux/bpf-cgroup.h +++ b/include/linux/bpf-cgroup.h @@ -37,7 +37,10 @@ struct bpf_storage_buffer { }; =20 struct bpf_cgroup_storage { - struct bpf_storage_buffer *buf; + union { + struct bpf_storage_buffer *buf; + char __percpu *percpu_buf; + }; struct bpf_cgroup_storage_map *map; struct bpf_cgroup_storage_key key; struct list_head list; @@ -109,6 +112,9 @@ int __cgroup_bpf_check_dev_permission(short dev_type, u= 32 major, u32 minor, static inline enum bpf_cgroup_storage_type cgroup_storage_type( struct bpf_map *map) { + if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) + return BPF_CGROUP_STORAGE_PERCPU; + return BPF_CGROUP_STORAGE_SHARED; } =20 @@ -131,6 +137,10 @@ void bpf_cgroup_storage_unlink(struct bpf_cgroup_stora= ge *storage); int bpf_cgroup_storage_assign(struct bpf_prog *prog, struct bpf_map *map); void bpf_cgroup_storage_release(struct bpf_prog *prog, struct bpf_map *map= ); =20 +int bpf_percpu_cgroup_storage_copy(struct bpf_map *map, void *key, void *v= alue); +int bpf_percpu_cgroup_storage_update(struct bpf_map *map, void *key, + void *value, u64 flags); + /* Wrappers for __cgroup_bpf_run_filter_skb() guarded by cgroup_bpf_enable= d. */ #define BPF_CGROUP_RUN_PROG_INET_INGRESS(sk, skb) \ ({ \ @@ -285,6 +295,14 @@ static inline struct bpf_cgroup_storage *bpf_cgroup_st= orage_alloc( struct bpf_prog *prog, enum bpf_cgroup_storage_type stype) { return 0; } static inline void bpf_cgroup_storage_free( struct bpf_cgroup_storage *storage) {} +static inline int bpf_percpu_cgroup_storage_copy(struct bpf_map *map, void= *key, + void *value) { + return 0; +} +static inline int bpf_percpu_cgroup_storage_update(struct bpf_map *map, + void *key, void *value, u64 flags) { + return 0; +} =20 #define cgroup_bpf_enabled (0) #define BPF_CGROUP_PRE_CONNECT_ENABLED(sk) (0) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index b457fbe7b70b..018299a595c8 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -274,6 +274,7 @@ struct bpf_prog_offload { =20 enum bpf_cgroup_storage_type { BPF_CGROUP_STORAGE_SHARED, + BPF_CGROUP_STORAGE_PERCPU, __BPF_CGROUP_STORAGE_MAX }; =20 diff --git a/include/linux/bpf_types.h b/include/linux/bpf_types.h index c9bd6fb765b0..5432f4c9f50e 100644 --- a/include/linux/bpf_types.h +++ b/include/linux/bpf_types.h @@ -43,6 +43,7 @@ BPF_MAP_TYPE(BPF_MAP_TYPE_CGROUP_ARRAY, cgroup_array_map_= ops) #endif #ifdef CONFIG_CGROUP_BPF BPF_MAP_TYPE(BPF_MAP_TYPE_CGROUP_STORAGE, cgroup_storage_map_ops) +BPF_MAP_TYPE(BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE, cgroup_storage_map_ops) #endif BPF_MAP_TYPE(BPF_MAP_TYPE_HASH, htab_map_ops) BPF_MAP_TYPE(BPF_MAP_TYPE_PERCPU_HASH, htab_percpu_map_ops) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index aa5ccd2385ed..e2070d819e04 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -127,6 +127,7 @@ enum bpf_map_type { BPF_MAP_TYPE_SOCKHASH, BPF_MAP_TYPE_CGROUP_STORAGE, BPF_MAP_TYPE_REUSEPORT_SOCKARRAY, + BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE, }; =20 enum bpf_prog_type { diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index e42f8789b7ea..1f21ef1c4ad3 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -206,10 +206,16 @@ BPF_CALL_2(bpf_get_local_storage, struct bpf_map *, m= ap, u64, flags) */ enum bpf_cgroup_storage_type stype =3D cgroup_storage_type(map); struct bpf_cgroup_storage *storage; + void *ptr =3D NULL; =20 storage =3D this_cpu_read(bpf_cgroup_storage[stype]); =20 - return (unsigned long)&READ_ONCE(storage->buf)->data[0]; + if (stype =3D=3D BPF_CGROUP_STORAGE_SHARED) + ptr =3D &READ_ONCE(storage->buf)->data[0]; + else + ptr =3D this_cpu_ptr(storage->percpu_buf); + + return (unsigned long)ptr; } =20 const struct bpf_func_proto bpf_get_local_storage_proto =3D { diff --git a/kernel/bpf/local_storage.c b/kernel/bpf/local_storage.c index 6742292fb39e..d991355b5b46 100644 --- a/kernel/bpf/local_storage.c +++ b/kernel/bpf/local_storage.c @@ -152,6 +152,71 @@ static int cgroup_storage_update_elem(struct bpf_map *= map, void *_key, return 0; } =20 +int bpf_percpu_cgroup_storage_copy(struct bpf_map *_map, void *_key, + void *value) +{ + struct bpf_cgroup_storage_map *map =3D map_to_storage(_map); + struct bpf_cgroup_storage_key *key =3D _key; + struct bpf_cgroup_storage *storage; + int cpu, off =3D 0; + u32 size; + + rcu_read_lock(); + storage =3D cgroup_storage_lookup(map, key, false); + if (!storage) { + rcu_read_unlock(); + return -ENOENT; + } + + /* per_cpu areas are zero-filled and bpf programs can only + * access 'value_size' of them, so copying rounded areas + * will not leak any kernel data + */ + size =3D round_up(_map->value_size, 8); + for_each_possible_cpu(cpu) { + bpf_long_memcpy(value + off, + per_cpu_ptr(storage->percpu_buf, cpu), size); + off +=3D size; + } + rcu_read_unlock(); + return 0; +} + +int bpf_percpu_cgroup_storage_update(struct bpf_map *_map, void *_key, + void *value, u64 map_flags) +{ + struct bpf_cgroup_storage_map *map =3D map_to_storage(_map); + struct bpf_cgroup_storage_key *key =3D _key; + struct bpf_cgroup_storage *storage; + int cpu, off =3D 0; + u32 size; + + if (unlikely(map_flags & BPF_EXIST)) + return -EINVAL; + + rcu_read_lock(); + storage =3D cgroup_storage_lookup(map, key, false); + if (!storage) { + rcu_read_unlock(); + return -ENOENT; + } + + /* the user space will provide round_up(value_size, 8) bytes that + * will be copied into per-cpu area. bpf programs can only access + * value_size of it. During lookup the same extra bytes will be + * returned or zeros which were zero-filled by percpu_alloc, + * so no kernel data leaks possible + */ + size =3D round_up(_map->value_size, 8); + for_each_possible_cpu(cpu) { + bpf_long_memcpy(per_cpu_ptr(storage->percpu_buf, cpu), + value + off, size); + off +=3D size; + } + rcu_read_unlock(); + return 0; +} + static int cgroup_storage_get_next_key(struct bpf_map *_map, void *_key, void *_next_key) { @@ -292,55 +357,98 @@ struct bpf_cgroup_storage *bpf_cgroup_storage_alloc(s= truct bpf_prog *prog, { struct bpf_cgroup_storage *storage; struct bpf_map *map; + gfp_t flags; + size_t size; u32 pages; =20 map =3D prog->aux->cgroup_storage[stype]; if (!map) return NULL; =20 - pages =3D round_up(sizeof(struct bpf_cgroup_storage) + - sizeof(struct bpf_storage_buffer) + - map->value_size, PAGE_SIZE) >> PAGE_SHIFT; + if (stype =3D=3D BPF_CGROUP_STORAGE_SHARED) { + size =3D sizeof(struct bpf_storage_buffer) + map->value_size; + pages =3D round_up(sizeof(struct bpf_cgroup_storage) + size, + PAGE_SIZE) >> PAGE_SHIFT; + } else { + size =3D map->value_size; + pages =3D round_up(round_up(size, 8) * num_possible_cpus(), + PAGE_SIZE) >> PAGE_SHIFT; + } + if (bpf_map_charge_memlock(map, pages)) return ERR_PTR(-EPERM); =20 storage =3D kmalloc_node(sizeof(struct bpf_cgroup_storage), __GFP_ZERO | GFP_USER, map->numa_node); - if (!storage) { - bpf_map_uncharge_memlock(map, pages); - return ERR_PTR(-ENOMEM); - } + if (!storage) + goto enomem; =20 - storage->buf =3D kmalloc_node(sizeof(struct bpf_storage_buffer) + - map->value_size, __GFP_ZERO | GFP_USER, - map->numa_node); - if (!storage->buf) { - bpf_map_uncharge_memlock(map, pages); - kfree(storage); - return ERR_PTR(-ENOMEM); + flags =3D __GFP_ZERO | GFP_USER; + + if (stype =3D=3D BPF_CGROUP_STORAGE_SHARED) { + storage->buf =3D kmalloc_node(size, flags, map->numa_node); + if (!storage->buf) + goto enomem; + } else { + storage->percpu_buf =3D __alloc_percpu_gfp(size, 8, flags); + if (!storage->percpu_buf) + goto enomem; } =20 storage->map =3D (struct bpf_cgroup_storage_map *)map; =20 return storage; + +enomem: + bpf_map_uncharge_memlock(map, pages); + kfree(storage); + return ERR_PTR(-ENOMEM); +} + +static void free_cgroup_storage_rcu(struct rcu_head *rcu) +{ + struct bpf_cgroup_storage *storage =3D + container_of(rcu, struct bpf_cgroup_storage, rcu); + + kfree(storage->buf); + kfree(storage); +} + +static void free_percpu_cgroup_storage_rcu(struct rcu_head *rcu) +{ + struct bpf_cgroup_storage *storage =3D + container_of(rcu, struct bpf_cgroup_storage, rcu); + + free_percpu(storage->percpu_buf); + kfree(storage); } =20 void bpf_cgroup_storage_free(struct bpf_cgroup_storage *storage) { - u32 pages; + enum bpf_cgroup_storage_type stype; struct bpf_map *map; + u32 pages; =20 if (!storage) return; =20 map =3D &storage->map->map; - pages =3D round_up(sizeof(struct bpf_cgroup_storage) + - sizeof(struct bpf_storage_buffer) + - map->value_size, PAGE_SIZE) >> PAGE_SHIFT; + stype =3D cgroup_storage_type(map); + if (stype =3D=3D BPF_CGROUP_STORAGE_SHARED) + pages =3D round_up(sizeof(struct bpf_cgroup_storage) + + sizeof(struct bpf_storage_buffer) + + map->value_size, PAGE_SIZE) >> PAGE_SHIFT; + else + pages =3D round_up(round_up(map->value_size, 8) * + num_possible_cpus(), + PAGE_SIZE) >> PAGE_SHIFT; + bpf_map_uncharge_memlock(map, pages); =20 - kfree_rcu(storage->buf, rcu); - kfree_rcu(storage, rcu); + if (stype =3D=3D BPF_CGROUP_STORAGE_SHARED) + call_rcu(&storage->rcu, free_cgroup_storage_rcu); + else + call_rcu(&storage->rcu, free_percpu_cgroup_storage_rcu); } =20 void bpf_cgroup_storage_link(struct bpf_cgroup_storage *storage, diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 8c91d2b41b1e..5742df21598c 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -686,7 +686,8 @@ static int map_lookup_elem(union bpf_attr *attr) =20 if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_HASH || map->map_type =3D=3D BPF_MAP_TYPE_LRU_PERCPU_HASH || - map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY) + map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY || + map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) value_size =3D round_up(map->value_size, 8) * num_possible_cpus(); else if (IS_FD_MAP(map)) value_size =3D sizeof(u32); @@ -705,6 +706,8 @@ static int map_lookup_elem(union bpf_attr *attr) err =3D bpf_percpu_hash_copy(map, key, value); } else if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY) { err =3D bpf_percpu_array_copy(map, key, value); + } else if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) { + err =3D bpf_percpu_cgroup_storage_copy(map, key, value); } else if (map->map_type =3D=3D BPF_MAP_TYPE_STACK_TRACE) { err =3D bpf_stackmap_copy(map, key, value); } else if (IS_FD_ARRAY(map)) { @@ -774,7 +777,8 @@ static int map_update_elem(union bpf_attr *attr) =20 if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_HASH || map->map_type =3D=3D BPF_MAP_TYPE_LRU_PERCPU_HASH || - map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY) + map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY || + map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) value_size =3D round_up(map->value_size, 8) * num_possible_cpus(); else value_size =3D map->value_size; @@ -809,6 +813,9 @@ static int map_update_elem(union bpf_attr *attr) err =3D bpf_percpu_hash_update(map, key, value, attr->flags); } else if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY) { err =3D bpf_percpu_array_update(map, key, value, attr->flags); + } else if (map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) { + err =3D bpf_percpu_cgroup_storage_update(map, key, value, + attr->flags); } else if (IS_FD_ARRAY(map)) { rcu_read_lock(); err =3D bpf_fd_array_map_update_elem(map, f.file, key, value, diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index e75f36de91d6..d94073deb68a 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -2074,6 +2074,7 @@ static int check_map_func_compatibility(struct bpf_ve= rifier_env *env, goto error; break; case BPF_MAP_TYPE_CGROUP_STORAGE: + case BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE: if (func_id !=3D BPF_FUNC_get_local_storage) goto error; break; @@ -2164,7 +2165,8 @@ static int check_map_func_compatibility(struct bpf_ve= rifier_env *env, goto error; break; case BPF_FUNC_get_local_storage: - if (map->map_type !=3D BPF_MAP_TYPE_CGROUP_STORAGE) + if (map->map_type !=3D BPF_MAP_TYPE_CGROUP_STORAGE && + map->map_type !=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) goto error; break; case BPF_FUNC_sk_select_reuseport: @@ -5049,6 +5051,12 @@ static int check_map_prog_compatibility(struct bpf_v= erifier_env *env, return 0; } =20 +static bool bpf_map_is_cgroup_storage(struct bpf_map *map) +{ + return (map->map_type =3D=3D BPF_MAP_TYPE_CGROUP_STORAGE || + map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE); +} + /* look for pseudo eBPF instructions that access map FDs and * replace them with actual map pointers */ @@ -5139,10 +5147,9 @@ static int replace_map_fd_with_map_ptr(struct bpf_ve= rifier_env *env) } env->used_maps[env->used_map_cnt++] =3D map; =20 - if (map->map_type =3D=3D BPF_MAP_TYPE_CGROUP_STORAGE && + if (bpf_map_is_cgroup_storage(map) && bpf_cgroup_storage_assign(env->prog, map)) { - verbose(env, - "only one cgroup storage is allowed\n"); + verbose(env, "only one cgroup storage of each type is allowed\n"); fdput(f); return -EBUSY; } --=20 2.17.1