Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 21 Sep 2018 11:36:39 -0700
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Haiyang Zhang <haiyangz@linuxonhyperv.com>
Cc:     haiyangz@microsoft.com, davem@davemloft.net,
        netdev@vger.kernel.org, olaf@aepfle.de,
        linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
        vkuznets@redhat.com
Subject: Re: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in
 the vSwitch
Message-ID: <20180921113620.62a004cb@xeon-e3>
In-Reply-To: <20180921182037.10077-2-haiyangz@linuxonhyperv.com>
References: <20180921182037.10077-1-haiyangz@linuxonhyperv.com>
        <20180921182037.10077-2-haiyangz@linuxonhyperv.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 21 Sep 2018 18:20:35 +0000
Haiyang Zhang <haiyangz@linuxonhyperv.com> wrote:

Overall, this looks good. Some minor suggestions.

> +struct nvsc_rsc {
> +	const struct ndis_pkt_8021q_info *vlan;
> +	const struct ndis_tcp_ip_checksum_info *csum_info;
> +	u8 is_last; /* last RNDIS msg in a vmtransfer_page */
> +	u32 cnt; /* #fragments in an RSC packet */
> +	u32 pktlen; /* Full packet length */
> +	void *data[NVSP_RSC_MAX];
> +	u32 len[NVSP_RSC_MAX];
> +};
> +

This new state structure is state on a per-channel basis.
Do you really need this to be persistent across packets?

Could this be on stack or do you need it to handle split packets
arriving in different polls? Or is the stack space a problem?

Also, maybe data and length could be in one structure since they
are related.