Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp214082imm; Fri, 21 Sep 2018 13:02:23 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda43bwm3S4KahbSpyUO1WhcEdUj7uTEABY35e6YiSSIw/K5l82Ano1YCrN41Nsi6wNeBrbE X-Received: by 2002:a17:902:6b44:: with SMTP id g4-v6mr46232401plt.50.1537560143817; Fri, 21 Sep 2018 13:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537560143; cv=none; d=google.com; s=arc-20160816; b=iHldzI6nPYVlIB/tD5hvS+oFQSS9GqqqpOPEsHCII0AU06OKSnrVlrlkmLMUkugt2w nu+QUDamq/VKXEpa+nT5LfAc0hG9LwEx7xx51Ow0Q5qpOl3Q4cdoF2FPaSxyYvi6vOBf wQqYM1K9jvBSE5GCjbvf4KHhMvqo4Nklo2yP4eCi/LckbW1IBy5a6GEaxtZgvl+IQlIa NEWYA+A+1uXvtLdpRUuAfeZ6U2+qIqzDw+ptnqdXZj3vw8TzHZ9/ZyUJNGgVYLH4iX0T ZKyGH9I8IZvsDWu/PKB9fxjtHcXE7vTgxs/cyRgAwmg9qgwsLAo6iLH40/CD926dOUp9 N7lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to; bh=bLU7OZhSabVagWHJzMMf6qAJnB97hV3LnTMwnKJ7aPw=; b=RKaT9L+3rxDVnkXP36Cg6enDc5Kxw9byGQDOWqRlPZIpOnSz2X5jUAaqWbpB4mqMfv odGL0pwMQz0w/fOmKnoKDcd+2udypkgwYp6LC3sSFz+Ur/8+JBl6oB1Axrpy6JUm/nme 4zy1pdHZVApjI5YI5jVbrDc1fXREhbJVCyGh6uL2eqExqDw7as8QygBmbCbsLCKaPLDM j7TixColuYk9InQwO7HCS5bCVZhVIhZspFTHllvnxYCG+ITr3nFtjtFs7syKzyzhfx26 Qk2KyZUWZnSOh0D9q738eaZ4fXiCX6n83rPkXIdsL5E67JHOuCHKKWQT5j8VyX+tkSSv etgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p13-v6si2230681pli.395.2018.09.21.13.02.08; Fri, 21 Sep 2018 13:02:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391573AbeIVBvs (ORCPT + 99 others); Fri, 21 Sep 2018 21:51:48 -0400 Received: from ale.deltatee.com ([207.54.116.67]:46062 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391089AbeIVBvs (ORCPT ); Fri, 21 Sep 2018 21:51:48 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1g3Rc4-0002NV-UB; Fri, 21 Sep 2018 14:01:17 -0600 To: Bjorn Helgaas Cc: Jens Axboe , Keith Busch , Alex Williamson , Sagi Grimberg , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Dan Williams , Christoph Hellwig References: <20180913001156.4115-1-logang@deltatee.com> <20180913001156.4115-4-logang@deltatee.com> <20180921131550.GG224714@bhelgaas-glaptop.roam.corp.google.com> <20180921164813.GJ224714@bhelgaas-glaptop.roam.corp.google.com> <506dd00c-35e9-e285-bc97-c689c766b4cf@deltatee.com> <20180921200021.GN224714@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: Date: Fri, 21 Sep 2018 14:01:13 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180921200021.GN224714@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: hch@lst.de, dan.j.williams@intel.com, maxg@mellanox.com, bhelgaas@google.com, benh@kernel.crashing.org, christian.koenig@amd.com, jgg@mellanox.com, jglisse@redhat.com, linux-block@vger.kernel.org, sbates@raithlin.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, sagi@grimberg.me, alex.williamson@redhat.com, keith.busch@intel.com, axboe@kernel.dk, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1 Subject: Re: [PATCH v6 03/13] PCI/P2PDMA: Add PCI p2pmem DMA mappings to adjust the bus offset X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-09-21 2:00 PM, Bjorn Helgaas wrote: > Ok. I was assuming s->dma_address would have been already set before > the call and would be overwritten by pci_p2pmem_map_sg(). But I guess > that's not the case -- sounds like s->dma_address is undefined before > the call. Correct. It's set by whatever dma_map function operates on it. Logan