Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp43858imm; Fri, 21 Sep 2018 17:47:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV63b9e7vHItNO3HbSF+SdX3CLlJAqZb3Lx2+pIb6HweuuECmt6b88Dl3DWueMwJ1lOjYoSK9 X-Received: by 2002:a63:1021:: with SMTP id f33-v6mr189914pgl.72.1537577276843; Fri, 21 Sep 2018 17:47:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537577276; cv=none; d=google.com; s=arc-20160816; b=fikXpHFAys9/2tIT89oyf08JQLuYhW1fqrNLd10kNy9utgajGJpbTy3TVt66Id/FTA 1b110pP0a75+j4i/A18VX6azgQpOTlGVO9vJ9rKO58XB2FHXrH8qErohpIaNKVsfHCZO KLah10FFw0ai1fY8CTXDqhQ4xUzffls17I6o7YsCoGEHnAVqDshpAltiIu9hfnI50YRL 2aeBeqy8NxlF5KpIFvq8fRh7fSHx39HkEZG7goZ+8JGeWCSoMfaRtvCqEiqYVRgtmTEw VBjcRXTlbxGKJZIz73kFJRxvmTLisVDgcGs8bGMgBRKKIRRczEejxAb4TNaDmJIZxDiu 8/8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=thMTjBYg+6WKqkYaoBm2zaWnrXuykg/WL3BhAPijcYA=; b=aChrav2VCt8QK/yy4gtAnvefQGE4dNHtzn4VNH4Dn91i2bofzegkQqMYn7sxDv47YM 0lTu9/XU4lUtDWb9seb8SWVmW4ZIHl8UiahwSusz6zTXjLbTZ52b7ikmwnURa8KQb4jk EH9w+wH7YOfWyuf7ulKoIf6FMGF+0K1vjuXH7F9+Z0xhSIjReShuflAhSW9j//yCoy7T F7LOwKA5pWRc1cu+l8VRPuxmIiY40euGe7wksJfsc22+Kcm3s02dnbnnMsS74FTR8KhD mFw6+QAyJPPwWJ60MPQwrxIPslSkKNy+pLbyxjOIf8dWR9zj6MlZxn1TPIBS7py7Ifiz 00ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=cbjiuR6u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p33-v6si29712579pld.151.2018.09.21.17.47.40; Fri, 21 Sep 2018 17:47:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=cbjiuR6u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391710AbeIVGip (ORCPT + 99 others); Sat, 22 Sep 2018 02:38:45 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:43081 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbeIVGip (ORCPT ); Sat, 22 Sep 2018 02:38:45 -0400 Received: by mail-ot1-f68.google.com with SMTP id e21-v6so1995039otk.10 for ; Fri, 21 Sep 2018 17:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=thMTjBYg+6WKqkYaoBm2zaWnrXuykg/WL3BhAPijcYA=; b=cbjiuR6un8rT2QPtyvSgzjYrd5VxLQV1HelP79xTBohZuG2iHkdbabKyXAC3uVZDxj XKDrYhdxdzP27SP8o9CUceQwB7gH9G/LJuYOqX48bMI8XPhm4/sbg7d5V2Fx/xqpgIBC etyyFYsUaS8DIS8oJMSCtw+uiGnMsC1BXBwoOg6v0V+5MwaDvUp3BJ2IhD+wkGpUVU67 rUfKuHVId+5Od2qjCFlSthyoPc0HnjNpZ66XZx5uR9knM8XVpnM32uK5RDMXfeDF8mTR J6cgIMLp+Mr6Cj3OFNk9fu2jYKHsvruEJ8K8DI8Zg4Jiryi9xp8rSsgTbvswWhBmPtzp LNXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=thMTjBYg+6WKqkYaoBm2zaWnrXuykg/WL3BhAPijcYA=; b=t4XifJF7c7gwg00TP7arPQ4apa+V0nCd4jTER0GM7Ptx93aI7ietEuHNEZA/wwQfsa yxgEkZOlOHQ26xCGiKL/nY+DcpGCHw/pIfkSKExbcRZN1PO50A4V9vztjqevcVhsiwip FGEns7rdXKqp8ubGG4I2gvIzP0lDRVe04FsV+3r4WeQpC7B0GzM07y3Cr6K5s54XBkiF UefieSxVumqBWuQ/29Sh8mdYFU1G6wD6VLSdlajF+oZym/sp+TpkLG+W7GKfBPhC2pYH N5y8YczXaHl2eX/IsBJX3hTFvvHXsEQe+RoEwRP+iF4jtOoY6SJrPFA5QFAU2z0vOJRJ uIXg== X-Gm-Message-State: ABuFfoh6/3aXcHaMb/3xAuj1s/Pvzs9GyGEP8SgOmOlj0j2aH64joHGF yXkdbp+iXvzcR3H3+S+3oxjknhR+tv8odOiigKD+hg== X-Received: by 2002:a9d:7519:: with SMTP id r25-v6mr149182otk.73.1537577241614; Fri, 21 Sep 2018 17:47:21 -0700 (PDT) MIME-Version: 1.0 References: <20180831133019.27579-1-pagupta@redhat.com> <20180831133019.27579-2-pagupta@redhat.com> In-Reply-To: <20180831133019.27579-2-pagupta@redhat.com> From: Dan Williams Date: Fri, 21 Sep 2018 17:47:10 -0700 Message-ID: Subject: Re: [PATCH 1/3] nd: move nd_region to common header To: Pankaj Gupta Cc: Linux Kernel Mailing List , KVM list , Qemu Developers , linux-nvdimm , Jan Kara , Stefan Hajnoczi , Rik van Riel , Nitesh Narayan Lal , Kevin Wolf , Paolo Bonzini , "Zwisler, Ross" , David Hildenbrand , Xiao Guangrong , Christoph Hellwig , "Michael S. Tsirkin" , niteshnarayanlal@hotmail.com, lcapitulino@redhat.com, Igor Mammedov , Eric Blake Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 31, 2018 at 6:31 AM Pankaj Gupta wrote: > > This patch moves nd_region definition to common header > include/linux/nd.h file. This is required for flush callback > support for both virtio-pmem & pmem driver. > > Signed-off-by: Pankaj Gupta > --- > drivers/nvdimm/nd.h | 39 --------------------------------------- > include/linux/nd.h | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 39 deletions(-) No, we need to find a way to do this without dumping all of these internal details to a public / global header.