Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp58577imm; Fri, 21 Sep 2018 18:09:12 -0700 (PDT) X-Google-Smtp-Source: ACcGV625sSPS+D318fFWc27hKuu9uIhHjPiM2Gq41qKm1CYQB5sVhjGaqM1mhSzskISM6Mu+a1dK X-Received: by 2002:a17:902:7287:: with SMTP id d7-v6mr253533pll.54.1537578552367; Fri, 21 Sep 2018 18:09:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537578552; cv=none; d=google.com; s=arc-20160816; b=c7JlrMS6QQTwW38EynN3dhO/5hwpb7TcBIAKQwdtvCj0ywUAtrFj0Ei+zPr7knG4rM Ce8A11GvHEyuphV59Z0HE4Uj7rZhpraNLDhk2/RpddymV5mWWxzpUfL7bt9j+4CHusHM xRzxxMHyVPcjZtB3o6icnVcJgxUYS6qmRXaPKXSbW7aUsFKsBQ5pDJs0LcVaKRJGSKxM LH4YPyPmAKCVsO+Rxc9ME6YW45D8IJ0oOFzDsh31CsdQZqsK+iMiUDd3yTELEfmZAQid qNsF7VDN5cy+C2Gm5mWo3i0Mhv5iDeH5SptvCmLQ8Fhsztf9zcs/X3PuVTjrAmzYDJfP WblA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Mqq194q23icCOr9+yL3tTwgPQ01HCC0Me5eFbP/y5IU=; b=H7fIp+GSB7LRBFXEyJCpVHnjhcBaZX9EUS1aqi1YFxaiiblt99EIcQyDGjM7Wb4MmZ qf+GjZn6D9U/jG6bfaF7TIaLvZ54Xsnovrt+1uaC63CJxTxEv4596pnplYfNmlS6Tskp wQ1SchdtaolUtO1NUmOFShuuBIRXYnkdVyqz/29GyqOzU0Pjc5ao5CqVsthECkvMiLp/ KEuojtE2KG39+0vRHZmVQMgfhnV7xSRsl5zGshlIW7xzHyxJ254/b6GJ+5fTsKPT4rL7 6ZD5xPrQhYuO+UhI6wOrxBfHMq8SPlORYemnB/vb/1QjTD2wDtjtLbIxYMlqeZUa3JNo On7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7-v6si3971706pfi.147.2018.09.21.18.08.28; Fri, 21 Sep 2018 18:09:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391704AbeIVG7o (ORCPT + 99 others); Sat, 22 Sep 2018 02:59:44 -0400 Received: from www62.your-server.de ([213.133.104.62]:40561 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728318AbeIVG7m (ORCPT ); Sat, 22 Sep 2018 02:59:42 -0400 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1g3WP6-00025J-Jq; Sat, 22 Sep 2018 03:08:12 +0200 Received: from [178.197.248.13] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1g3WP6-0006J8-Db; Sat, 22 Sep 2018 03:08:12 +0200 Subject: Re: [PATCH] bpf: remove redundant null pointer check before consume_skb To: zhong jiang , ast@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1537436772-42545-1-git-send-email-zhongjiang@huawei.com> From: Daniel Borkmann Message-ID: <88373125-31a3-59ca-5bc7-72f6de0421ec@iogearbox.net> Date: Sat, 22 Sep 2018 03:08:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1537436772-42545-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.1/24968/Fri Sep 21 22:48:02 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2018 11:46 AM, zhong jiang wrote: > consume_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before consume_skb. > > Signed-off-by: zhong jiang Applied to bpf-next, thanks Zhong!