Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp116754imm; Fri, 21 Sep 2018 19:46:07 -0700 (PDT) X-Google-Smtp-Source: ACcGV60PPa2PI9aHmfmu6uUjW/kLhFcGk4WnRxOIl2PfKD7mvOoiZlV9lg4L8B0AijJin4XE3UVj X-Received: by 2002:a17:902:7803:: with SMTP id p3-v6mr442445pll.119.1537584367388; Fri, 21 Sep 2018 19:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537584367; cv=none; d=google.com; s=arc-20160816; b=Y1gXLPGR86kHB4DMsAAt4cbbyeiPwv9o/eMV6l1ODThTP3Eix7uScg/w3tkxes9XE9 kWErm4muo8u2wSMbaYNcBnX9RxeT10ytHMsibEBQZTNziUZSZi7xRhhlnpoy/AqYxBJX VinUi8kNr6Saw4JlnKqmSIqgylmxzQCAqtdpg/lBC+4bYPlN68ZQfp6+OoN6Shpv79Ld 6RF9ufBvImzwUao8YtfjSt1V9S23Ollpm8TsbOq83OhgIBabgFzIaqk/kpq+/RmDv/rE BDhYzQTdVWQh9g6drHjl+3R1oIOY/ldG3ugIYftq+eorGkQaTJg0ecIm71V92iNBuetl WEkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=yrRrYun0p1t9laLCKRji1sYubxXnqAmGv2Md1D0qHZg=; b=eZJEemfvzPS8qMyz/8pdTg6xCQWElqp8eYGVBY9PUqNYzR0VIq5OItqxm2Bya2/vV/ lY4ylUi8Y7JZi98xk7obRiYMqMbIqmZJaBpgrrlbH4/HvV2SKW1GpjYh18dDD1J5oZ3h 6zvAJmk9LkfMRfe1emgKjsFSAxKlnSe1C7YpRcxt/QgPZl5p2jBQhGBFdrs0QrwsRd9y 9KszHah9X4Courp7IG6wiJ+JZO7lsI+An6Z7biE8vwYsV3i/o3oNvr3y9Lx60uRuO4s6 H5DgQzQh82YCRoleFayaFIlpL+VcDFjjpAU3GQjGDq7pgB3I9ke3Pxc4lyF8L5Vx4/cV vAjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Y1/fCvwP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5-v6si27006980plv.304.2018.09.21.19.45.51; Fri, 21 Sep 2018 19:46:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Y1/fCvwP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbeIVIg1 (ORCPT + 99 others); Sat, 22 Sep 2018 04:36:27 -0400 Received: from mail-yw1-f65.google.com ([209.85.161.65]:34028 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbeIVIg0 (ORCPT ); Sat, 22 Sep 2018 04:36:26 -0400 Received: by mail-yw1-f65.google.com with SMTP id m129-v6so197254ywc.1 for ; Fri, 21 Sep 2018 19:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yrRrYun0p1t9laLCKRji1sYubxXnqAmGv2Md1D0qHZg=; b=Y1/fCvwPn0MIcPdmwqFf87GLIlWUaLTP+PbJax5jfzgp8W6WhL0FA0J9EYf/iO/xl7 bnZxWPNAm886937Xg9uRGRrr/T/m5YMmWYPHFbm2CMrGs+AOdhiC/Wcj6aP0/WieXV1W iVGTE1tAfyPM59q82oBPUQ85STCyOSuc43zsM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yrRrYun0p1t9laLCKRji1sYubxXnqAmGv2Md1D0qHZg=; b=KXdzz4gxMssU+ofc2qMW6uW7ZSHC2VUCBoFCy/4y4Mp4+jUUFJqeoLQfWdUbPgtJCm aww8eiUctMTB3F9JxBOAWyo+8LN6cyjJNTJt2mJjD6ARizIkgkFU8m1PDiidR4WVhXnr MKi2tdxc8Oqhk4HlmSvK2btiL3DalLYFeDYdEjZNDsokSrzeyFm2F/qNojzei4cUvMaJ p3SS2E8SeyitPVVki63cs6b+JCkxhhFeJAzPv0NRGVTw4uhpmYX4DdEtZJ311UFKiMLW GpCjSSD6Fri8w7QJgSxkNWsjrz3GOwmzULEnWGjv7b1qUK/vj2ZTNiwriIa610+jm1YU jKyQ== X-Gm-Message-State: APzg51C8I0BN6jElIufVx4BHe1umrCSM2t/MWTBwBXGhorkwTgAL7XAz 4SG2RH0x1T90+Mm7q6uI75ArnhGkmX4= X-Received: by 2002:a81:320a:: with SMTP id y10-v6mr194686ywy.509.1537584278317; Fri, 21 Sep 2018 19:44:38 -0700 (PDT) Received: from mail-yw1-f45.google.com (mail-yw1-f45.google.com. [209.85.161.45]) by smtp.gmail.com with ESMTPSA id z125-v6sm11979361ywg.57.2018.09.21.19.44.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 19:44:35 -0700 (PDT) Received: by mail-yw1-f45.google.com with SMTP id d193-v6so3097550ywb.3 for ; Fri, 21 Sep 2018 19:44:35 -0700 (PDT) X-Received: by 2002:a81:2288:: with SMTP id i130-v6mr206486ywi.288.1537584274961; Fri, 21 Sep 2018 19:44:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5f04:0:0:0:0:0 with HTTP; Fri, 21 Sep 2018 19:44:34 -0700 (PDT) In-Reply-To: <03191752-22d3-4066-3d3a-8fbe209447e5@schaufler-ca.com> References: <03191752-22d3-4066-3d3a-8fbe209447e5@schaufler-ca.com> From: Kees Cook Date: Fri, 21 Sep 2018 19:44:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 02/19] Smack: Abstract use of cred security blob To: Casey Schaufler Cc: LSM , James Morris , SE Linux , LKLM , John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Salvatore Mesoraca Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 21, 2018 at 5:17 PM, Casey Schaufler wrote: > Don't use the cred->security pointer directly. > Provide a helper function that provides the security blob pointer. > > Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook -Kees -- Kees Cook Pixel Security