Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp120931imm; Fri, 21 Sep 2018 19:53:37 -0700 (PDT) X-Google-Smtp-Source: ACcGV62UtPoB1q3qFdl/5BT7eKxjAsWwdLQCMFSirx1Aj+ftGwfT9BTUXRhrlxr+Ft4C/unx1qgL X-Received: by 2002:a17:902:5e3:: with SMTP id f90-v6mr486202plf.286.1537584817917; Fri, 21 Sep 2018 19:53:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537584817; cv=none; d=google.com; s=arc-20160816; b=It55i/FwHFLFzszcg8VdyO+pZxTOFfOXs0FFSkXS/uSYUZLfaXMxGhodXZIRtadcZv /eSye/58kjFxro974GSAiq3khVbOCx7eIZxXDEPmAhQh2tN7nAU6MRMNXeQ4AIUBlzb5 LeHIlvJkfNx2zKqN04FkxCy/NkoqrUUVsbZpDSCqlXEUTxupVo3kWqWwEDiqNUQwGpox rnvpG8FYIdO5hLHnkPPTeJZfbes+gbLf8rxDMOj3FHv+YqMjRvZdHUg6AbJCyV0bhkH+ rdM427v8T6cGuSOS4sanmKQf9Oz556kWaQJZQUGxH12qwlDb4aCKPcTOGAONEmphB9TF CJVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=/bCVzE+z4dYf3wj5e2EkaX0VB9eT0yZaoPf7lxF+jyQ=; b=s5Mutu9f3eUNRyMU6rIYvcU5AL8MJNoknSCj7bvE+nc3eyA1IA2KeVAbLCRlVP+zF7 lu6gKX+UxlABWNJSt317Wy0AhhcyLXLXSvPe3pjDwhPMrVlwLkbkNK/lK//Vmjdg/QDJ 674JGZQ9IA9bKhn5r1FLJkmSCKo1GIo4EfEEfmwO6adJCnhf03AWrPLrwKmB54O2BDn6 6DGt1gmcK7w6Yvf1Bdlq05kDBihM4NLYiz7d4io5ozgk9ISyLV5gqZouLEI6Z/66tMtv unnG98Fa7BQw2c5+Jsm9Q8W/eOXdhGk2oNniYKAmPTg6wwHWptZCFcq629NcAwXz8QWX MPmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Natt60Hq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i128-v6si30109275pfg.93.2018.09.21.19.53.22; Fri, 21 Sep 2018 19:53:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Natt60Hq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726213AbeIVIng (ORCPT + 99 others); Sat, 22 Sep 2018 04:43:36 -0400 Received: from mail-yb1-f193.google.com ([209.85.219.193]:36934 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbeIVIne (ORCPT ); Sat, 22 Sep 2018 04:43:34 -0400 Received: by mail-yb1-f193.google.com with SMTP id b3-v6so5205555yba.4 for ; Fri, 21 Sep 2018 19:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/bCVzE+z4dYf3wj5e2EkaX0VB9eT0yZaoPf7lxF+jyQ=; b=Natt60Hq3UKoxm7qfPUP/ZmWi6PH6GhB3yrgiug56+k/CxwpiaGCkmFMdOWpUsp8/6 Nr94RVW5q3cXpKEfYeMfcI8L08c7S5KGQXG6cBUOOzlvxFkoDL6d8UL6UMoRKvzE58tw Y7wBEy3ELbovhVsq0RwQgsNhOFxB0j6BNcb84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/bCVzE+z4dYf3wj5e2EkaX0VB9eT0yZaoPf7lxF+jyQ=; b=W1lZHM0eQVSGShcXw2Z6RiHi9hd9LXxCgMsNNvM7IQbKZJD3lT1k9wHONLKc9BR8YY 5EFeBGzpVtIymqz1g+CB263VtebiJ9feO27GL/+fG/oZMjNGL0+qM2Bm+C2qZPAK/YXR kPJig7C8Q3xPh1bMf2LsXOHE9ogmv5uRNAor8uyQAwuKp9MvdBj83HWX04l5NMMlSt1W ibumPkUxhZTZn21tDiP0hpcwhMx1RwDZNzqUhFsXr7jVGQJTklgugiPV+O4jbrKror5z /3qhL1lQ3VwWOHLC5tUJcFRISOlK/bk0wpmmkKWXKdRTLeadjMpztBmacggPNB7A/5rl pf3A== X-Gm-Message-State: ABuFfoijiUnyU6zNZGwQTPK1VD+2L5sLBOvpeVjZLwQ9K9a/jmd1zkXG 6oqLoAwehcvssE1jKpbRcDZnRribIzc= X-Received: by 2002:a25:49c1:: with SMTP id w184-v6mr217218yba.10.1537584704109; Fri, 21 Sep 2018 19:51:44 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id p124-v6sm1012453ywc.42.2018.09.21.19.51.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 19:51:40 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id 5-v6so6261566ybf.3 for ; Fri, 21 Sep 2018 19:51:39 -0700 (PDT) X-Received: by 2002:a25:e5c3:: with SMTP id c186-v6mr199890ybh.209.1537584699536; Fri, 21 Sep 2018 19:51:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5f04:0:0:0:0:0 with HTTP; Fri, 21 Sep 2018 19:51:38 -0700 (PDT) In-Reply-To: References: From: Kees Cook Date: Fri, 21 Sep 2018 19:51:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 10/19] Smack: Abstract use of file security blob To: Casey Schaufler Cc: LSM , James Morris , SE Linux , LKLM , John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Salvatore Mesoraca Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 21, 2018 at 5:18 PM, Casey Schaufler wrote: > Don't use the file->f_security pointer directly. > Provide a helper function that provides the security blob pointer. > > Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook -Kees -- Kees Cook Pixel Security