Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp336437imm;
Sat, 22 Sep 2018 01:11:39 -0700 (PDT)
X-Google-Smtp-Source: ACcGV603z3XFuL21DWmt6SGOe2OvkWEZkarP8YwcXJfqT0dAmj9nwTmqKpMQEZsZ7ojNAxJM2jrK
X-Received: by 2002:a63:4243:: with SMTP id p64-v6mr1370027pga.127.1537603899297;
Sat, 22 Sep 2018 01:11:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1537603899; cv=none;
d=google.com; s=arc-20160816;
b=Q+LMitvdQ2u9J91+5S+KtBiEGzgsv8O/JILTzWorOidz/pSYdzRdZajqoT40JOM420
t4RIgPz/vzfpZCZ5tiZAx7E2ww7AFTPB5C78AXUvBSX34lsWnaUkDXyB2O34cD1vv6VG
QcSh9NN+NUclJ7QV6fZrbT2Y8yCexO3zm0+fDXX8H+3JQasZ/hRAyWlTTLKc/f0QNgFi
YkUDyvLL3vyyVdgxFbiYSnSid1gMoWipUmu7wuzVppRE3HX9PNmizvUfAS9CzVfgUcA2
prJbXik9raNseIhKyz538mPEaKS9CTaEaXqsEIbEsLWxCVK0+CLSnXXavWecPXLVP/q4
3Xyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
h=list-id:precedence:sender:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:dkim-signature;
bh=tQB2gosLX8oDnCIIvPjmdmMwEnxM6Nwus1miMlxx9eM=;
b=HqHvNoXIkTuoosKdNl1aGZiZBY57jdegVwIbNED67Cx9FfbLWHTJjV6CPSL6dS8JB9
HpW0KEn2Fv7FL7y7K6mlaytk9ddX2wWAXPtlCP2IVAXTyeaUJW0vQPdsJ5fCcUo9zNly
sHnFuDVjDlRcS/Ygpcmwpnqf2BwuOsYEjWOGCy2RWMpDNNTHHWaXlRHJcIwowV82AQmf
hbZVwwjIsT9RX8iLkm0bXHE+7Wd0EuSn6sA7E4h0WvIFYO1CE2BnNmyXSuIscZjq0qR3
Acpl5a32TQBLFHSipu61e8XgXtqPF8CiqU1mDzQU8SXuilUPjGjl9Ta2dCpJL5j/tBcu
F5pA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@joelfernandes.org header.s=google header.b=xZbmpRXn;
spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path:
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
by mx.google.com with ESMTP id y38-v6si8440253pga.605.2018.09.22.01.11.08;
Sat, 22 Sep 2018 01:11:39 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
dkim=pass header.i=@joelfernandes.org header.s=google header.b=xZbmpRXn;
spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1726170AbeIVODp (ORCPT + 99 others);
Sat, 22 Sep 2018 10:03:45 -0400
Received: from mail-lj1-f195.google.com ([209.85.208.195]:46794 "EHLO
mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1725837AbeIVODp (ORCPT
);
Sat, 22 Sep 2018 10:03:45 -0400
Received: by mail-lj1-f195.google.com with SMTP id 203-v6so14011808ljj.13
for ; Sat, 22 Sep 2018 01:11:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=joelfernandes.org; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc;
bh=tQB2gosLX8oDnCIIvPjmdmMwEnxM6Nwus1miMlxx9eM=;
b=xZbmpRXnPDTIIIQjaPxmJ58k8n9ZdRCNgjB7uzh1HuHkBK/enqVlbNPnqLTWd5yJuv
Ruz0U6jHSzTMhUUTpNNqHrJ5dXnBrIQoAPSi2eKEjIQipdrRYmnw6l9kHcuZCSrOwWbR
sbXfi1gxKVaivbnQblZ+iNmeRpTJQjUaS2Jqw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=tQB2gosLX8oDnCIIvPjmdmMwEnxM6Nwus1miMlxx9eM=;
b=Kr7uNe+LgjAFKnDzimAv4OK0aQ8fVnAJdCbfkLd+Rc5iAFtg3rjtRXZ5X6f4ZGmpLD
XFjkxG4QX/umiBQG8szlXgrGeHn9CeJFVjX/w0UBH4iyneZPqpo+Egb2B+Up3UWviJ0r
jv+bW7SyQuXajTLT0wSOSekeMAJyhZwcGwdx1slo+NdwxZoiNxcEgXm9CuCnzgQBjTKV
jQ20Ra8I95qzjQvyHB79078LnqZAsFmdRltDzY/aFGyFKotE8Gewp1nzCHOWqok0u94f
Sw/skrmSHjvwnPf1/m9a2MI6LKk/EZRx+tj6xbmWw5NfKWvH0hTNEBBGe7X2HaobgOz+
9dbA==
X-Gm-Message-State: ABuFfogESsnh7sldEAamVsbxH9vgVZPJaisjb+ygLAocDwAdxJR9BzfR
xAvxWJ8taee4xni8RzuvXiys0rtuWG1mHA/BWq1gpg==
X-Received: by 2002:a2e:8098:: with SMTP id i24-v6mr4648892ljg.36.1537603862482;
Sat, 22 Sep 2018 01:11:02 -0700 (PDT)
MIME-Version: 1.0
References: <20180921223153.114728-1-joel@joelfernandes.org> <20180922011428.GU4222@linux.ibm.com>
In-Reply-To: <20180922011428.GU4222@linux.ibm.com>
From: Joel Fernandes
Date: Sat, 22 Sep 2018 04:10:51 -0400
Message-ID:
Subject: Re: [PATCH RFC] Documentation: RCU: Clarify comment about fanout
To: paulmck@linux.ibm.com
Cc: LKML ,
Jonathan Corbet ,
Josh Triplett ,
Lai Jiangshan ,
linux-doc@vger.kernel.org,
Mathieu Desnoyers ,
Steven Rostedt
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID:
X-Mailing-List: linux-kernel@vger.kernel.org
On Fri, Sep 21, 2018 at 9:14 PM Paul E. McKenney wrote:
>
> On Fri, Sep 21, 2018 at 06:31:53PM -0400, Joel Fernandes (Google) wrote:
> > RCU Data-Structures document describes a trick to test RCU with small
> > number of CPUs but with a larger tree. It wasn't immediately clear how
> > the document arrived at 16 CPUs which also requires setting the
> > FANOUT_LEAF to 2 instead of the default of 16. Clarify that.
> >
> > Signed-off-by: Joel Fernandes (Google)
>
> Good catch, applied, thank you! You know, those two Kconfig options
> are so closely linked in my mind that I doubt if I would ever have
> noticed this issue. So good show!
Thanks!
> I of course could not resist doing a bit of editing. Could you please
> check the following to make sure that I didn't mess something up?
Yes, the edit looks good and improved the changes ;-)
I have a few more as well, I'll send them out soon.
thanks!
- Joel
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit 9870c5b0f7b41a7b6085c20c22b320681800dabc
> Author: Joel Fernandes (Google)
> Date: Fri Sep 21 18:31:53 2018 -0400
>
> doc: Clarify RCU data-structure comment about rcu_tree fanout
>
> RCU Data-Structures document describes a trick to test RCU with small
> number of CPUs but with a taller tree. It wasn't immediately clear how
> the document arrived at 16 CPUs which also requires setting the
> FANOUT_LEAF to 2 instead of the default of 16. This commit therefore
> provides the needed clarification.
>
> Signed-off-by: Joel Fernandes (Google)
> Signed-off-by: Paul E. McKenney
>
> diff --git a/Documentation/RCU/Design/Data-Structures/Data-Structures.html b/Documentation/RCU/Design/Data-Structures/Data-Structures.html
> index 1d2051c0c3fc..476b1ac38e4c 100644
> --- a/Documentation/RCU/Design/Data-Structures/Data-Structures.html
> +++ b/Documentation/RCU/Design/Data-Structures/Data-Structures.html
> @@ -127,9 +127,11 @@ CPUs, RCU would configure the rcu_node tree as follows:
>
RCU currently permits up to a four-level tree, which on a 64-bit system
> accommodates up to 4,194,304 CPUs, though only a mere 524,288 CPUs for
> 32-bit systems.
> -On the other hand, you can set CONFIG_RCU_FANOUT to be
> -as small as 2 if you wish, which would permit only 16 CPUs, which
> -is useful for testing.
> +On the other hand, you can set both CONFIG_RCU_FANOUT and
> +CONFIG_RCU_FANOUT_LEAF to be as small as 2, which would result
> +in a 16-CPU test using a 4-level tree.
> +This can be useful for testing large-system capabilities on small test
> +machines.
>
>
This multi-level combining tree allows us to get most of the
> performance and scalability
>