Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 22 Sep 2018 18:14:07 +0200
From:   Christian Brauner <christian@brauner.io>
To:     David Howells <dhowells@redhat.com>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        Al Viro <viro@ZenIV.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] fsmount: do not use legacy MS_ flags
Message-ID: <20180922161406.6beo2ob6ki2otrjx@brauner.io>
References: <20180922132106.wfa6xaxwbu276qka@brauner.io>
 <20180921155455.flkf5vdrm3vgn6do@brauner.io>
 <20180920151214.15484-6-mszeredi@redhat.com>
 <20180920151214.15484-1-mszeredi@redhat.com>
 <17157.1537542475@warthog.procyon.org.uk>
 <20311.1537548756@warthog.procyon.org.uk>
 <8221.1537631312@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ggw43pqr6lmhvudm"
Content-Disposition: inline
In-Reply-To: <8221.1537631312@warthog.procyon.org.uk>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ggw43pqr6lmhvudm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 22, 2018 at 04:48:32PM +0100, David Howells wrote:
> Christian Brauner <christian@brauner.io> wrote:
>=20
> > mount_setattr(int dfd, const char *path, unsigned int atflags,
> >               unsigned int attr_cmd,
> > 	      unsigned int attr_values,
> > 	      unsigned int attr_mask);
>=20
> Whilst you can have up to six arguments on a syscall, I seem to remember =
that
> 6-arg syscalls require special handlers on some systems due to register c=
ount.

Sure, but if we wanted to we might just get the syscall down to five
arguments even with my suggestion. Of course, I'm not sure what the
reasons for all of the other arguments to this function are since it's
not yet implemented. Seems that attr_values and attr_mask could be
compacted to a single attr_mask maybe? :)

Christian

--ggw43pqr6lmhvudm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE7btrcuORLb1XUhEwjrBW1T7ssS0FAlumak4ACgkQjrBW1T7s
sS1DWA//cxvoc44u465NnCKqN2tw1U6zh7y9CgMb7ZMgX5wwcV1wa4ROQD44Uxf3
9j8MlrVSflsEe203BqueDytZbvPjfzSk94wGzudoHlDIIU2JhD7nT9oahw9jYkht
GAXHpm9sx46vvtIycG9bgXRsbRiKpexcC7clzzjAkohsS+b2tq7w8ywNme4FeNqt
c1bXgNHtxzuECCTU6f6uZJIwIvO/B1sgpAHpTAkkTLXH/AO5reSalp+O1PxkfvhT
3vb8pn1mt3cKE5XbmfniFaSEkowqGBgyeFFKDUE/tR+bEr9ko9MlANYFNLaa6Nq/
CaN/PzPGbkhVKLGf5pJlBUqKL6Am2NADm7bPG/p2KAJTHL+rQLBZVJuWWUnWbk5Z
5vbiTywkQMfnDtjAYmS7wfWIK/q93XVraVte0zMIw44Le3wMK2iHMj63qer1uzrx
2GvfpQJY3VHWDcCFriclYFgHrxJNl+jPXKHj+W7pbLx7157UJHMlkO691u6Qmnp/
954rx9YDDIRf+3SlgtvOzSKhGiEtNUWKCZKDOZovISFx+BhqKTsH5bsbG821MzGC
IFf1r/eDDZkDDW9mJlhjoZ9VtO+MD25O1UkgAp23vb2u/ubtkUqVR8CtsStBlxYK
O2wqyXotKw2pKRHnrSZIE/WfPIoN+gE58Z/kQRnrY5wgoBdK5Ic=
=dDqw
-----END PGP SIGNATURE-----

--ggw43pqr6lmhvudm--