Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <9017f05c55d2dd39f76f0a0e43c8ccbccdfaf9b4.camel@decadent.org.uk>
Subject: Re: [PATCH 3.16 51/63] xfs: catch inode allocation state mismatch
 corruption
From:   Ben Hutchings <ben@decadent.org.uk>
To:     Dave Chinner <dchinner@redhat.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        akpm@linux-foundation.org,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        Carlos Maiolino <cmaiolino@redhat.com>
Date:   Sat, 22 Sep 2018 21:57:27 +0100
In-Reply-To: <20180922052544.GB19103@rh>
References: <lsq.1537575341.194909669@decadent.org.uk>
         <lsq.1537575342.261199041@decadent.org.uk> <20180922052544.GB19103@rh>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-2cthv6C9qjk+h7PUJsZi"
User-Agent: Evolution 3.29.92-1 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-2cthv6C9qjk+h7PUJsZi
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2018-09-22 at 15:25 +1000, Dave Chinner wrote:
> On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote:
> > 3.16.58-rc1 review patch.  If anyone has any objections, please let
> > me know.
> >=20
> > ------------------
> >=20
> > From: Dave Chinner <dchinner@redhat.com>
> >=20
> > commit ee457001ed6c6f31ddad69c24c1da8f377d8472d upstream.
> >=20
> > We recently came across a V4 filesystem causing memory corruption
> > due to a newly allocated inode being setup twice and being added to
> > the superblock inode list twice. From code inspection, the only way
> > this could happen is if a newly allocated inode was not marked as
> > free on disk (i.e. di_mode wasn't zero).
>=20
> ....
> > Signed-Off-By: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> > Tested-by: Carlos Maiolino <cmaiolino@redhat.com>
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > [bwh: Backported to 3.16:
> >  - Look up mode in XFS inode, not VFS inode
> >  - Use positive error codes, and EIO instead of EFSCORRUPTED]
>=20
> Why EIO?

I believe EIO was the usual error code used for filesystem errors
before EFSCORRUPTED was added.  But now I see xfs had its own private
definition of EFSCORRUPTED.  I'll change this back.

Ben.

--=20
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.


--=-2cthv6C9qjk+h7PUJsZi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlumrLcACgkQ57/I7JWG
EQkhyg//anS3OVI11ZgyM9UU41HCGh+Qy7MSSiCjslz8QsqWnzChtE3N2goxNz4w
VgGugw36b1RePqSyz24+TCpJSHmNVIJ4HXX57WpNAS650qSIosm1LIagRHfCAB+w
yBLNoI3bXjtpKTAWi/YsBLGm4WNU/lMYBZu5MET59MqJH3pJbMyrklTQq+dV/pG+
bBP18mX5t5dtDB9/CPd2o7CpJxPhFOjyo9PuCV/lUJr4Fkt3jKzh5NIK3Ldv+SLj
jmXsu47lqksRSBLSpT3m9CPOE1oDWfrSHf8dIb/BkifSSeso4tbiI67AXmet0iJg
VyO/l8a/QIhoxVG7CzBky/zM+37CTSaAulKLNcopxQJFwcYAzSp0y6+Ujo3zTnGN
yreKUSWny0ePqyscaMMja56AI/isgXrsma/Cs/g/MUkLZpB3V0Dtd4zFjKpuypoq
WiUS7ltX49quvnw81N46pWLrMKl7hpRYppEg0yaquI3YzzIJ6s7PUyYgAekiI/Wi
abLJIgcaslpkE+J7IHs3rrF5OXqShJ3HEp0ZSdv4CHLpcUA1YYCqZmJ9rjqeowQT
P3wqn1YSBQZcZCB9WZ9T64OwI/SJ6fyAAtbD6WEbFVYdHVUM08Ob1qLuNBQxjibv
14+5D1BpqxjRc+lR3faxC/i5gJk1381yCoF0faie08EwzwpgUEw=
=mK0Q
-----END PGP SIGNATURE-----

--=-2cthv6C9qjk+h7PUJsZi--